Topic: WHat is this error mean?

[HasanCAD]

While runing a lisp some times gives this error

Code: [Select]

** Error: bad DXF group: (10) **

[roy_043]

Perhaps you have a point value that is/gets set to nil.

Code: [Select]

(setq point nil)
(cons 10 point) => (10)

[HasanCAD]

This is the part of code which case this crash

Code: [Select]

(defun makeline (str end Ltp lyr )
  (entmake (list (cons 0 "LINE") ; ***
               (cons 6 Ltp) ; Linetype name (present if not BYLAYER)
               (cons 8 lyr) ; Layer
               (cons 10 str) ; Start Point
               (cons 11 end) ; End Point
               (cons 39 0.0) ; Thickness (optional) default = 0
               (cons 62 256) ; Color number (present if not BYLAYER);
               (cons 210 (list 0.0 0.0 1.0)))))

(defun DVD ( dp1 dp2 n sc / DSD I K O SC )  ;(DVD dp1 dp2 n sc)
  (makeline dp1 dp2  "Continuous" "S-BARS-SECT-VERT") 
  (setq o (entlast))
  (setq n (- n 1))
  (setq dsd (/ (distance dp1 dp2) n))
  (setq i dsd)
  (repeat n (entmake (append (list '(0 . "INSERT")'(2 . "SS") '( 8 . "S-BARS-SECT-VERT") (cons 10 (vlax-curve-getpointatdist o i)))
     (mapcar '(lambda (k) (cons k sc)) (list 41 42 43)))) (setq i (+ dsd i)))
  (command "_.Erase" "last" "")
  (command "_.Erase" o "")
  )
)
When variable n=10 gives the error

Code: [Select]

(and (setq p1 (getpoint "\n Pick point"))
(setq p2 (getpoint "\n Pick point"))
(DVD p1 p2 10 16)
)

[Kerry]

I'll guess.
What is the makeline function?

[Kerry]

This code is a perfect demonstration of why problem code should be posted with a description of what the poster thinks the code is doing ... a description of the process, not the code.

added:
And the first thing you could do is check the matching Parenthesis

added:
Which version of AutoCAD are you using?

[Kerry]

This works for me .. as I assume you intended.
Note I've used the command-s for AC2015 .. revise to command to suit

Code - Auto/Visual Lisp: [Select]

1. (defun dvd (dp1 dp2 nodes scale / add-local-vars-later)
2.            ;|
3.      Insert block at <scale>, <node> times
4.      spaced equally between selected points
5.      with no insert at selected points
6. |;
7.   (makeline dp1 dp2 "Continuous" "S-BARS-SECT-VERT")
8.   (setq o                   (entlast)
9.         spacing             (/ (distance dp1 dp2) (1+ nodes))
10.         incrementeddistance spacing
11.   )
12.   (repeat nodes
13.     (entmake
14.       (append (list '(0 . "INSERT")
15.                     '(2 . "SS")
16.                     '(8 . "S-BARS-SECT-VERT")
17.                     (cons 10 (vlax-curve-getpointatdist o incrementeddistance))
18.               )
19.               (mapcar '(lambda (k) (cons k scale)) (list 41 42 43))
20.       )
21.     )
22.     (setq incrementeddistance (+ spacing incrementeddistance))
23.   )
24.   (command-s "_.Erase" o "")
25.   (princ)
26. )
27.  

Code - Auto/Visual Lisp: [Select]

1.  
2. ;; ASSUMES block "SS" exists in drawing.
3. (defun makeline (dp1 dp2 lt l)
4.   (command-s "_.LINE" dp1 dp2 "")
5. )
6.  
7. (if (and (setq dp1 (getpoint "\n Pick point"))
8.          (setq dp2   (getpoint dp1 "\n Pick point")
9.                nodes 8                  ; block inserts @ distance/(nodes+1)
10.                scale 16
11.          )
12.     )
13.   (dvd dp1 dp2 nodes scale)
14. )
15.  

[HasanCAD]

I am using CAD2014
Makeline its entmake line "added to Reply #2"

We draft strucural drawings, one of the task is draw details of column section and arranging the bars in this section (see attached)
This part of code inserts bars (lisp attached).
the lisp crashed when side bars is 10.

[Kerry]

 I see what your intent is now ( from your posted code)

How often do you get the error ?
How many people use the routine ?

Can you load it from the VLIDE ( as lisp code) with Debug->BreakOnError toggled on.
Then select Last Break Source when you get an error

added;
If you do this you will be able to investigate the variable values at the time of the error.

[roy_043]

The problem is probably caused by a rounding issue:
(setq dsd (/ lenLine 9))
(+ dsd dsd dsd dsd dsd dsd dsd dsd dsd) => can be bigger than lenLine due to rounding errors.

Why not replace this:

Code: [Select]

(repeat n
  ...
)
(command "_.Erase" "last" "")With:

Code: [Select]

(repeat (1- n)
  ...
)
Alternatively you can use ((vlax-curve-getendpoint o) or (vlax-get o 'endpoint) for the endpoint.

[HasanCAD]

This works for me .. as I assume you intended.
Note I've used the command-s for AC2015 .. revise to command to suit

Code - Auto/Visual Lisp: [Select]

1. (defun dvd (dp1 dp2 nodes scale / add-local-vars-later)
2.            ;|
3.      Insert block at <scale>, <node> times
4.      spaced equally between selected points
5.      with no insert at selected points
6. |;
7.   (makeline dp1 dp2 "Continuous" "S-BARS-SECT-VERT")
8.   (setq o                   (entlast)
9.         spacing             (/ (distance dp1 dp2) (1+ nodes))
10.         incrementeddistance spacing
11.   )
12.   (repeat nodes
13.     (entmake
14.       (append (list '(0 . "INSERT")
15.                     '(2 . "SS")
16.                     '(8 . "S-BARS-SECT-VERT")
17.                     (cons 10 (vlax-curve-getpointatdist o incrementeddistance))
18.               )
19.               (mapcar '(lambda (k) (cons k scale)) (list 41 42 43))
20.       )
21.     )
22.     (setq incrementeddistance (+ spacing incrementeddistance))
23.   )
24.   (command-s "_.Erase" o "")
25.   (princ)
26. )
27.  

Code - Auto/Visual Lisp: [Select]

1.  
2. ;; ASSUMES block "SS" exists in drawing.
3. (defun makeline (dp1 dp2 lt l)
4.   (command-s "_.LINE" dp1 dp2 "")
5. )
6.  
7. (if (and (setq dp1 (getpoint "\n Pick point"))
8.          (setq dp2   (getpoint dp1 "\n Pick point")
9.                nodes 8                  ; block inserts @ distance/(nodes+1)
10.                scale 16
11.          )
12.     )
13.   (dvd dp1 dp2 nodes scale)
14. )
15.  

When replace your subroutine DVD with mine error comes(attached)

[HasanCAD]

The problem is probably caused by a rounding issue:
(setq dsd (/ lenLine 9))
(+ dsd dsd dsd dsd dsd dsd dsd dsd dsd) => can be bigger than lenLine due to rounding errors.

Why not replace this:

Code: [Select]

(repeat n
  ...
)
(command "_.Erase" "last" "")With:

Code: [Select]

(repeat (1- n)
  ...
)
Alternatively you can use ((vlax-curve-getendpoint o) or (vlax-get o 'endpoint) for the endpoint.

solved the problem let me test on another machines

[Kerry]

The problem is probably caused by a rounding issue:
(setq dsd (/ lenLine 9))
(+ dsd dsd dsd dsd dsd dsd dsd dsd dsd) => can be bigger than lenLine due to rounding errors.

Why not replace this:

Code: [Select]

(repeat n
  ...
)
(command "_.Erase" "last" "")With:

Code: [Select]

(repeat (1- n)
  ...
)
Alternatively you can use ((vlax-curve-getendpoint o) or (vlax-get o 'endpoint) for the endpoint.

solved the problem let me test on another machines

If you look at my code, I don't draw and erase the last block, so my algorithm removed that issue.

[Kerry]

< ... >
When replace your subroutine DVD with mine error comes(attached)

When you run my code in isolation does the error occur  ?
Remember to change the command-s to command or vla-cmdf


I noticed you don't have an error routine in the code.
You should have at least something like this :

Code - Auto/Visual Lisp: [Select]

1. (defun *error* (s) (vl-bt) (princ))
2.  

Can you please do that and try again.

[HasanCAD]

Can you please do that and try again.

Sorry for being late

When you run my code in isolation does the error occur  ?

working very good but I made some changes

Code - Auto/Visual Lisp: [Select]

1. (defun dvd (dp1 dp2 nodes scale / add-local-vars-later)
2.            ;|
3.      Insert block at <scale>, <node> times
4.      spaced equally between selected points
5.      with no insert at selected points
6. |;
7.   (makeline dp1 dp2 "Continuous" "0")
8. (setq o                         (entlast)
9.       ds                        (distance dp1 dp2)      ;added
10.       spacing                   (/ ds (1- nodes))       ;instead of (1+ nodes)
11.       incrementeddistance       spacing
12. )
13.   (repeat nodes
14.     (if (or                                             ;Added
15.           (> ds incrementeddistance)
16.           (= ds incrementeddistance)
17.           )
18.     (progn
19.       (entmake
20.       (append (list '(0 . "INSERT")
21.                     '(2 . "SS")
22.                     '(8 . "S-BARS-SECT-VERT")
23.                     (cons 10 (vlax-curve-getpointatdist o incrementeddistance))
24.               )
25.               (mapcar '(lambda (k) (cons k scale)) (list 41 42 43)))
26.       )
27.       (setq incrementeddistance (+ spacing incrementeddistance))
28.       )
29.       )
30.     )
31.   (vl-cmdf "_.Erase" o "")                              ; instead of command-s
32.   (princ)
33. )

I noticed you don't have an error routine in the code.
You should have at least something like this :

Code - Auto/Visual Lisp: [Select]

1. (defun *error* (s) (vl-bt) (princ))
2.  

There is an error routine (3rd subroutine in main lisp).

[ur_naz]

I am using CAD2014
Makeline its entmake line "added to Reply #2"

We draft strucural drawings, one of the task is draw details of column section and arranging the bars in this section (see attached)
This part of code inserts bars (lisp attached).
the lisp crashed when side bars is 10.

Don't forget to add "_" to command options such as

Code - Auto/Visual Lisp: [Select]

1. (vl-cmdf "_.erase" "_last" "")

etc