Topic: Lisp Help: finding last point and inserting block at it

[AVCAD]

Hey all...

wrote this list...ugly as it as is it works....but I need to the last polyline point to be a variable so i can insert a block at it...

so far this will find the second point i select but not the last if i have more then 2 points.

Code - Auto/Visual Lisp: [Select]

1. (defun varget ()
2.   (setq lis '("orthomode"))
3.   (setq var (mapcar 'getvar lis))
4.   (setq var1 '(1))
5.   (setq no 0)
6.   (repeat (length lis)
7.     (setvar (nth no lis) (nth no var1))
8.     (setq no (1+ no))
9.   )
10.   (princ)
11. )
12.  
13. (defun varset ()
14.   ;;reset system variables above to 0
15.   (setq no 0)
16.   (repeat (length lis)
17.     (setvar (nth no lis) (nth no var))
18.     (setq no (1+ no))
19.   )
20.   (princ)
21. )
22.  
23. (princ)
24.  
25. (defun C:wire2 (/      pt1    pt2    pt3    blklay blkname       lay1
26.                 lay2   lay3   lay4   lay5   lay6   lay7   lay8
27.                 prevlayer     P      LN     CON
28.                )
29.   (progn
30.     (varget)
31.  
32.     (setq blkname "C:/xxxx/xxxx/xxxx.dwg")
33.  
34.     (setq lay1 "1_AV_LINE-VIDEO")
35.     (setq lay2 "1_AV_LINE-AUDIO")
36.     (setq lay3 "1_AV_LINE-COMM")
37.     (setq lay4 "1_AV_LINE-COAX")
38.     (setq lay5 "1_AV_LINE-CONTROL")
39.     (setq lay6 "1_AV_LINE-ETHERNET")
40.     (setq lay7 "1_AV_LINE-POWER")
41.     (setq lay8 "1_AV_LINE-FIBER")
42.  
43.     (setq prevlayer (getvar "clayer"))
44.     (setq P (getstring
45.               "Audio(A)/Video(V)/Control(C)/Ethernet(E)/Power(P):"
46.             )
47.     )
48.  
49.     (command "SNAP" "2.0")
50.  
51.     (setq pt1 (getpoint "\nSelect Starting Point:"))
52.     (IF (= P "V")
53.       (command "-LAYER" "M" lay1 "C" "84" "" "" "_.pline" pt1 PAUSE)
54.     )
55.     (setq pt2 (getvar "lastpoint"))
56.     (setq LN (entlast))
57.     (IF (= P "A")
58.       (command "-LAYER" "M" lay2 "C" "150" "" "" "_.pline" pt1 PAUSE)
59.     )
60.     (setq pt2 (getvar "lastpoint"))
61.     (setq LN (entlast))
62.     (IF (= P "CO")
63.       (command "-LAYER" "M" lay3 "C" "206" "" "" "_.pline" pt1 PAUSE)
64.     )
65.     (setq pt2 (getvar "lastpoint"))
66.     (setq LN (entlast))
67.     (IF (= P "R")
68.       (command "-LAYER" "M" lay4 "C" "44" "" "" "_.pline" pt1 PAUSE)
69.     )
70.     (setq pt2 (getvar "lastpoint"))
71.     (setq LN (entlast))
72.     (IF (= P "C")
73.       (command "-LAYER" "M" lay5 "C" "14" "" "" "_.pline" pt1 PAUSE)
74.     )
75.     (setq pt2 (getvar "lastpoint"))
76.     (setq LN (entlast))
77.     (IF (= P "E")
78.       (command "-LAYER" "M" lay6 "C" "144" "" "" "_.pline" pt1 PAUSE)
79.     )
80.     (setq pt2 (getvar "lastpoint"))
81.     (setq LN (entlast))
82.     (IF (= P "P")
83.       (command "-LAYER" "M" lay7 "C" "200" "" "" "_.pline" pt1 PAUSE)
84.     )
85.     (setq pt2 (getvar "lastpoint"))
86.     (setq LN (entlast))
87.     (IF (= P "F")
88.       (command "-LAYER" "M" lay8 "C" "30" "" "" "_.pline" pt1 PAUSE)
89.     )
90.     (setq pt2 (getvar "lastpoint"))
91.     (setq LN (entlast))
92.     (IF (= P "V")
93.       (setq blklay "1_AV_LINE-VIDEO")
94.     )
95.     (IF (= P "A")
96.       (setq blklay "1_AV_LINE-AUDIO")
97.     )
98.     (IF (= P "CO")
99.       (setq blklay "1_AV_LINE-COMM")
100.     )
101.     (IF (= P "R")
102.       (setq blklay "1_AV_LINE-COAX")
103.     )
104.     (IF (= P "C")
105.       (setq blklay "1_AV_LINE-CONTROL")
106.     )
107.     (IF (= P "E")
108.       (setq blklay "1_AV_LINE-ETHERNET")
109.     )
110.     (IF (= P "P")
111.       (setq blklay "1_AV_LINE-POWER")
112.     )
113.     (IF (= P "F")
114.       (setq blklay "1_AV_LINE-FIBER")
115.     )
116.     (while (> (getvar "CMDACTIVE") 0) (command "\\"))
117.     ;;
118.     ;;inserts 1st block at start of line
119.     ;;
120.     (command "attreq" "0")
121.     (command "break" LN pt1 "@12.0<0")
122.     (command "-insert" blkname pt1 "" "" "")
123.     (setq CON (entlast))
124.     (command "move" CON "" pt1 "@12.0<0")
125.     (command "EXPLODE" CON nil)
126.     (command "_.chprop" (ENTLAST) "" "LA" blklay "")
127.     (command "attreq" "1")
128.     ;;
129.     ;;inserts 2nd block at end of line
130.     ;;
131.     (command "break" LN pt2 "@12.0<180")
132.     (command "attreq" "0")
133.     (command "-insert" blkname pt2 "" "" "")
134.     (setq CON (entlast))
135.                                         ;(command "move" CON "" pt2 "@12.0<180")
136.     (command "EXPLODE" CON nil)
137.     (command "_.chprop" (ENTLAST) "" "LA" blklay "")
138.     (command "attreq" "1")
139.  
140.     (varset)
141.     (setvar "clayer" prevlayer)
142.     (princ)
143.   )
144. )

This is basically drawings a line and putting a block at the start point and one at the end point. I just cant get that end point.

Any help would be greatly appreciated!

Thanks in advance!

edit-kdub: add AutoLisp code tag to code pane

[mhupp]

Try this. it will have you draw the polyline first, then go back and pull points of each vertex and place the block on them. also using Cond instead of if
https://www.afralisp.net/autolisp/tutorials/cond-vs-if.php

Code - Auto/Visual Lisp: [Select]

1. (defun C:WIRE2 (/ blkname prevlayer rep)
2.   (progn
3.     (varget)
4.     ;save listed variables values as a list to restore later.
5.     ;(setq lst (list "clayer" "osnap" "osmode")
6.     ;      cur (mapcar 'getvar lst)
7.     ;)
8.     (setq blkname "C:/xxxx/xxxx/xxxx.dwg")
9.     (setq prevlayer (getvar "clayer"))
10.     (initget "Video Audio Coax Comm Control Ethernet Power")
11.     (setq rep ;will only accept words above
12.       (cond     ;also defaults to Video so you can just hit enter if that is your choice
13.         ((getkword "\n[V]ideo/(A)udio/(Co)Comm/(Cx)Coax/(C)ontrol/(E)thernet/(P)ower: ")) ("Video")
14.       )
15.     )
16.     (prompt "\nDraw Polyline Blocks will be added after")
17.     (cond
18.       ((= rep "Video")
19.         (command "-LAYER" "M" "1_AV_LINE-VIDEO" "C" "84" "" "")
20.       )
21.       ((= rep "Audio")
22.         (command "-LAYER" "M" "1_AV_LINE-AUDIO" "C" "150" "" "")
23.       )
24.       ((= rep "Comm")
25.         (command "-LAYER" "M" "1_AV_LINE-COMM" "C" "206" "" "")
26.       )
27.       ((= rep "Coax")
28.         (command "-LAYER" "M" "1_AV_LINE-COAX" "C" "44" "" "")
29.       )
30.       ((= rep "Control")
31.         (command "-LAYER" "M" "1_AV_LINE-CONTROL" "C" "14" "" "")
32.       )
33.       ((= rep "Ethernet")
34.         (command "-LAYER" "M" "1_AV_LINE-ETHERNET" "C" "144" "" "")
35.       )
36.       ((= rep "Power")
37.         (command "-LAYER" "M" "1_AV_LINE-POWER" "C" "200" "" "")
38.       )
39.       ((= rep "Fiber")
40.         (command "-LAYER" "M" "1_AV_LINE-FIBER" "C" "30" "" "")
41.       )
42.     )
43.     (command "_.pline")
44.     (if (setq coords (vl-remove-if 'not (mapcar (function (lambda (p) (if (= 10 (car p)) (cdr p)))) (entget (entlast)))))
45.       (foreach pt Coords
46.         (command "_.Insert" (strcat "*" blkname) pt "" "" "") ;* means it will explode block when inserted
47.       )
48.     )
49.     ; I don't know what you where doing with break and move took that out.
50.     (varset)
51.     ;(mapcar 'setvar lst cur) ;restores listed variables from start of lisp.
52.     (princ)
53.   )  ;Progn
54. )    ;defun

-edit fixed typo

[kdub_nz]

Perhaps try something like this.

first:
revise your assignment for var 'p' so the value is upperCase.

next:
create a separate function to 'make' the correct layer.
( seperation of concerns will make the core code easier to read and debug. )

next:
create a serarate function to draw the pline.
( same reason )

this will give you ONE location th assign a value to pt1 and pt2. from their it's a piece of cake

regards.

PS: I won't provide code 'cause you will learn more from modifying your own code.
and you have some stuff in there where I'm ot really sure of your intent.

[AVCAD]

Thanks for the input.

I tried the code above and it just says no function =REP.


I tried to rework some of my code and it looks like i got it work.

here is what i did, may not be pretty but works

Code: [Select]

(defun C:cwire (/ pt1 pt2 pt3 blklay blkname lay1 lay2 lay3 lay4 lay5 lay6 lay7 lay8 prevlayer prevsnapmode prevortho P LN CON firstpoint lastpoint)
(progn

;sets block being inserted path
(setq blkname "C:/xxxx/xxxx/xxxx.dwg")

;sets layer names to be recalled
(setq lay1 "1_AV_LINE-VIDEO")
(setq lay2 "1_AV_LINE-AUDIO")
(setq lay3 "1_AV_LINE-COMM")
(setq lay4 "1_AV_LINE-COAX")
(setq lay5 "1_AV_LINE-CONTROL")
(setq lay6 "1_AV_LINE-ETHERNET")
(setq lay7 "1_AV_LINE-POWER")
(setq lay8 "1_AV_LINE-FIBER")

;Sets system current settings to a variable to be recalled
(setq prevlayer (getvar "clayer"))
(setq prevsnapmode (getvar "osmode"))
(setq prevortho (getvar "orthomode"))

;sets system settings to SF requirements settings
(setvar "osmode" 0)
(setvar "orthomode" 1)
(command "SNAP" "2.0")

;gets what line type you want to use, will auto put on correct layer
(setq P (getstring "Audio(A)/Video(V)/Control(C)/Ethernet(E)/Power(P):"))

;runs command to make layer and draw line
;starting point
(setq pt1 (getpoint "\nSelect Starting Point:"))

;sets layer drawings line
(IF (or (= P "V")(= P "v"))(command "-LAYER" "M" lay1 "C" "84" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "A")(= P "a"))(command "-LAYER" "M" lay2 "C" "150" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "CO")(= P "co"))(command "-LAYER" "M" lay3 "C" "206" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "R")(= P "r"))(command "-LAYER" "M" lay4 "C" "44" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "C")(= P "c"))(command "-LAYER" "M" lay5 "C" "14" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "E")(= P "e"))(command "-LAYER" "M" lay6 "C" "144" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "P")(= P "p"))(command "-LAYER" "M" lay7 "C" "200" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "F")(= P "f"))(command "-LAYER" "M" lay8 "C" "30" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))

;set layer for block to be inserted on
(IF (or (= P "V")(= P "v"))(setq blklay "1_AV_LINE-VIDEO"))
(IF (or (= P "A")(= P "a"))(setq blklay "1_AV_LINE-AUDIO"))
(IF (or (= P "CO")(= P "co"))(setq blklay "1_AV_LINE-COMM"))
(IF (or (= P "R")(= P "r"))(setq blklay "1_AV_LINE-COAX"))
(IF (or (= P "C")(= P "c"))(setq blklay "1_AV_LINE-CONTROL"))
(IF (or (= P "E")(= P "e"))(setq blklay "1_AV_LINE-ETHERNET"))
(IF (or (= P "P")(= P "p"))(setq blklay "1_AV_LINE-POWER"))
(IF (or (= P "F")(= P "f"))(setq blklay "1_AV_LINE-FIBER"))
(while (> (getvar "CMDACTIVE") 0) (command "\\"))
[b][i](setq vertex_lst (vl-remove nil (mapcar '(lambda (x) (if (= (car x) 10) (cdr x))) (entget (entlast)))))
(setq firstpoint (nth 0 vertex_lst))
(setq lastpoint  (nth (- (length vertex_lst) 1) vertex_lst))[/i][/b]

;;inserts 1st block at start of line
(command "attreq" "0")
(command "break" LN firstpoint "@12.0<0")
(command "_.Insert" (strcat "*" blkname) firstpoint "" "")
(setq CON (entlast))
(command "move" CON "" firstpoint "@12.0<0")
(command "_.chprop" CON "" "LA" blklay "")
(command "attreq" "1")

;;inserts 2nd block at end of line
(command "attreq" "0")
(command "break" LN lastpoint "@12.0<180")
(command "_.Insert" (strcat "*" blkname) lastpoint "" "")
(setq CON (entlast))
(command "_.chprop" CON "" "LA" blklay "")
(command "attreq" "1")

;resets users current layer snapmode and ortho to the settings that were current prior to running command
(setvar 'clayer prevlayer)
(setvar 'osmode prevsnapmode)
(setvar 'orthomode prevortho)

(princ)
);Progn
 );defun

[JohnK]

You are getting that errror because mhupp had a few typos in his code (simple fix).

Code - Auto/Visual Lisp: [Select]

1. ...
2. (cond
3.    ((= rep "Video")
4.     (command "-LAYER" "M" "1_AV_LINE-VIDEO" "C" "84" "" ""))
5.    ((= rep "Audio")
6.     (command "-LAYER" "M" "1_AV_LINE-AUDIO" "C" "150" "" ""))
7.    ((= rep "Comm")
8.     (command "-LAYER" "M" "1_AV_LINE-COMM" "C" "206" "" ""))
9. ...

However, kdub_nz suggested you try to seperate out your functions (good advice). See the following for a simple example:
https://www.theswamp.org/index.php?topic=58149.msg613580#msg613580
If you design your programs like this (break them up into small chunks of operations) the "main program"--which just assembles those chunks into a logical pattern--is so much easier.

That-being-said, you have some syntax issues with your code; for example, with the "SETS LAYER DRAWING LINE" section.
The satement "(SETQ LN (ENTLAST))" will be issued many times because those statements are not related to the IF statement(s)).

I would really attempt to create separate functions to help you lay-out the program easier!

[JohnK]

...
https://www.afralisp.net/autolisp/tutorials/cond-vs-if.php
...

I miss talking with Kenny. He was a lot of fun.

[AVCAD]

OK so I tried to rework some of this in to function programs to call up instead of just running everything. This code works great for what I want it to do. The only portion i cant get to work is trimming or breaking the line that is drawn at the 3rd and 4th blocks being inserted.

What this does is:
Clock button (or run command), select what type of line (ie audio, video etc..), draw polyline (no nothing is in the z direction), trims line at the start point and end points, inserts connector block at start and end of line, inserts cable label block at 36 units from start and end point of line drawn, (this is where it doesnt work)..trim or break line at this block (block is 24 units total, 12 from mid point left and right)

Code: [Select]

(defun C:cwire (/ pt1 pt2 pt3 blklay blkname blkname2 lay1 lay2 lay3 lay4 lay5 lay6 lay7 lay8 prevlayer prevsnapmode prevortho P LN CON1 CON2 firstpoint lastpoint)
(setstuff)
(getstuff)
(dostuff)
(resetstuff)
(princ)
);defun

(progn

(defun setstuff ()
;sets block being inserted path
(setq blkname "C:/xxx/xxx/CONNECTOR.dwg")
(setq blkname2 "C:/xxx/xxx/WIRE LABEL.dwg")

;sets layer names to be recalled
(setq lay1 "1_AV_LINE-VIDEO")
(setq lay2 "1_AV_LINE-AUDIO")
;;(setq lay3 "1_AV_LINE-COMM")
;;(setq lay4 "1_AV_LINE-COAX")
(setq lay5 "1_AV_LINE-CONTROL")
(setq lay6 "1_AV_LINE-ETHERNET")
(setq lay7 "1_AV_LINE-POWER")
(setq lay8 "1_AV_LINE-FIBER")

;Sets system current settings to a variable to be recalled
(setq prevlayer (getvar "clayer"))
(setq prevsnapmode (getvar "osmode"))
(setq prevortho (getvar "orthomode"))

;sets system settings to SF requirements settings
(setvar "osmode" 0)
(setvar "orthomode" 1)
(command "SNAP" "2.0")
(princ)
)

(defun getstuff ()
;gets what line type you want to use, will auto put on correct layer
(setq P (getstring "Audio(A)/Video(V)/Control(C)/Ethernet(E)/Power(P):"))

;runs command to make layer and draw line
;starting point
(setq pt1 (getpoint "\nSelect Starting Point:"))

;sets layer drawings line
(IF (or (= P "V")(= P "v"))(command "-LAYER" "M" lay1 "C" "84" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "A")(= P "a"))(command "-LAYER" "M" lay2 "C" "150" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
;;(IF (or (= P "CO")(= P "co"))(command "-LAYER" "M" lay3 "C" "206" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
;;(IF (or (= P "R")(= P "r"))(command "-LAYER" "M" lay4 "C" "44" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "C")(= P "c"))(command "-LAYER" "M" lay5 "C" "14" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "E")(= P "e"))(command "-LAYER" "M" lay6 "C" "144" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "P")(= P "p"))(command "-LAYER" "M" lay7 "C" "200" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
(IF (or (= P "F")(= P "f"))(command "-LAYER" "M" lay8 "C" "30" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))

;set layer for block to be inserted on
(IF (or (= P "V")(= P "v"))(setq blklay "1_AV_LINE-VIDEO"))
(IF (or (= P "A")(= P "a"))(setq blklay "1_AV_LINE-AUDIO"))
;;(IF (or (= P "CO")(= P "co"))(setq blklay "1_AV_LINE-COMM"))
;;(IF (or (= P "R")(= P "r"))(setq blklay "1_AV_LINE-COAX"))
(IF (or (= P "C")(= P "c"))(setq blklay "1_AV_LINE-CONTROL"))
(IF (or (= P "E")(= P "e"))(setq blklay "1_AV_LINE-ETHERNET"))
(IF (or (= P "P")(= P "p"))(setq blklay "1_AV_LINE-POWER"))
(IF (or (= P "F")(= P "f"))(setq blklay "1_AV_LINE-FIBER"))
(while (> (getvar "CMDACTIVE") 0) (command "\\"))
(setq vertex_lst (vl-remove nil (mapcar '(lambda (x) (if (= (car x) 10) (cdr x))) (entget (entlast)))))
(setq firstpoint (nth 0 vertex_lst))
(setq lastpoint  (nth (- (length vertex_lst) 1) vertex_lst))
(princ)
)


(defun dostuff ()
;;inserts 1st block at start of line: CONNECTOR
(command "attreq" "0")
(command "break" LN firstpoint "@12.0<0")
(command "_.Insert" (strcat "*" blkname) firstpoint "" "")
(setq CON1 (entlast))
(command "move" CON1 "" firstpoint "@12.0<0")
(command "_.chprop" CON1 "" "LA" blklay "")
(command "attreq" "1")

;;inserts 2nd block at end of line: CONNECTOR
(command "attreq" "0")
(command "break" LN lastpoint "@12.0<180")
(command "_.Insert" (strcat "*" blkname) lastpoint "" "")
(setq CON2 (entlast))
(command "_.chprop" CON2 "" "LA" blklay "")
(command "attreq" "1")

;;inserts 3rd block at start of line: WIRE LABEL
(command "attreq" "0")
(command "_.Insert" (strcat "*" blkname2) firstpoint "" "")
(setq LBL1 (entlast))
(command "move" LBL1 "" firstpoint "@36.0<0")
(command "_.chprop" LBL1 "" "LA" blklay "")
(command "attreq" "1")

;;inserts 4th block at end of line: WIRE LABEL
(command "attreq" "0")
(command "_.Insert" (strcat "*" blkname2) lastpoint "" "")
(setq LBL2 (entlast))
(command "move" LBL2 "" firstpoint "@36.0<180")
(command "_.chprop" LBL2 "" "LA" blklay "")
(command "attreq" "1")
(princ)
)

(defun resetstuff ()
;resets users current layer snapmode and ortho to the settings that were current prior to running command
(setvar 'clayer prevlayer)
(setvar 'osmode prevsnapmode)
(setvar 'orthomode prevortho)
(princ)
)

(princ)
);Progn

Thanks for any help in advance! You guys/gals here are the best.

[JohnK]

haha ...nice function names. Very descriptive.

I would like to give you a bit of direction of how you structure your functions/code. The following are just a few sections from your `getstuff` function. This is how I would begin to split this up into little chunks. Play with these functions and understand what they do and allow you to NOT do (for example, try to BREAK the `getlinetypekeyword` and the `getpt` functions).

Please NOTE: This is not the most efficient way to code this operation, but it will give you a very good introduction and a formula for how to use the 'chunks' you make.

Code - Auto/Visual Lisp: [Select]

1. (defun getpt (/ pt)
2.   ;; getpt
3.   ;; This function will prompt the user for a point until a valid point is picked.
4.   ;;
5.   ;; EX: (setq pt (getpt))
6.   ;; RETURNS: point
7.   (while
8.     (not (setq pt (getpoint "\nSelect point: ")))
9.     )
10.   pt
11.   )
12.  
13. (defun getlinetypekeyword ( )
14.   ;; getlinetypekeyword
15.   ;; This function will prompt user for a keyword to set the linetype.
16.   ;;
17.   ;; EX: (setq p (getlinetypekeyword))
18.   ;; RETURNS: A keyword.
19.   (initget 0 "Audio Video Control Ethernet Power")
20.   (cond
21.     ((getkword "\nAudio(A)/Video(V)/Control(C)/Ethernet(E)/Power(P) <Audio>: "))
22.     ("Audio"))
23.   )
24.  
25. (defun createlayer (name color)
26.   ;; createlayer
27.   ;; This function will create a layer based on name and color and set it current.
28.   ;;
29.   ;; EX: (createlayer "LAYER1" "1")
30.   ;; RETURNS: nil
31.   (command "_.layer" "m" name "c" color "" "")
32.   (princ)
33.  )
34.  
35.  
36. (defun c:main-test ( / pt keywd)
37.   ;; main-test
38.   ;; This function will prompt the user for a point and...
39.   ;;
40.  
41.   ;; ...
42.  
43.   ;; in the main function you start assembling the parts like this:
44.   (setq pt (getpt)                                ; -Get a point from the enduser
45.         keywd (getlinetypekeyword)                ; -Get a keyword from the enduser
46.                                                   ;  which will be used to create a layer.
47.         )
48.  
49.   (if (equal keywd "Video")
50.     (createlayer "1_AV_LINE-VIDEO" "84"))         ; -Create a layer for `Video`.
51.   (if (equal keywd "Audio")
52.     (createlayer "1_AV_LINE-AUDIO" "150"))        ; -Create a layer for `Audio`.
53.  
54.   ;; ...
55.   (princ)
56.  )

EDIT: Removed unnecessary variable decl.

[AVCAD]

Thanks John K

I will review this and see what I can do.

[AVCAD]

Well, I got this to work...except i can only draw my lines from left to right...not a huge deal but someone will complain eventually....

I used LeeMac's Autobreak for this to work
http://lee-mac.com/autoblockbreak.html

I am loading his routine and then calling it up in my routine to trim my line to my blocks.

Yes Yes ugly code....but it works! I am sure someone can make it nicer and probably do this in way less code.

Thanks for the Help much appreciated.

Code - Auto/Visual Lisp: [Select]

1. (defun C:cwire (/ pt1 pt2 pt3 blklay blkname blkname2 lay1 lay2 lay3 lay4 lay5 lay6 lay7 lay8 prevlayer prevsnapmode prevortho P LN CON1 CON2 firstpoint lastpoint)
2. (setq echo (getvar 'cmdecho))
3. (setvar 'cmdecho 0)
4. (Needtoload)
5. (setstuff)
6. (getstuff)
7. (dostuff)
8. (resetstuff)
9. (setvar 'cmdecho echo)
10. (princ)
11. );defun
12.  
13. (progn
14.  
15. (defun needtoload ()
16. (load "AutoBlockBreakV1-9")
17. (princ)
18. )
19.  
20. ;sets block being inserted path
21. (defun setstuff ()
22. (setq blkname "C:/AutoCAD - Custom/Lisps/CONNECTOR.dwg")
23. (setq blkname2 "C:/AutoCAD - Custom/Lisps/WIRE LABEL.dwg")
24.  
25. ;sets layer names to be recalled
26. (setq lay1 "1_AV_LINE-VIDEO")
27. (setq lay2 "1_AV_LINE-AUDIO")
28. ;;(setq lay3 "1_AV_LINE-COMM")---future
29. ;;(setq lay4 "1_AV_LINE-COAX")---future
30. (setq lay5 "1_AV_LINE-CONTROL")
31. (setq lay6 "1_AV_LINE-ETHERNET")
32. (setq lay7 "1_AV_LINE-POWER")
33. (setq lay8 "1_AV_LINE-FIBER")
34.  
35. ;Sets system current settings to a variable to be recalled
36. (setq prevlayer (getvar "clayer"))
37. (setq prevsnapmode (getvar "osmode"))
38. (setq prevortho (getvar "orthomode"))
39.  
40. ;sets system settings to SF requirements settings
41. (setvar "osmode" 0)
42. (setvar "orthomode" 1)
43. (command "SNAP" "2.0")
44. (princ)
45. )
46.  
47. (defun getstuff ()
48. ;gets what line type you want to use, will auto put on correct layer
49. (setq P (getstring "Audio(A)/Video(V)/Control(C)/Ethernet(E)/Power(P):"))
50.  
51. ;runs command to make layer and draw line
52. ;starting point
53. (setq pt1 (getpoint "\nSelect Starting Point:"))
54.  
55. ;sets layer drawings line
56. (IF (or (= P "V")(= P "v"))(command "-LAYER" "M" lay1 "C" "84" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
57. (IF (or (= P "A")(= P "a"))(command "-LAYER" "M" lay2 "C" "150" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
58. ;;(IF (or (= P "CO")(= P "co"))(command "-LAYER" "M" lay3 "C" "206" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))---future
59. ;;(IF (or (= P "R")(= P "r"))(command "-LAYER" "M" lay4 "C" "44" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))----future
60. (IF (or (= P "C")(= P "c"))(command "-LAYER" "M" lay5 "C" "14" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
61. (IF (or (= P "E")(= P "e"))(command "-LAYER" "M" lay6 "C" "144" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
62. (IF (or (= P "P")(= P "p"))(command "-LAYER" "M" lay7 "C" "200" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
63. (IF (or (= P "F")(= P "f"))(command "-LAYER" "M" lay8 "C" "30" "" "" "_.pline" pt1 PAUSE))(setq LN (entlast))
64.  
65. ;set layer for block to be inserted on
66. (IF (or (= P "V")(= P "v"))(setq blklay "1_AV_LINE-VIDEO"))
67. (IF (or (= P "A")(= P "a"))(setq blklay "1_AV_LINE-AUDIO"))
68. ;;(IF (or (= P "CO")(= P "co"))(setq blklay "1_AV_LINE-COMM"))----future
69. ;;(IF (or (= P "R")(= P "r"))(setq blklay "1_AV_LINE-COAX"))----future
70. (IF (or (= P "C")(= P "c"))(setq blklay "1_AV_LINE-CONTROL"))
71. (IF (or (= P "E")(= P "e"))(setq blklay "1_AV_LINE-ETHERNET"))
72. (IF (or (= P "P")(= P "p"))(setq blklay "1_AV_LINE-POWER"))
73. (IF (or (= P "F")(= P "f"))(setq blklay "1_AV_LINE-FIBER"))
74. (while (> (getvar "CMDACTIVE") 0) (command "\\"))
75. (setq vertex_lst (vl-remove nil (mapcar '(lambda (x) (if (= (car x) 10) (cdr x))) (entget (entlast)))))
76. (setq firstpoint (nth 0 vertex_lst))
77. (setq lastpoint  (nth (- (length vertex_lst) 1) vertex_lst))
78. (princ)
79. )
80.  
81. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
82. ;;inserts 1st block at start of line: CONNECTOR;;;
83. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
84. (defun dostuff (/ pt3)
85. (command "attreq" "0")
86. (command "break" LN firstpoint "@12.0<0")
87. (command "_.Insert" (strcat "*" blkname) firstpoint "" "")
88. (setq CON1 (entlast))
89. (command "move" CON1 "" firstpoint "@12.0<0")
90. (command "_.chprop" CON1 "" "LA" blklay "")
91. (command "attreq" "1")
92.  
93. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
94. ;;inserts 2nd block at end of line: CONNECTOR;;;;;
95. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
96. (command "attreq" "0")
97. (command "break" LN lastpoint "@12.0<180")
98. (command "_.Insert" (strcat "*" blkname) lastpoint "" "")
99. (setq CON2 (entlast))
100. (command "_.chprop" CON2 "" "LA" blklay "")
101. (command "attreq" "1")
102.  
103. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
104. ;;inserts 3rd block at start of line: WIRE LABEL;;
105. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
106. (command "attreq" "0")
107. (command "_.Insert" (strcat "*" blkname2) firstpoint "" "")
108. (setq LBL1 (entlast))
109. (command "move" LBL1 "" firstpoint "@36.0<0")
110. (command "_.chprop" LBL1 "" "LA" blklay "")
111. (command "attreq" "1")
112. (LM:AutoBlockBreak LBL1 t)
113.  
114. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
115. ;;inserts 4th block at end of line: WIRE LABEL;;;;
116. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
117. (command "attreq" "0")
118. (command "_.Insert" (strcat "*" blkname2) lastpoint "" "")
119. (setq LBL2 (entlast))
120. (command "move" LBL2 "" firstpoint "@36.0<180")
121. (command "_.chprop" LBL2 "" "LA" blklay "")
122. (command "attreq" "1")
123. (LM:AutoBlockBreak LBL2 t)
124. (princ)
125. )
126.  
127. (defun resetstuff ()
128. ;resets users current layer snapmode and ortho to the settings that were current prior to running command
129. (setvar 'clayer prevlayer)
130. (setvar 'osmode prevsnapmode)
131. (setvar 'orthomode prevortho)
132. (princ)
133. )
134. (princ)
135. )
136.  
137.