Topic: Challenge: Rename Drawing

[JohnK]

I am so lost now...

I managed to incorporate Johns code and have the pop-up populated with the current filename but something is still not right.
I type the new filename in the dialog, hit enter. The new filename appears on the command line, and I must hit enter again.
Then I end up with a file called ".dwg.dwg"

Can you please help
--->%

You are very close. The line you had wrong was:
  (setq nDwgName (getstring 1 (getstring-dlg (strcase (acet-filename-ext-remove (getvar 'DWGNAME)))))
it should be:
  (setq nDwgName (getstring-dlg (strcase (acet-filename-ext-remove (getvar 'DWGNAME))))

Here is a complete code that should work. Although, there are some other areas of the code which I think should be corrected but I do not have the time at the moment, and this should work fine for now.

Code - Auto/Visual Lisp: [Select]

1. ;;;COMMAND: RENDWG
2. ;;;FUNCTION: Save current drawing as a new one with user specified name and
3. ;;;          delete original drawing if successful.
4. ;;;NOTES: Current drawing should have been saved prior to using this command.
5. ;;;By: Kelie Feng, April 2006.
6. ;;;Revised C.Potter December 2023. (https://www.theswamp.org/index.php?topic=9696.0)
7. ;;;  
8. (defun GetString-dlg (str / dcl_id fn fo)
9.   (setq fn (vl-filename-mktemp "" "" ".dcl"))
10.   (setq fo (open fn "w"))
11.   (setq ValueStr (strcat "value = \"" str "\";"))
12.   (write-line "stringdlg : dialog {
13.                            label = \"Enter New Filename\";" fo
14.   )
15.  
16.   (write-line ": edit_box {
17.              label = \"\";
18.              edit_width = 30;
19.              key = \"stringdlg\";
20.                            is_default = true; " fo
21.   )
22.  
23.   (write-line ValueStr fo)
24.   (write-line "}" fo)
25.   (write-line ": row {
26.              alignment   = centered;
27.              fixed_width = true;
28.               : button {
29.               label      = \"OK\";
30.               key        = \"dcl_accept\";
31.               width      = 10;
32.               allow_accept = true;
33.             }
34.           }
35.                    }" fo
36.   )
37.  
38.   (close fo)
39.   (setq dcl_id (load_dialog fn))
40.   (new_dialog "stringdlg" dcl_id)
41.   (action_tile "stringdlg" "(setq str $value)(done_dialog)")
42.   (start_dialog)
43.   (unload_dialog dcl_id)
44.   str
45. )
46. (defun C:RENDWG1 (/ *ERROR* app saveAsType doc oPath oDwgName dir nDwgName nPath)
47.   (setq app (vlax-get-acad-object)
48.         saveAsType (vla-get-saveastype
49.                      (vla-get-opensave
50.                        (vla-get-preferences app)
51.                        )
52.                      )
53.         doc (vla-get-activedocument app)
54.         oPath (vla-get-fullname doc)
55.         oDwgName (vla-get-name doc)
56.         dir (getvar "DWGPREFIX")
57.         )
58.   (setq nDwgName (getstring-dlg (strcase (acet-filename-ext-remove (getvar 'DWGNAME))))
59.         nPath (strcat dir nDwgName ".dwg")
60.         )
61.   (if (or (not (findfile nPath))
62.           (KF:Yes? nil
63.                    (strcat "File \"" nDwgName ".dwg\"" " exists. Overwrite?")
64.                    )
65.           )
66.     (if (not
67.           (vl-catch-all-error-p
68.             (vl-catch-all-apply
69.               (function
70.                 (lambda ()
71.                   (vla-saveas doc nPath saveAsType)
72.                   (vl-file-delete oPath)
73.                   )
74.                 )
75.               )
76.             )
77.           )
78.       (prompt "\nDone.")
79.       (prompt "\nRename/delete failed.")
80.       )
81.     )
82.   (princ)
83.   )
84.  
85. (defun KF:Yes? (default msg / input)
86.   (initget "Yes No")
87.   (setq input (getkword (strcat "\n"
88.                                 msg
89.                                 " [Yes/No] <"
90.                           (if default
91.                             "Y"
92.                             "N"
93.                           )
94.                                 ">: "
95.                         )
96.               )
97.   )
98.   (cond
99.     ((= input "Yes") t)
100.     ((= input "No") nil)
101.     (t default)
102.   )
103. )
104.  
105. (princ)

[dexus]

Here is a version using powershell to create a saveFileDialog.
It falls back on getfiled when something doesn't work.
I should have spent less time on this, but I got a bit obsessed with getting a resizable file dialog.

Code - Auto/Visual Lisp: [Select]

1. ;; COMMAND: RENDWG
2. ;; FUNCTION: Save current drawing as a new one with user specified name and
3. ;;           delete original drawing if successful.
4. ;; NOTES: Current drawing should have been saved prior to using this command.
5. ;; By: Kelie Feng, April 2006.
6. ;; Revised C.Potter December 2023. (https://www.theswamp.org/index.php?topic=9696.0)
7. ;; Revised dexus Januari 2024, using filePicker
8. (defun c:rendwg (/ acobj saveAsType oPath sPath nPath)
9.   (setq acobj (vlax-get-acad-object)
10.         saveAsType (vla-get-saveastype (vla-get-opensave (vla-get-preferences acobj)))
11.         oPath (vla-get-fullname (vla-get-activedocument acobj))
12.         sPath (fnsplitl oPath)
13.         nPath (filePicker (car sPath) (cadr sPath) (substr (caddr sPath) 2)))
14.   (cond
15.     ((not nPath) (princ "\nNo file selected."))
16.     ((not (vl-catch-all-error-p (vl-catch-all-apply
17.         (function (lambda nil
18.           (vla-saveas (vla-get-activedocument acobj) nPath saveAsType)
19.           (vl-file-delete oPath)
20.         ))
21.       )))
22.       (princ
23.         (strcat
24.           "\nFile renamed"
25.           "\n From: \"" (apply 'strcat (cdr (fnsplitl oPath))) "\""
26.           "\n To:   \"" (apply 'strcat (cdr (fnsplitl nPath))) "\""
27.         )
28.       )
29.     )
30.     ((princ "\nRename/delete failed."))
31.   )
32.   (princ)
33. )
34.  
35. (defun filePicker (directory filename extension / appHandle dch des pickedFile rtn shell tmp tmpopen tmpoutput)
36.   ; FilePicker by dexus
37.   ; Create filePicker using a .bat file based on https://stackoverflow.com/a/15885133/4301351
38.   (cond
39.     ((and
40.         (setq tmp (vl-filename-mktemp nil nil ".bat")) ; Create .bat that executes a html file selector
41.         (setq des (open tmp "w"))
42.         (write-line
43.           (strcat
44.             "<# : chooser.bat \n"
45.             ":: launches a File... Open sort of file chooser and outputs choice(s) to the console\n"
46.             ":: https://stackoverflow.com/a/15885133/4301351\n"
47.             "@echo off\n"
48.             "setlocal\n"
49.             "for /f \"delims=\" %%I in ('powershell -noprofile \"iex (${%~f0} | out-string)\"') do (\n"
50.             "  echo You chose %%~I\n"
51.             ")\n"
52.             "goto :EOF\n"
53.             ": end Batch portion / begin PowerShell hybrid chimera #>\n"
54.             "Add-Type -AssemblyName System.Windows.Forms\n"
55.             "$f = new-object Windows.Forms.SaveFileDialog\n"
56.             "$f.InitialDirectory = \"" directory "\"\n"
57.             "$f.FileName = \"" filename "\"\n"
58.             "$f.Filter = \""
59.               (cond
60.                 ((= "dwg" (strcase extension t)) "AutoCAD Drawing (*.dwg)|*.dwg")
61.                 ((= "dxf" (strcase extension t)) "AutoCAD DXF (*.dxf)|*.dxf")
62.                 ("All Files (*.*)|*.*") ; Default
63.               )
64.             "\"\n$f.FilterIndex = 1\n"
65.             "$f.DefaultExt = \"" extension "\";"
66.             "$f.ShowHelp = $true\n"
67.             "[void]$f.ShowDialog()\n"
68.             "$f.FileName"
69.           )
70.           des
71.         )
72.         (not (close des))
73.         (setq tmpoutput (vl-filename-mktemp nil nil ".txt")) ; Create txt file for the return value
74.         (setq shell (vla-getinterfaceobject (vlax-get-acad-object) "WScript.shell")) ; Shell to run the bat
75.         (setq appHandle (vl-catch-all-apply 'vlax-invoke (list shell 'Run (strcat "cmd /c " tmp ">" tmpoutput) 0 :vlax-false))) ; Execute hidden
76.         (vlax-release-object shell) ; Clean up shell object
77.         (not (vl-catch-all-error-p appHandle)) ; If no errors were found
78.         (setq tmpopen (open tmpoutput "r")) ; Open txt file
79.         (setq pickedFile (read-line tmpopen)) ; Read line
80.         (not (close tmpopen)) ; Close txt file
81.       )
82.     )
83.     ((setq pickedFile (getfiled "" (strcat directory filename) extension 1)) ; Fallback
84.       (setq pickedFile (strcat "You chose " pickedFile))
85.     )
86.   )
87.   (if (and tmp (setq tmp (findfile tmp))) (vl-file-delete tmp)) ; Cleanup .bat file
88.   (if (and tmpoutput (setq tmpoutput (findfile tmpoutput))) (vl-file-delete tmpoutput)) ; Cleanup .txt file
89.   (if
90.     (and
91.       pickedFile
92.       (wcmatch pickedFile "You chose *")
93.       (/= (setq pickedFile (substr pickedFile 11)) filename)
94.       (/= pickedFile (strcat directory filename "." extension))
95.     )
96.     pickedFile ; Return path if path was picked
97.   )
98. )

Edit: Removed dependencies

[stevej]

Here is a version using powershell to create a saveFileDialog.
It falls back on getfiled when something doesn't work.
I should have spent less time on this, but I got a bit obsessed with getting a resizable file dialog.

Was not able to find copies of LM:acobj or LM:acdoc called in your program.
Can you share these?

Steve

[stevej]

Here is a complete code that should work. Although, there are some other areas of the code which I think should be corrected but I do not have the time at the moment, and this should work fine for now.

This works well. Thank you.

Steve

[CraigP]

Thanks John, this is exactly what I was trying to achieve. 
Sorry for the delayed reply, I have only just returned from leave.

I am so lost now...

I managed to incorporate Johns code and have the pop-up populated with the current filename but something is still not right.
I type the new filename in the dialog, hit enter. The new filename appears on the command line, and I must hit enter again.
Then I end up with a file called ".dwg.dwg"

Can you please help
--->%

You are very close. The line you had wrong was:
  (setq nDwgName (getstring 1 (getstring-dlg (strcase (acet-filename-ext-remove (getvar 'DWGNAME)))))
it should be:
  (setq nDwgName (getstring-dlg (strcase (acet-filename-ext-remove (getvar 'DWGNAME))))

Here is a complete code that should work. Although, there are some other areas of the code which I think should be corrected but I do not have the time at the moment, and this should work fine for now.

Code - Auto/Visual Lisp: [Select]

1. ;;;COMMAND: RENDWG
2. ;;;FUNCTION: Save current drawing as a new one with user specified name and
3. ;;;          delete original drawing if successful.
4. ;;;NOTES: Current drawing should have been saved prior to using this command.
5. ;;;By: Kelie Feng, April 2006.
6. ;;;Revised C.Potter December 2023. (https://www.theswamp.org/index.php?topic=9696.0)
7. ;;;  
8. (defun GetString-dlg (str / dcl_id fn fo)
9.   (setq fn (vl-filename-mktemp "" "" ".dcl"))
10.   (setq fo (open fn "w"))
11.   (setq ValueStr (strcat "value = \"" str "\";"))
12.   (write-line "stringdlg : dialog {
13.                            label = \"Enter New Filename\";" fo
14.   )
15.  
16.   (write-line ": edit_box {
17.              label = \"\";
18.              edit_width = 30;
19.              key = \"stringdlg\";
20.                            is_default = true; " fo
21.   )
22.  
23.   (write-line ValueStr fo)
24.   (write-line "}" fo)
25.   (write-line ": row {
26.              alignment   = centered;
27.              fixed_width = true;
28.               : button {
29.               label      = \"OK\";
30.               key        = \"dcl_accept\";
31.               width      = 10;
32.               allow_accept = true;
33.             }
34.           }
35.                    }" fo
36.   )
37.  
38.   (close fo)
39.   (setq dcl_id (load_dialog fn))
40.   (new_dialog "stringdlg" dcl_id)
41.   (action_tile "stringdlg" "(setq str $value)(done_dialog)")
42.   (start_dialog)
43.   (unload_dialog dcl_id)
44.   str
45. )
46. (defun C:RENDWG1 (/ *ERROR* app saveAsType doc oPath oDwgName dir nDwgName nPath)
47.   (setq app (vlax-get-acad-object)
48.         saveAsType (vla-get-saveastype
49.                      (vla-get-opensave
50.                        (vla-get-preferences app)
51.                        )
52.                      )
53.         doc (vla-get-activedocument app)
54.         oPath (vla-get-fullname doc)
55.         oDwgName (vla-get-name doc)
56.         dir (getvar "DWGPREFIX")
57.         )
58.   (setq nDwgName (getstring-dlg (strcase (acet-filename-ext-remove (getvar 'DWGNAME))))
59.         nPath (strcat dir nDwgName ".dwg")
60.         )
61.   (if (or (not (findfile nPath))
62.           (KF:Yes? nil
63.                    (strcat "File \"" nDwgName ".dwg\"" " exists. Overwrite?")
64.                    )
65.           )
66.     (if (not
67.           (vl-catch-all-error-p
68.             (vl-catch-all-apply
69.               (function
70.                 (lambda ()
71.                   (vla-saveas doc nPath saveAsType)
72.                   (vl-file-delete oPath)
73.                   )
74.                 )
75.               )
76.             )
77.           )
78.       (prompt "\nDone.")
79.       (prompt "\nRename/delete failed.")
80.       )
81.     )
82.   (princ)
83.   )
84.  
85. (defun KF:Yes? (default msg / input)
86.   (initget "Yes No")
87.   (setq input (getkword (strcat "\n"
88.                                 msg
89.                                 " [Yes/No] <"
90.                           (if default
91.                             "Y"
92.                             "N"
93.                           )
94.                                 ">: "
95.                         )
96.               )
97.   )
98.   (cond
99.     ((= input "Yes") t)
100.     ((= input "No") nil)
101.     (t default)
102.   )
103. )
104.  
105. (princ)

[dexus]

Here is a version using powershell to create a saveFileDialog.
It falls back on getfiled when something doesn't work.
I should have spent less time on this, but I got a bit obsessed with getting a resizable file dialog.

Was not able to find copies of LM:acobj or LM:acdoc called in your program.
Can you share these?

Steve

Oops, I removed the dependencies. Could you give it another try?

[CraigP]

Hi Dexus,

I get 2 dialogs when I run this version?
If I cancel the 2nd dialog then enter the new filename everything works as expected.

Here is a version using powershell to create a saveFileDialog.
It falls back on getfiled when something doesn't work.
I should have spent less time on this, but I got a bit obsessed with getting a resizable file dialog.

Was not able to find copies of LM:acobj or LM:acdoc called in your program.
Can you share these?

Steve

Oops, I removed the dependencies. Could you give it another try?

[dexus]

CraigP, looks like something works differently in Bricscad.
One of the checks will return false where Autocad returns true.
I'll have to do some testing, but I don't have it installed on this computer.