Topic: Lighten layers' colors

[w64bit]

I am using black background and with this script I lighten darker layer colors.
- first color row in Color window will be assigned the next row below
- last row row in Color window will be assigned the next row above
Is there any way to slim the code, without using too many lisp functions?

Code: [Select]

(vlax-for layer (vla-get-Layers (vla-get-ActiveDocument (vlax-get-Acad-Object)))
(if (= 18 (vla-get-Color layer))(vla-put-Color layer 16))
(if (= 28 (vla-get-Color layer))(vla-put-Color layer 26))
(if (= 38 (vla-get-Color layer))(vla-put-Color layer 36))
(if (= 48 (vla-get-Color layer))(vla-put-Color layer 46))
(if (= 58 (vla-get-Color layer))(vla-put-Color layer 56))
(if (= 68 (vla-get-Color layer))(vla-put-Color layer 66))
(if (= 78 (vla-get-Color layer))(vla-put-Color layer 76))
(if (= 88 (vla-get-Color layer))(vla-put-Color layer 86))
(if (= 98 (vla-get-Color layer))(vla-put-Color layer 96))
(if (= 108 (vla-get-Color layer))(vla-put-Color layer 106))
(if (= 118 (vla-get-Color layer))(vla-put-Color layer 116))
(if (= 128 (vla-get-Color layer))(vla-put-Color layer 126))
(if (= 138 (vla-get-Color layer))(vla-put-Color layer 136))
(if (= 148 (vla-get-Color layer))(vla-put-Color layer 146))
(if (= 158 (vla-get-Color layer))(vla-put-Color layer 156))
(if (= 168 (vla-get-Color layer))(vla-put-Color layer 166))
(if (= 178 (vla-get-Color layer))(vla-put-Color layer 176))
(if (= 188 (vla-get-Color layer))(vla-put-Color layer 186))
(if (= 198 (vla-get-Color layer))(vla-put-Color layer 196))
(if (= 208 (vla-get-Color layer))(vla-put-Color layer 206))
(if (= 218 (vla-get-Color layer))(vla-put-Color layer 216))
(if (= 228 (vla-get-Color layer))(vla-put-Color layer 226))
(if (= 238 (vla-get-Color layer))(vla-put-Color layer 236))
(if (= 248 (vla-get-Color layer))(vla-put-Color layer 246))
(if (= 19 (vla-get-Color layer))(vla-put-Color layer 17))
(if (= 29 (vla-get-Color layer))(vla-put-Color layer 27))
(if (= 39 (vla-get-Color layer))(vla-put-Color layer 37))
(if (= 49 (vla-get-Color layer))(vla-put-Color layer 47))
(if (= 59 (vla-get-Color layer))(vla-put-Color layer 57))
(if (= 69 (vla-get-Color layer))(vla-put-Color layer 67))
(if (= 79 (vla-get-Color layer))(vla-put-Color layer 77))
(if (= 89 (vla-get-Color layer))(vla-put-Color layer 87))
(if (= 99 (vla-get-Color layer))(vla-put-Color layer 97))
(if (= 109 (vla-get-Color layer))(vla-put-Color layer 107))
(if (= 119 (vla-get-Color layer))(vla-put-Color layer 117))
(if (= 129 (vla-get-Color layer))(vla-put-Color layer 127))
(if (= 139 (vla-get-Color layer))(vla-put-Color layer 137))
(if (= 149 (vla-get-Color layer))(vla-put-Color layer 147))
(if (= 159 (vla-get-Color layer))(vla-put-Color layer 157))
(if (= 169 (vla-get-Color layer))(vla-put-Color layer 167))
(if (= 179 (vla-get-Color layer))(vla-put-Color layer 177))
(if (= 189 (vla-get-Color layer))(vla-put-Color layer 187))
(if (= 199 (vla-get-Color layer))(vla-put-Color layer 197))
(if (= 209 (vla-get-Color layer))(vla-put-Color layer 207))
(if (= 219 (vla-get-Color layer))(vla-put-Color layer 217))
(if (= 229 (vla-get-Color layer))(vla-put-Color layer 227))
(if (= 239 (vla-get-Color layer))(vla-put-Color layer 237))
(if (= 249 (vla-get-Color layer))(vla-put-Color layer 247))
(if (= 250 (vla-get-Color layer))(vla-put-Color layer 7))
(princ))


[kpblc]

Only idea (30 seconds to create):
(if (or (member (vla-get-color layer) '(18 28 38 48 58 68 78 88 98 108 118 128 138 148 158 168 178 188 198 208 218 228 238 248))
(member (vla-get-color layer) '(19 29 39 49 59 69 79 89 99 109 119 129 139 149 159 169 179 189 199 209 219 229 239 249))
)
(vla-put-color layer (- (vla-get-color layer) 2)))

[kpblc]

I thought you can recognize - change all your if's to my code and check how it works.

Code - Auto/Visual Lisp: [Select]

1. (vl-load-com)
2. (defun t1 (/ adoc)
3.   (vla-startundomark (setq adoc (vla-get-activedocument (vlax-get-acad-object))))
4.   (vlax-for layer (vla-get-layers (vla-get-activedocument (vlax-get-acad-object)))
5.     (if (or (member (vla-get-color layer)
6.                     '(18 28 38 48 58 68 78 88 98 108 118 128 138 148 158 168 178 188 198 208 218 228 238 248)
7.             ) ;_ end of member
8.             (member (vla-get-color layer)
9.                     '(19 29 39 49 59 69 79 89 99 109 119 129 139 149 159 169 179 189 199 209 219 229 239 249)
10.             ) ;_ end of member
11.         ) ;_ end of or
12.       (vla-put-color layer (- (vla-get-color layer) 2))
13.     ) ;_ end of if
14.   ) ;_ end of vlax-for
15.   (vla-endundomark adoc)
16.   (princ)
17. ) ;_ end of defun

[w64bit]

Thank you.

[roy_043]

Code - Auto/Visual Lisp: [Select]

1. (vl-load-com)
2.  
3. (defun test (/ doc)
4.   (setq doc (vla-get-activedocument (vlax-get-acad-object)))
5.   (vla-startundomark doc)
6.   (vlax-for lay (vla-get-layers doc)
7.     (setq aci (vla-get-color lay))
8.     (cond
9.       ((= aci 250)
10.         (vla-put-color lay 7)
11.       )
12.       ((< aci 18)
13.         nil
14.       )
15.       ((vl-position (rem aci 10) '(8 9))
16.         (vla-put-color lay (- aci 2))
17.       )
18.     )
19.   )
20.   (vla-endundomark doc)
21.   (princ)
22. )