Topic: Error Solution 101..

[ScottMC]

Hope some solution can be found to resolve the selection and option desired for this tool acquired from "Kent Cooper, 8 October 2019" 1. It is helpful but errors on line or *open space* selection and 2. would be nicer to accept current fillet radius. Just started to understanding an *error* trap for this. Any help would be great. Thanks

Code - Auto/Visual Lisp: [Select]

1. (defun C:RFSR (/ *error* doc asel arc adata)  
2. Kent Cooper, 8 October 2019
3.   (defun *error* (errmsg)
4.     (if (not
5.           (wcmatch errmsg
6.                    "Function cancelled,quit / exit abort,console break"
7.           ) ;_ end of wcmatch
8.         ) ;_ end of not
9.       (princ (strcat "\nError: " errmsg))
10.     )                                             ; if
11.     (vla-endundomark doc)
12.     (princ)
13.   )                                               ; defun - *error*
14.   (vla-startundomark
15.     (setq doc (vla-get-activedocument (vlax-get-acad-object)))
16.   ) ;_ end of vla-startundomark
17.  
18.   (setvar 'cmdecho 0)
19.   (princ " < Previous/Current Radius: ")
20.   (princ (getvar 'filletrad))
21.   (setq
22.     asel (entsel
23.            " >\n Set New Radius by Selecting an Arc/Circle [Poly=0]: "
24.          ) ;_ end of entsel
25.   ) ;_ end of setq
26.   (while
27.     (and
28.       (member '(0 . "ARC,CIRCLE")
29.               (setq adata (entget (setq arc (car asel))))
30.       ) ;_ end of member
31.     )                                             ;and
32.      (setvar "filletrad" (cdr (assoc 40 adata)))
33.      (princ "\n < Active Fillet Radius: ")
34.      (princ (getvar 'filletrad))
35.      (princ " >")
36.      (command "_.fillet")
37.   )                                               ;while
38.  
39.   (setq doc (vla-get-activedocument (vlax-get-acad-object)))
40.   (vla-endundomark doc)
41.   (setvar 'cmdecho 1)
42.   (princ)
43. )    
44.  

[kdub_nz]

Hi Scott,
This may resolve your immediate issues as I understand them.

Design-wise :
It will become a pain having to select the arc radius each time.
Being able to select a poly arc would be nice. There are several ways to test .. have a look at

Code: [Select]

(vlax-property-available-p obj prop [check-modify])
I modified the *error* method so you could do the clean-up a little prettier.

I like your thought about being able to choose the current filletrad value, but that is another issue that would require a redesign of the flow.

Code - Auto/Visual Lisp: [Select]

1. (defun C:RFSR (/ *error* doc asel adata)
2.   ;;; Kent Cooper, 8 October 2019
3.   (defun *error* (errmsg)
4.     (if
5.       (and
6.         errmsg
7.         (not
8.           (wcmatch
9.             errmsg
10.             "Function cancelled,quit / exit abort,console break"
11.           )
12.         )
13.       )
14.       (princ (strcat "\nError: " errmsg))
15.     )
16.     (vla-endundomark doc)
17.     (setvar 'cmdecho 1)
18.     (princ)
19.   )
20.   ;;-----------------
21.   (vla-startundomark
22.     (setq doc (vla-get-activedocument (vlax-get-acad-object)))
23.   )
24.   (setvar 'cmdecho 0)
25.  
26.   (princ " < Previous/Current Radius: ")
27.   (princ (getvar 'filletrad))
28.   ;;-----------------
29.  
30.   (while
31.     (and
32.       (setq asel (entsel
33.                    " >\n Set New Radius by Selecting an Arc/Circle [Poly=0]: "
34.                  )
35.       )
36.       (setq adata (entget (car asel)))
37.       (member (cdr (assoc 0 adata)) (list "ARC" "CIRCLE"))
38.     )
39.     (setvar "filletrad" (cdr (assoc 40 adata)))
40.     (princ "\n < Active Fillet Radius: ")
41.     (princ (getvar 'filletrad))
42.     (princ " >")
43.     (command-s "_.fillet")
44.   )
45.  
46.   (*error* nil)
47.   (princ)
48. )
49.  

[ScottMC]

   Excellent Kerry. Simply moved the 'echo' switch and reworded the prompts. Added that poly to the list to ease its option. Now, the last, helpful addition would to jump straight into 'multiple fillet' using the new/picked radius. Thanks much.

   --> moved the Fillet and works better.

Code - Auto/Visual Lisp: [Select]

1.     (defun C:RFSR (/ *error* doc asel adata)
2.       ;;; Kent Cooper, 8 October 2019
3.             (setvar 'cmdecho 0)
4.       (defun *error* (errmsg)
5.         (if
6.           (and
7.             errmsg
8.             (not
9.               (wcmatch
10.                 errmsg
11.                 "Function cancelled,quit / exit abort,console break"
12.               )
13.             )
14.           )
15.           (princ (strcat "\nError: " errmsg))
16.         )
17.         (vla-endundomark doc)
18.        ; (setvar 'cmdecho 1)
19.         (princ)
20.       )
21.       ;;-----------------
22.       (vla-startundomark
23.         (setq doc (vla-get-activedocument (vlax-get-acad-object)))
24.       )
25.  
26.      
27.       ;(princ " < Previous/Current Radius: ")
28.       ;(princ (getvar 'filletrad))
29.       ;;-----------------
30.      
31.       (while
32.         (and
33.           (setq asel (entsel
34.                        "\n Pick an Arc/Circle for Radius: [POLY=0] < Enter to Continue > "
35.                      )
36.           )
37.           (setq adata (entget (car asel)))
38.           (member (cdr (assoc 0 adata)) (list "ARC" "CIRCLE" "LWPOLYLINE"))
39.         )
40.         (setvar "filletrad" (cdr (assoc 40 adata)))      
41.         (princ "\n              < Active Fillet Radius: ")
42.         (princ (getvar 'filletrad))
43.         (princ " >")
44.                   ;(command "_.fillet") <- moved this outside the while!
45.        ) ; end of while
46.       (command "_.fillet") ;;  now it accepts new or previous radius
47.                                     ;;  with *enter/rightclk *
48.      (setvar 'cmdecho 1)
49.       (*error* nil)
50.       (princ)
51.     )
52.