Topic: List to create layer or midify exist create gives error

[HasanCAD]

Based on lee's code I created a lisp to create a layer if not exist and redfine if exist.
when run

Code - Auto/Visual Lisp: [Select]

1. (lyrmk "test" 3 "Hidden" "018" t 30 "Test-Test")

the lisp work great put with mapcar and lambda gives error

The error

Code: [Select]

; error: ActiveX Server returned an error: Parameter not optional

Code - Auto/Visual Lisp: [Select]

1. (DEFUN C:TEST ( / a b c d e f g)
2.   (mapcar
3.     '(lambda (a b c d e F G) (lyrmk a b c d e f g))
4.     '("A-GRID" "A-GRID-OUT" "A-MTRL-FBRC") ; Name       [Str]
5.     '(10 21 20 ) ; Colours      [Int]
6.     '("CENTER2" "CENTER2" "Continuous") ; LineType      [Str]
7.     '("015" "015" "018" ) ; LineWeight  [Str] 0.18 = "018"
8.     '(T T T ) ; Plottable       (T or nil)
9.     '(0 0 0 ) ; Transperency (<0 tp 90>)
10.     '("Planning" "Planning" "Windows")
11.     )
12.   )
13.  
14. (defun lyrmk (Nme Col lTyp lWgt Plt trns dsc / lay lyrs cmd) ;lee mac
15.   ;http://www.cadtutor.net/forum/showthread.php?36882-Check-create-layer-issue-in-Lisp&p=243520&viewfull=1#post243520
16.   (vl-load-com)
17.   (setq cmd (getvar 'cmdecho))
18.   (setvar 'cmdecho 0)  
19.   (if (not (tblsearch "LTYPE" Nme))
20.     (progn
21.       (setq lyrs (vla-get-layers (vla-get-ActiveDocument (vlax-get-acad-object))))
22.       (setq lay (vla-add lyrs Nme))
23.       (mdfy)
24.     )
25.     (progn
26.       (mdfy)
27.     )
28.   )
29.   (setvar 'cmdecho cmd)
30. )
31.  
32. (defun lTload (lTyp)
33.   (or (tblsearch "LTYPE" lTyp)
34.       (vla-load (vla-get-Linetypes (vla-get-ActiveDocument (vlax-get-acad-object)))
35.                 lTyp
36.                 "acad.lin")))
37.  
38. (defun mdfy (/)
39.   (setq entVL (vlax-ename->vla-object (tblobjname "LAYER" Nme)))  
40.   (and Col (vla-put-Color entVL Col))
41.   (and lTyp (lTload lTyp) (vla-put-Linetype entVL lTyp))
42.   (and lWgt (vla-put-LineWeight entVL (eval (read (strcat "acLnWt" lWgt)))))
43.   (and (not Plt) (vla-put-Plottable entVL :vlax-false))
44.   (and (setq LyrDs (vlax-put-property entVL 'Description dsc)))
45.   (setq rtns (vl-cmdf "_.-layer" "_TR" trns Nme ""))
46. )

[MP]

mapcar is not the best tool for the task, foreach in concert with apply would be a more appropriate fit.

Code: [Select]

(foreach args

   '(
        ("A-GRID"      10 "CENTER2"    "015" T 0 "Planning")
        ("A-GRID-OUT"  21 "CENTER2"    "015" T 0 "Planning") 
        ("A-MTRL-FBRC" 20 "Continuous" "018" T 0 "Windows")   
    )       
   
    (apply 'lyrmk args)

)

[roy_043]

On line 19 change:

Code: [Select]

(tblsearch "LTYPE" Nme)To:

Code: [Select]

(tblsearch "LAYER" Nme)

[HasanCAD]

Thanks MP
Thanks roy_043

the code runs one time good but gives the same error
I animated the code gives error on 42 when editing lineweight.

Code - Auto/Visual Lisp: [Select]

1.   (and lWgt (vla-put-LineWeight entVL (eval (read (strcat "acLnWt" lWgt)))))

[roy_043]

I cannot reproduce this. Maybe you have an invalid value for 'lWgt' in the latest version of your code?

[JohnK]

I created some code you may be interested in. It is very quick and makes new layers and redefines ones that are not correct. It reads all the layer information from a file and it even has a method to save drawing layer settings. [ https://www.theswamp.org/index.php?topic=23173.msg291095#msg291095 ]

It never made it past the "concept" stage but, honestly, it is more then safe to use (I just labeled it `concept' because I never got more then a few minutes at a time to work on it so I didn't get a lot of time to look for bugs and/or better methods).