Topic: help with a lisp

[CAB]

Here is an observation; on options 1 & 2 you addresses the condition where the area was below a minimum value but in condition 3 you did not.
See my changes where option 3 has an error trap for values below 750.
Note also that condition statements will stop evaluating the conditions when one is true.
Therefore you do not need to bracket the value like

Code: [Select]

(and (> area 2000) (< area 4000))when you have already dealt with values below 2000 because the processing will never get this far for values <= 2000.
See my changes there too.
Lastly the last condition can simply be True and not

Code: [Select]

(> area 8000) as all other conditions have been addressed.

I also changed you user input for options 1 - 4 to use getKword instead of getinit.
This is a personal preference.

Code - Auto/Visual Lisp: [Select]

1. (defun c:test4 (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
2.   (defun _option1 ()
3.     (cond ((<= area 200)
4.            (setq sdarea area
5.                  skarea (* area 0.7)
6.            )
7.           )
8.           ((< area 700)
9.            (setq sdarea 240
10.                  skarea (* area 0.6)
11.            )
12.           )
13.           (
14.            (setq sdarea 400
15.                  skarea (* area 0.6)
16.            )
17.           )
18.     )
19.   )
20.   (defun _option2 ()
21.     (cond ((<= area 2000)
22.            (setq sdarea (* area 0.8)
23.                  skarea (* area 0.6)
24.            )
25.           )
26.           (t
27.            (setq sdarea (+ 400 (* 0.05 (- area 2000)))
28.                  skarea (* area 0.1)
29.            )
30.           )
31.     )
32.   )
33.  
34.   (defun _option3 ()
35.     (cond ((< area 750)
36.            (princ "\nERROR: Area is too small")
37.           )
38.           ((= area 750)
39.            (setq sdarea 100
40.                  skarea (* area 0.1)
41.            )
42.           )
43.           ((<= area 1200)
44.            (setq sdarea (+ 100 (/ (- area 750) 9))
45.                  skarea (* area 0.1)
46.            )
47.           )
48.           ((<= area 2000)
49.            (setq sdarea (+ 150 (/ (- area 1200) 16))
50.                  skarea (* area 0.1)
51.            )
52.           )
53.           ((< area 4000)
54.            (setq sdarea 0
55.                  skarea 0
56.            )
57.           )
58.           ((= area 4000)
59.            (setq sdarea 200
60.                  skarea (* area 0.1)
61.            )
62.           )
63.           ((<= area 8000)
64.            (setq sdarea (+ 200 (* 0.02 (- area 4000)))
65.                  skarea (* area 0.1)
66.            )
67.           )
68.           (t
69.            (setq sdarea (+ 280 (* 0.01 (- area 8000)))
70.                  skarea (* area 0.1)
71.            )
72.           )
73.     )
74.   )
75.  
76.   (defun _option4 ()
77.     (initget 7)
78.     (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
79.     (initget 7)
80.     (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
81.   )
82.  
83.  
84.  
85.   ;; Main -----
86.   (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
87.            (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
88.            (member (cdr (assoc 70 dxf)) '(1 129))
89.       )
90.     (progn
91.       (textpage)
92.       (prompt
93.         (strcat "\n choose option :" "\n " "\n  1. Choose 1 for this ..." "\n  2. Choose 2 for this ..."
94.                 "\n  3. Choose 3 for this ..." "\n  4. Choose 4 for this ..." "\n"
95.                )
96.       )
97.       (setq area (vlax-curve-getarea ent))
98.       (initget 1 "1 2 3 4")
99.       (setq option (getkword "Select Option 1 to 4 : ")
100.       )
101.       (cond ((= option "1") (_option1))
102.             ((= option "2") (_option2))
103.             ((= option "3") (_option3))
104.             ((= option "4") (_option4))
105.       )
106.       (if area
107.         (princ (strcat "\n Selected Area = "
108.                        (rtos area 2 2)
109.                        "\n D = "
110.                        (rtos sdarea 2 2)
111.                        " sq.m"
112.                        "\n K = "
113.                        (rtos skarea 2 2)
114.                        " sq.m"
115.                )
116.         )
117.       )
118.     )
119.     (princ "\n-> No valid polyline selected...")
120.   )
121.   (princ)
122. )
123. (princ)
124.  
125.  ;|«Visual LISP© Format Options»
126. (120 2 2 2 nil "end of " 100 9 1 1 1 nil T nil T)
127. ;*** DO NOT add text below the comment! ***|;

[pedroantonio]

Kerry i have another question

1) I change all the code with this ,but i have some erros
2) i want to add two different comments at the end

a) if   (oldare - anox) =< area <=(oldare + anox)  then print comment 1
b) if    area > (oldare + anox)  or   area < (oldare - anox)  then print comment 2

Code - Auto/Visual Lisp: [Select]

1. (DEFUN
2.    C:test(/ _OPTION1 _OPTION2 OLDARE AREA DXF ENT ANOX)
3.   (DEFUN
4.      _OPTION1 ()
5.     (SETQ ANOX (* OLDARE 0.05))
6.     DEFUN
7.     _OPTION2
8.     ()
9.     (SETQ ANOX (* OLDARE 0.10))
10.     ;; Main -----
11.     (IF (AND
12.           (SETQ ENT (CAR (ENTSEL "\nSelect a close polyline: ")))
13.           (SETQ OLDARE (GETREAL "\ngive old area : "))
14.           (WCMATCH
15.             (CDR (ASSOC 0 (SETQ DXF (ENTGET ENT))))
16.             "*POLYLINE"
17.           )
18.           (MEMBER (CDR (ASSOC 70 DXF)) '(1 129))
19.         )
20.       (PROGN
21.         (INITGET 7)
22.         (TEXTPAGE)
23.         (PROMPT "\n text1  :
24.  
25.   1. option 1
26.   2. option 2")
27.         (SETQ
28.           AREA   (VLAX-CURVE-GETAREA ENT)
29.           OPTION (GETINT "choose 1 -->2: ")
30.         )
31.         (COND
32.           ((= OPTION 1) (_OPTION1))
33.           ((= OPTION 2) (_OPTION2))
34.           (T (ALERT "Select > 2 --> Auto select 2. ") (_OPTION2))
35.         )
36.         (PRINC
37.           (STRCAT
38.             "\n Area = "
39.             (RTOS AREA 2 2)
40.             " sqm"
41.             "\n Anotation Area = "
42.             (RTOS ANOX 2 2)
43.             " sqm"
44.             "\n comments: "
45.             "\n comment1....... "
46.             "\n comment2....... "
47.             "com "
48.           )
49.         )
50.       )
51.       (PRINC "\nError selection of polyline ...")
52.     )
53.     (PRINC)
54.   )
55.   (PRINC)
56. )
57.  

thanks

[Kerry]

I'm certain if you apply yourself you can do this without too much trouble.

Regards,

[pedroantonio]

Kerry i can't find the error   

Code - Auto/Visual Lisp: [Select]

1. (DEFUN
2.    C:TEST (/ _OPTION1 _OPTION2 OLDARE AREA DXF ENT ANOX)
3.   (DEFUN _OPTION1 () (SETQ ANOX (* OLDARE 0.05)))
4.   (DEFUN _OPTION2 () (SETQ ANOX (* OLDARE 0.10)))
5.   ;; Main -----
6.   (IF (AND
7.         (SETQ ENT (CAR (ENTSEL "\nSelect a close polyline: ")))
8.         (SETQ OLDARE (GETREAL "\ngive old area : "))
9.         (WCMATCH
10.           (CDR (ASSOC 0 (SETQ DXF (ENTGET ENT))))
11.           "*POLYLINE"
12.         )
13.         (MEMBER (CDR (ASSOC 70 DXF)) '(1 129))
14.       )
15.     (PROGN
16.       (INITGET 7)
17.       (TEXTPAGE)
18.       (PROMPT
19.         "\n text1  :
20.  
21.   1. option 1
22.   2. option 2
23.        "
24.       )
25.       (SETQ
26.         AREA   (VLAX-CURVE-GETAREA ENT)
27.         OPTION (GETINT "choose 1 -->2: ")
28.       )
29.       (COND
30.         ((= OPTION 1) (_OPTION1))
31.         ((= OPTION 2) (_OPTION2))
32.         (T (ALERT "Select > 2 --> Auto select 2. ") (_OPTION2))
33.       )
34.       (PRINC
35.         (STRCAT
36.           "\n Area = "
37.           (RTOS AREA 2 2)
38.           " sqm"
39.           "\n Anotation Area = "
40.           (RTOS ANOX 2 2)
41.           " sqm"
42.           "\n comments: "
43.           "\n "
44.           (COND
45.             ((AND
46.                (>= AREA (- OLDARE ANOX))
47.                (<= AREA (+ OLDARE ANOX))
48.                (PRINC "\n comment1")
49.                ((AND
50.                   (> AREA (+ OLDARE ANOX))
51.                   (< AREA (- OLDARE ANOX))
52.                   (PRINC "\n comment2")
53.                 )
54.                )
55.              )
56.              (PRINC "\nError selection of polyline ...")
57.             )
58.             (PRINC)
59.           )
60.           (PRINC)
61.         )
62.       )
63.     )
64.   )
65. )
66.  ;|«Visual LISP© Format Options»
67. (72 2 40 2 nil "end of " 60 2 2 2 1 nil nil nil T)
68. ;*** DO NOT add text below the comment! ***|;
69.  
70.  

[snownut2]

Take a look at you parenthesis around the "and" functions, and it appears you have variables (ie; comment1 & comment2) being used as text in the princ line.  Look at using the strcat function

example;

Code: [Select]

(and
    (foo1)
    (foo2)
)

You've seen enough examples here from others that you can figure this out.  (time to cowboy up)

[Kerry]

Additionally ;

Your conditional statement is unbalanced.

Study this
Each branch consists of a self contained Test and a statement set  to execute if the test is true.

Code - Auto/Visual Lisp: [Select]

1. (cond ((and (true-or-false-test-01)
2.             (true-or-false-test-02)
3.        )
4.        (setq xxx 0102)
5.       )
6.       ((and (true-or-false-test-03)
7.             (true-or-false-test-04)
8.        )
9.        (setq xxx 0304)
10.       )
11.       ((and (true-or-false-test-01)
12.             (true-or-false-test-03)
13.        )
14.        (setq xxx 0103)
15.       )
16.       ((and (true-or-false-test-02)
17.             (true-or-false-test-03)
18.        )
19.        (setq xxx 0203)
20.       )
21. )
22.  

[pedroantonio]

Kerry i can not understand it. Can you help me.

Thanks

[Kerry]

Untested

Code - Auto/Visual Lisp: [Select]

1.  
2. (defun
3.    C:TEST (/ _OPTION1 _OPTION2 OLDARE AREA DXF ENT ANOX)
4.   (defun _OPTION1 () (setq ANOX (* OLDARE 0.05)))
5.   (defun _OPTION2 () (setq ANOX (* OLDARE 0.10)))
6.   ;; Main -----
7.   (if (and
8.         (setq
9.           ENT
10.            (car (entsel "\nSelect a close polyline: "))
11.         )
12.         (setq OLDARE (getreal "\ngive old area : "))
13.         (wcmatch
14.           (cdr (assoc 0 (setq DXF (entget ENT))))
15.           "*POLYLINE"
16.         )
17.         (member (cdr (assoc 70 DXF)) '(1 129))
18.       )
19.     (progn
20.       (initget 7)
21.       (textpage)
22.       (prompt
23.         "\n text1  :
24.  
25.   1. option 1
26.   2. option 2
27.        "
28.       )
29.       (setq
30.         AREA   (vlax-curve-getarea ENT)
31.         OPTION (getint "choose 1 -->2: ")
32.       )
33.       (cond
34.         ((= OPTION 1) (_OPTION1))
35.         ((= OPTION 2) (_OPTION2))
36.         (t
37.          (alert "Select > 2 --> Auto select 2. ")
38.          (_OPTION2)
39.         )
40.       )
41.       (princ
42.         (strcat
43.           "\n Area = "
44.           (rtos AREA 2 2)
45.           " sqm"
46.           "\n Anotation Area = "
47.           (rtos ANOX 2 2)
48.           " sqm"
49.           "\n comments: "
50.           "\n "
51.           (cond
52.             ((and
53.                (>= AREA (- OLDARE ANOX))
54.                (<= AREA (+ OLDARE ANOX))
55.              )
56.              (princ "\n comment1")
57.             )
58.             ((and
59.                (> AREA (+ OLDARE ANOX))
60.                (< AREA (- OLDARE ANOX))
61.              )
62.              (princ "\n comment2")
63.             )
64.           )
65.         )
66.       )
67.     )
68.     (princ "\nError selection of polyline ...")
69.   )
70.   (princ)
71. )
72.  
73.  
74.  
75.  
76.  

[pedroantonio]

Thank you Kerry

[pedroantonio]

Kerry I have problem with print comment 2
I change litle bit the code . But i still have print problem .Can you check it.

Code - Auto/Visual Lisp: [Select]

1. (DEFUN
2.    C:TEST (/ _OPTION1 _OPTION2 OLDARE AREA DXF ENT ANOX T1 T2)
3.   (DEFUN _OPTION1 () (SETQ ANOX (* OLDARE 0.05)))
4.   (DEFUN _OPTION2 () (SETQ ANOX (* OLDARE 0.10)))
5.   ;; Main -----
6.   (IF (AND
7.         (SETQ ENT (CAR (ENTSEL "\nSelect a close polyline: ")))
8.         (SETQ OLDARE (GETREAL "\ngive old area : "))
9.         (WCMATCH
10.           (CDR (ASSOC 0 (SETQ DXF (ENTGET ENT))))
11.           "*POLYLINE"
12.         )
13.         (MEMBER (CDR (ASSOC 70 DXF)) '(1 129))
14.       )
15.     (PROGN
16.       (INITGET 7)
17.       (TEXTPAGE)
18.       (PROMPT
19.         "\n text1  :
20.  
21.   1. option 1
22.   2. option 2
23.        "
24.       )
25.       (SETQ
26.         AREA   (VLAX-CURVE-GETAREA ENT)
27.         OPTION (GETINT "choose 1 -->2: ")
28.       )
29.       (COND
30.         ((= OPTION 1) (_OPTION1))
31.         ((= OPTION 2) (_OPTION2))
32.         (T (ALERT "Select > 2 --> Auto select 2. ") (_OPTION2))
33.       )
34.       (SETQ T1 (- OLDARE ANOX))
35.       (SETQ T2 (+ OLDARE ANOX))
36.       (PRINC
37.         (STRCAT
38.           "\n Area = "
39.           (RTOS AREA 2 2)
40.           " sqm"
41.           "\n Anotation Area = ± "
42.           (RTOS ANOX 2 2)
43.           " sqm"
44.           "\n "
45.           "\n comments: "
46.           "\n "
47.           (COND
48.             ((AND (>= AREA T1) (<= AREA T2))
49.              (PRINC
50.                "\n "
51.                (RTOS T1 2 2)
52.                " sqm <="
53.                (RTOS AREA 2 2)
54.                " <= "
55.                (RTOS T2 2 2)
56.                " sqm"
57.                "\n comment1"
58.              )
59.             )
60.             ((AND (> AREA T2) (< AREA T1))
61.              (PRINC
62.                (PRINC
63.                  "\n "
64.                  (RTOS T1 2 2)
65.                  " sqm > "
66.                  (RTOS AREA 2 2)
67.                  " > "
68.                  (RTOS T2 2 2)
69.                  "sqm"
70.                  "\n comment2"
71.                )
72.              )
73.             )
74.           )
75.         )
76.       )
77.       (PRINC "\nError selection of polyline ...")
78.     )
79.     (PRINC)
80.   )
81.   ;|«Visual LISP© Format Options»
82. (72 2 40 2 nil "end of " 60 2 2 2 1 nil nil nil T)
83. ;*** DO NOT add text below the comment! ***|;
84. )
85.  

Thank you

[Kerry]

Explain EXACTLY what is wrong.
What are your pre-condition values ?
What do you expect What ?
and what you get what ?

For the cause of the problem, look first at the things you changed.

Added:
Looking at your code, you need to fix the last several lines of code.
Compare my post with yours.
I'll look at your comment code when you respond satisfactorily to my information request.

[pedroantonio]

Sorry Kerry.I will explain you now..

I want
a) when  T1< = Area <= T2 to print T1< = Area <= T2 and comment 1
b) when  T1>Area >T2 to print T1> Area > T2 and comment 2

Your code works only for comment 1 , for comment 2 gives error. I add in the code ths lines

Code - Auto/Visual Lisp: [Select]

1.  
2.  
3. (SETQ T1 (- OLDARE ANOX))
4. (SETQ T2 (+ OLDARE ANOX))
5. --------------------
6. -----------------
7.  
8. COND
9.             ((AND (>= AREA T1) (<= AREA T2))
10.              (PRINC
11.                "\n "
12.                (RTOS T1 2 2)
13.                " sqm <="
14.                (RTOS AREA 2 2)
15.                " <= "
16.                (RTOS T2 2 2)
17.                " sqm"
18.                "\n comment1"
19.              )
20.             )
21.             ((AND (> AREA T2) (< AREA T1))
22.              (PRINC
23.                (PRINC
24.                  "\n "
25.                  (RTOS T1 2 2)
26.                  " sqm > "
27.                  (RTOS AREA 2 2)
28.                  " > "
29.                  (RTOS T2 2 2)
30.                  "sqm"
31.                  "\n comment2"
32.                )
33.  

but i still have problem with the results . I test the code in autocad vlisp editor  but i can not find were the problem is. if you can help.

Thanks

[Kerry]

You're going to have to learn to listen bud !
I didn't ask for freaking code, I asked for data.

Give me values for comment 1
Area :
OLDARE :
ANOX :

Give me values for comment 2
Area :
OLDARE :
ANOX :

... as many combinations as you like.

Without knowing the data and the expected results I may as well just walk away.


added:
and please confirm the rules because this isn't what you've coded.

I want
a) when  T1<= Area <= T2     to print T1<= Area <= T2 and comment 1
b) when  T1 >  Area     >T2    to print    T1> Area >T2 and comment 2

[pedroantonio]

Karry here is the example


for option 1 (comment 1)
OLD AREA 8000sqm
Area 8062sqm
Anox 8000 * 0.05 = 400 sqm
T1 =  8000 - 400 = 7600 sqm
T2 =  8000 + 400 = 8400 sqm

7600< 8062 <8400  so
comment 1

for option 1 (comment 2)

OLD AREA 8000sqm
Area 9500sqm
Anox 8000 * 0.05 = 400 sqm
T1 =  8000 - 400 = 7600 sqm
T2 =  8000 + 400 = 8400 sqm

7600>9500 >8400  so
comment 2
 -----------------------------------------------

for option 2 (comment 1)
OLD AREA 8000sqm
Area 7500sqm
Anox 8000 * 0.10 = 800 sqm
T1 =  8000 - 800 = 7200 sqm
T2 =  8000 + 800 = 8800 sqm

7200< 7500 <8800  so
comment 1

for option 2 (comment 2)

OLD AREA 8000sqm
Area 7100sqm
Anox 8000 * 0.10 = 800 sqm
T1 =  8000 - 800 = 7200 sqm
T2 =  8000 + 800 = 8800 sqm 

Here we have a change in the code

7200>7100  so
comment 2

if we have

for option 2 (comment 2)

OLD AREA 8000sqm
Area 8950sqm
Anox 8000 * 0.10 = 800 sqm
T1 =  8000 - 800 = 7200 sqm
T2 =  8000 + 800 = 8800 sqm 

Here we have a change in the code

8950 > 8800  so
comment 2

The comment 2 i thing need 3 options
T1>Area>T2
T1>Area
T2< Area

[Kerry]

for option 1 (comment 2)

OLD AREA 8000sqm
Area 9500sqm
Anox 8000 * 0.05 = 400 sqm
T1 =  8000 - 400 = 7600 sqm
T2 =  8000 + 400 = 8400 sqm

7600>9500 >8400  so
comment 2
 -----------------------------------------------

7600>9500 >8400 This is crap.