Topic: Using delete ...

[efernal]

I'm new with c++...
Should I use "delete" for "saida"?
It's not working if I put delete saida; after fclose()...

Code: [Select]

void EFernal_ReadFile (char *nome)
{
FILE *fp = NULL;

if (fopen_s(&fp, nome, "r") != 0)
{
sds_alert(L"Erro:\n\n\n\tNão foi possível abrir o arquivo para leitura...");
sds_retvoid();
return;
}

char linha[255] = "";
wchar_t *saida = new wchar_t[255];

while(!feof(fp))
{
fgets(linha, 254, fp);
if((strlen(linha) > 5) && (linha[0] != ';'))
{
   saida = CA2W(linha);
sds_alert(saida);
}
}

fclose(fp);

Arquivo_Chm = CA2W("D:\\PlanetaCad_Loel\\PlanetaCAD_Loel.chm");
Help();

sds_retvoid();
}


[It's Alive!]

yes in this case you would use delete[] .
You also have the possibility of a dangling pointer, the way you have saida being assigned inside of a loop

[efernal]

ok, thanks...
I was using only delete, not delete[]...

[It's Alive!]

this line is an error

Code: [Select]

saida = CA2W(linha);


[efernal]

it´s working...
how would be the correct way?

Code: [Select]

saida = CA2W(linha);


[It's Alive!]

its pointers 101. if you assign a pointer a new value how can you call delete on it?
Example:

Code: [Select]

wchar_t *saida = new wchar_t[255];now the address of saida is pointing to a location in memory .. say 0x123456. now you call:

Code: [Select]

saida = CA2W(linha);which assigns a new address to saida, so saida might now be pointing to 0x123659.
now you want to call delete to free the memory you created at 0x123456,
but wait.... you can't because siada now points to 0x123659.

so now you have a "memory leak"   

[efernal]

This is a test, just for learning...
I changed it to:

Code: [Select]

void EFernal_ReadFile (char *nome)
{
FILE *fp = NULL;

if (fopen_s(&fp, nome, "r") != 0)
{
sds_alert(L"Erro:\n\n\n\tNão foi possível abrir o arquivo para leitura...");
sds_retvoid();
return;
}

char linha[255] = "";

while(!feof(fp))
{
fgets(linha, 254, fp);
if((strlen(linha) > 5) && (linha[0] != ';'))
{
sds_alert(CA2W(linha));
}
}

fclose(fp);

sds_retvoid();
}

it's working...
is this correct?

thanks for your help...

[It's Alive!]

better 

[pkohut]

Code: [Select]

while(!feof(fp))
{
fgets(linha, 254, fp);
if((strlen(linha) > 5) && (linha[0] != ';'))
{
sds_alert(CA2W(linha));
}
}

it's working...
is this correct?

thanks for your help...

The while statement is bad form, leaving the possibility of an infinite loop if the error flag is raised on fp. Better to check if fgets returns NULL, then later check if the error flag is raised in fp.

Code: [Select]

while(fgets(linha, 255, fp)) {
// do your work here
}

if(ferror(fp)) {
// report error message.
}
Also, use the same buffer allocation size for linha and fgets. And since you posted this in the ARX group I'll assume you are using C++. So get in the habit of using namespaces and drop the EFernal_ prefix.

[efernal]

Thank you, pkohut
I will study this way...