Author Topic: Error handling etiquette with Acad  (Read 2216 times)

0 Members and 1 Guest are viewing this topic.

MickD

  • Gator
  • Posts: 3471
  • (x-in)->[process]->(y-out)
Error handling etiquette with Acad
« on: December 10, 2007, 06:16:05 PM »
Hi All,
I'm now at a stage where I seriously need to factor in error handling into my new app and I have a couple of questions.

1) apart from the usual 'esc' and cancel and file op handlers, what other important acad errors should I consider?
2) should I be putting error handlers in all of my private or 'worker' sub's or can I put one in the procedure called by the user,
obviously there would be some examples where it would be prudent to place them in private subs such as opening files etc.?
3) any other hints or tips before I jump in?

Thanks.
Forth is like the Tao: it is a Way, and is realized when followed.
Its fragility is its strength; its simplicity is its direction - Michael Ham

Lao Tzu: “To attain knowledge, add things
every day; to obtain wisdom, remove things every day.”

MP

  • Seagull
  • Posts: 17750
  • Have thousands of dwgs to process? Contact me.
Re: Error handling etiquette with Acad
« Reply #1 on: December 10, 2007, 06:25:17 PM »
In my experience the most frequent error you'll encounter is the dreaded KETBD, an especially troublesome form of the PEBKAC error.

Hint: Throw low, catch high.
Engineering Technologist • CAD Automation Practitioner
Automation ▸ Design ▸ Drafting ▸ Document Control ▸ Client
cadanalyst@gmail.com • http://cadanalyst.slack.com • http://linkedin.com/in/cadanalyst

MickD

  • Gator
  • Posts: 3471
  • (x-in)->[process]->(y-out)
Re: Error handling etiquette with Acad
« Reply #2 on: December 10, 2007, 06:40:15 PM »
In my experience the most frequent error you'll encounter is the dreaded KETBD, an especially troublesome form of the PEBKAC error.

Hint: Throw low, catch high.

Roger that ;)
Forth is like the Tao: it is a Way, and is realized when followed.
Its fragility is its strength; its simplicity is its direction - Michael Ham

Lao Tzu: “To attain knowledge, add things
every day; to obtain wisdom, remove things every day.”

Bryco

  • Water Moccasin
  • Posts: 1853
Re: Error handling etiquette with Acad
« Reply #3 on: December 10, 2007, 06:58:43 PM »
I have a beauty that Randall wrote.
1) Post the code in a new module  (I call mine ErrorControl)
2) Add a reference to MICROSOFT visual Basic for Applications Extensibility 5.3
3) Whenever you want error control in a sub or function just make the sub active then goto to tools (the same tools pull down as holds References) -> Macros modulename.AutoErrorHandler
"Run" this and the error handler will be automajically written.

Code: [Select]
Option Explicit


Dim objIDE As VBE
Dim objPane As CodePane
Dim objMod As CodeModule


   

'Randall Rath


Public Sub AutoErrorHandler()
  Dim strProc As String
  Dim lngFirst As Long
  Dim lngTotal As Long
  Dim lngLast As Long
  On Error GoTo Err_Control
  Set objIDE = Application.VBE
  Set objPane = objIDE.ActiveCodePane
  Set objMod = objPane.CodeModule
  strProc = GetCurrentProc
  lngFirst = objMod.ProcBodyLine(strProc, _
  vbext_pk_Proc)
  lngTotal = objMod.ProcCountLines(strProc, _
  vbext_pk_Proc)
  lngLast = lngFirst + lngTotal
  Call InsertGoto(lngLast, lngFirst)
  Call InsertHandler(lngLast, lngFirst)
  Set objIDE = Nothing
  Set objPane = Nothing
  Set objMod = Nothing
Exit_Here:
  Exit Sub
Err_Control:
  Select Case Err.Number
    Case Else
    MsgBox Err.Description
    Resume Exit_Here
  End Select
End Sub

Private Function GetCurrentProc() As String
  Dim lngSC As Long 'Start column
  Dim lngEC As Long 'End Column
  Dim lngSL As Long 'Start Line
  Dim lngEL As Long 'End Line
  On Error GoTo Err_Control
  objPane.GetSelection lngSL, lngSC, _
  lngEL, lngEC
  'Debug.Print lngSL, lngEL
  GetCurrentProc = objMod.ProcOfLine(lngSL, _
  vbext_pk_Proc)
Exit_Here:
  Exit Function
Err_Control:
  Select Case Err.Number
  'Add your Case selections here
    Case Else
    MsgBox Err.Description
    Resume Exit_Here
  End Select
End Function

Private Sub InsertGoto(LastLine As Long, _
FirstLine As Long)
  Dim lngCnt As Long
  Dim strLine As String
  On Error GoTo Err_Control
  FirstLine = FirstLine + 1
  For lngCnt = FirstLine To LastLine
    If Not Right(objMod.Lines(lngCnt - 1, 1), _
    1) = "_" Then
      strLine = objMod.Lines(lngCnt, 1)
      If InStr(1, strLine, "Dim", _
      vbTextCompare) = 0 Then
        objMod.InsertLines lngCnt, _
        vbTab & "On Error GoTo Err_Control"
        Exit For
      End If
    End If
  Next lngCnt
Exit_Here:
  Exit Sub
Err_Control:
  Select Case Err.Number
  'Add your Case selections here
    Case Else
    MsgBox Err.Description
    Resume Exit_Here
  End Select
End Sub

Private Sub InsertHandler(LastLine As Long, FirstLine As Long)
  Dim lngCnt As Long
  Dim strLine As String
  On Error GoTo Err_Control
  For lngCnt = LastLine To FirstLine Step -1
    strLine = objMod.Lines(lngCnt, 1)
    Select Case strLine
    Case "End Sub"
      objMod.InsertLines lngCnt, "Exit_Here:"
      objMod.InsertLines lngCnt + 1, vbTab & _
      "Exit Sub"
      objMod.InsertLines lngCnt + 2, _
      "Err_Control:"
      objMod.InsertLines lngCnt + 3, vbTab & _
      "Select Case Err.Number"
      objMod.InsertLines lngCnt + 4, vbTab & _
      "'Add your Case selections here"
      objMod.InsertLines lngCnt + 5, vbTab & _
      vbTab & "Case Else"
      objMod.InsertLines lngCnt + 6, vbTab & _
      vbTab & "MsgBox Err.Description"
      objMod.InsertLines lngCnt + 7, vbTab & _
      vbTab & "Err.Clear"
      objMod.InsertLines lngCnt + 8, vbTab & _
      vbTab & "Resume Exit_Here"
      objMod.InsertLines lngCnt + 9, vbTab & _
      "End Select"
      Exit For
    Case "End Function"
      objMod.InsertLines lngCnt, "Exit_Here:"
      objMod.InsertLines lngCnt + 1, vbTab & _
      "Exit Function"
      objMod.InsertLines lngCnt + 2, _
      "Err_Control:"
      objMod.InsertLines lngCnt + 3, vbTab & _
      "Select Case Err.Number"
      objMod.InsertLines lngCnt + 4, vbTab & _
      "'Add your Case selections here"
      objMod.InsertLines lngCnt + 5, vbTab & _
      vbTab & "Case Else"
      objMod.InsertLines lngCnt + 6, vbTab & _
      vbTab & "MsgBox Err.Description"
      objMod.InsertLines lngCnt + 7, vbTab & _
      vbTab & "Err.Clear"
      objMod.InsertLines lngCnt + 8, vbTab & _
      vbTab & "Resume Exit_Here"
      objMod.InsertLines lngCnt + 9, vbTab & _
      "End Select"
      Exit For
    End Select
  Next lngCnt
Exit_Here:
  Exit Sub
Err_Control:
  Select Case Err.Number
    Case Else
    MsgBox Err.Description
    Debug.Print Err.Number & Space(2) & Err.Description
    Resume Exit_Here
  End Select
 

End Sub

Here is an example

Code: [Select]
Sub Test()
    On Error GoTo Err_Control



Exit_Here:
    Exit Sub
Err_Control:
    Select Case Err.Number
    'Add your Case selections here
        Case Else
        MsgBox Err.Description
        Err.Clear
        Resume Exit_Here
    End Select
End Sub

MickD

  • Gator
  • Posts: 3471
  • (x-in)->[process]->(y-out)
Re: Error handling etiquette with Acad
« Reply #4 on: December 10, 2007, 07:22:23 PM »
Nice! I remember something about this but I was very green back then, I also thought there was some way of writing a 'universal' error function - maybe this was it??

thanks Bryco
Forth is like the Tao: it is a Way, and is realized when followed.
Its fragility is its strength; its simplicity is its direction - Michael Ham

Lao Tzu: “To attain knowledge, add things
every day; to obtain wisdom, remove things every day.”

Bryco

  • Water Moccasin
  • Posts: 1853
Re: Error handling etiquette with Acad
« Reply #5 on: December 10, 2007, 09:41:22 PM »
Yes it is pretty universal

    Select Case Err.Number
        Case "-2145320928 ", "13" ' Type mismatch
           Resume Exit_Here
        Case -2147024809   'Invalid argument Point in TranslateCoordinates
            Resume Exit_Here



There are some times when a goto works from the error handler.
Although this was not designed with that in mind.
Basically its easy to use and implement.

JohnF

  • Newt
  • Posts: 48
Re: Error handling etiquette with Acad
« Reply #6 on: December 11, 2007, 12:24:32 AM »
What ever happened to Randall?

Dnereb

  • Guest
Re: Error handling etiquette with Acad
« Reply #7 on: December 11, 2007, 02:36:15 AM »
I supose Randall went offline or incognito, I couldn't find him anywhere a year after shutdownday.
another way to get nice errorhandling is to install M-Z tools for VBA (freeware without adds) you just have to click a button to add an error handler.
it can write the fram for properties and other nice stuff as well.

CmdrDuh

  • Automatic Duh Generator
  • King Gator
  • Posts: 4039
Re: Error handling etiquette with Acad
« Reply #8 on: December 11, 2007, 08:24:22 AM »
Very cool.  Add that to my list of useful things to hold onto.
Everyone has a photographic memory, Some just don't have film.
They say money can't buy happiness, but it can buy Bacon and that's a close second