Topic: Help but please no code.

[daron]

What CAB's done with the value of wid and len is what I meant by separating out the values.

[CAB]

Here is a visual example.

[DEVITG]

Could be "MINSERT"  a good way to draw the blocks on?

As defined length fractions distance as

ABBBBBA

The width could be

CDDDDDC

So the insert point should be the A and C distance  from origin

The row number =  by the previous user imput
The column number = by the same way

The row space A

The column space D

Even the angle could match the angle of the room .

[Keith™]

I don't know if minsert would be a good option since it inserts in a complete grid...

[hudster]

I've been working on this in my very limited free time and I've come up with this

Code: [Select]

;;;
;;;Lighting array lisp routine
;;;Created by Andy Hudson
;;;March 2004
;;;
(defun c:ltg (/ X1 Y1 FX FY P1 PX PY block PXA PYA) ;set as local variables
  (setq X1 (getdist "\nInput length of room along X Axis: ")) ;get length
 (setq Y1 (getdist "\nInput width of room along Y Axis: ")) ;Get width
  (setq FX (getint "\nInput No of fittings along X Axis: "))
  (setq FY (getint "\nInput No of Fittings along Y Axis: "))
  (setq P1 (getpoint "\nSelect the lower left hand corner: ")) (terpri) ;set the 0,0 point
  (command "UCS" "O" P1)
  (setq P1 (LIST 0 0))
  ;;;
  (setq PX (/ X1 FX)) ;;length divide by fittings
  (setq PXA (/ (/ X1 FX) 2.0)) ;;divided by 2
   (setq PY (/ Y1 FY)) ;;width divided by fittings
  (setq PYA (/ (/ Y1 FY) 2.0)) ;;divided by 2
  ;;;
  (setq block (getstring "Enter block name you wish to insert: ")) ;;get block
;;;
  (command "-insert" block (list PYA PXA) "1" "" "0") ;;insert block
;;;
  (COMMAND "-ARRAY" "LAST" "" "RECTANGULAR" FY FX PY PX)
  (COMMAND "UCS" "P")
  (COMMAND "UCS" "P")
 (princ) ;;clean exit
  )


it's almost there but it doesn't quite work right and I can't figure out why.

this is an image of how I want it to lay out the fittings but it's always off a wee bit.



Any Ideas?

[SMadsen]

Andy, I haven't tried your routine but could running osnaps cause the UCS to snap to another point than P1? Just a thought.

[hudster]

I've tried it with snaps off, but it's still out.

not by much only 50mm, but enough to annoy me.

[hudster]

it was the snaps, I changed the osmode to 103 and it worked.

But it threw up another problem.  the routing only works in square grids, i.e 2X2 , 3X3, 4X4 etc.

if you try 2X4 it doesn't work.

Someone in my work suggested it may be to do with integers and real numbers.  but I don't know, I'm new to lisp and every function is a discovery to me.

[SMadsen]

Nope, GETDIST returns reals so that part is fine. Just noticed that you've switched x and y in the INSERT command though:

(command "-insert" block (list PYA PXA) "1" "" "0")

should be

(command "-insert" block (list PXA PYA) "1" "" "0")

[SMadsen]

Try this minor alteration. Instead of messing with UCS, it merely offsets the point with the lower left point in P1.
Also, undo is added and osnaps are turned off temporarily.

Code: [Select]

(defun c:ltg (/ X1 Y1 FX FY P1 PX PY block PXA PYA osm)
  ;set as local variables
  (setq X1 (getdist "\nInput length of room along X Axis: ")) ;get length
  (setq Y1 (getdist "\nInput width of room along Y Axis: "))  ;Get width
  (setq FX (getint "\nInput No of fittings along X Axis: "))
  (setq FY (getint "\nInput No of Fittings along Y Axis: "))
  (setq P1 (getpoint "\nSelect the lower left hand corner: "))
;;;
  (setq PX (/ X1 FX))
  ;;length divide by fittings
  (setq PXA (+ (car P1) (/ PX 2.0)))
  ;;divided by 2
  ;; - plus X coord of P1
  (setq PY (/ Y1 FY))
  ;;width divided by fittings
  (setq PYA (+ (cadr P1) (/ PY 2.0)))
  ;;divided by 2
  ;; - plus Y coord of P1
;;;
  (setq block (getstring "Enter block name you wish to insert: ")) ;get block
;;;
  ;; - If block exists then go ahead
  (cond ((tblsearch "BLOCK" block)
         ;; - Done with user input -> set OSMODE to zero
         (setq osm (getvar "OSMODE"))
         (setvar "OSMODE" 0)
         ;; - Let user be able to undo
         (command "UNDO" "Begin")
         (command "-insert" block (list PXA PYA) "1" "" "0")
         ;;insert block
;;;
         (COMMAND "-ARRAY" "LAST" "" "RECTANGULAR" FY FX PY PX)
         (command "UNDO" "End")
         (setvar "OSMODE" osm)
        )
  )
  (princ)
  ;;clean exit
)

[hudster]

That works a lot better than my version.

CAR and CADR are both new functions to me,  like I said, it's all new to me.

Now for stage two, working out how to insert arrays into rooms at a slant.
I'm looking at both the getangle and getorient functions to do this, am I on the right track?

[SMadsen]

Yes, that would be the right track if it should ask for an angle. But it could still be asking for a distance (either with GETDIST as it is now, or with GETPOINT's) and then use ANGLE to calculate the angle.

[hudster]

there is a problem with this lisp, it does work, until you try to put a row of fittings when there is only 1 row on the Y axis.  then it seems to fall down.

no matter how hard I look i can't see where it goes wrong.

Any ideas?

 

[CAB]

This was without the angle.

Code removed

[CAB]

Here is some help with the angle.

Code: [Select]

(defun c:ltg (/ x1 y1 fx fy p1 px py block pxa pya osm newbies elast e ang eblk)
  (setq x1 (getdist "\nInput width of room along X Axis: "))
  (setq y1 (getdist "\nInput length of room along Y Axis: "))
  (setq fx (getint "\nInput No of fittings along X Axis: "))
  (setq fy (getint "\nInput No of Fittings along Y Axis: "))
  (setq p1 (getpoint "\nSelect the lower left hand corner: "))
  (setq ang (getangle p1 "\nSelect angle of room width (x-axis): <0>"))
  (if (null ang)
    (setq ang 0)
    (setq ang (* 180.0 (/ ang pi))) ; Radians to Degrees
  )

  (if (or (null fx) (< fx 2))
    (setq fx  1
          px  (/ x1 2)
          pxa (+ (car p1) px)
    )
    (setq px  (/ x1 fx) ;width divided by fittings
          pxa (+ (car p1) (/ px 2.0)) ;divided by 2 plus X coord of P1
    )
  )
  (if (or (null fy) (< fy 2))
    (setq fy  1
          py  (/ y1 2)
          pya (+ (cadr p1) py)
    )
    (setq py  (/ y1 fy) ;length divide by fittings
          pya (+ (cadr p1) (/ py 2.0)) ;divided by 2 plus Y coord of P1
    )
  )


  ;; get block name , default name if enter only
  (setq block
         (getstring "\nEnter block name you wish to insert: <RC-Light> ")
  )
  (if (or (= block "") (null block)) ; use default name
    (setq block "RC-Light")
  )

  ;; - If block exists then go ahead
  (cond ((tblsearch "BLOCK" block)
         (setq osm (getvar "OSMODE"))
         (command "UNDO" "Begin")
         (setvar "OSMODE" 0)
         (setq elast (@cv_entlast))
         (setq newbies (ssadd)) ;empty selection set
         (command "-insert" block (list pxa pya) "1" "" 0)
         (setq eblk (@cv_entlast))
         (ssadd  eblk newbies)
         (command "ARRAY" eblk "" "RECTANGULAR" fy fx)
         (if (> fy 1)
           (command py)
         )
         (if (> fx 1)
           (command px)
         )
         (if (/= ang 0)
           (progn
             (setq e (if elast
                       (entnext elast)
                       (entnext)
                     )
             )
             (while e
               (ssadd e newbies)
               (setq e (entnext e))
             )

             (command ".rotate" newbies "" p1 ang)
           )
         )
         (command "UNDO" "End")
         (setvar "OSMODE" osm)
        )
        ;;  ELSE =====================================
        ((prompt (strcat "\n" block " Block not found."))
        )
  )
  (princ) ; clean exit
)


;;------------------------------------------------------------
;; Function to get the absolutely last entity in the database:
;;
(defun @cv_entlast (/ e elast)
  (setq elast (entlast))
  (while (setq e (entnext elast))
    (setq elast e)
  )
  elast
)