Topic: retrieving attribute values

[Andrea]

Please note I am not picking on you personally.
There are certain logic rules to follow when writing computer programs, you've just missed a few here.

Kerry, comment like your's give me nitro to improve my programs...thanks. 

also, from your comment I have modified the routine, could you comment this one ?
just to be sure...?

Code: [Select]

(defun c:getbat (/ edata attdata eb1 eb2)
(setq bname (getstring "Enter your block name : "))
  (if (ssget "X" (list (cons 0 "INSERT") (cons 2 bname))) (getdata)
    (alert (strcat "No block named " bname " was detected on this drawing."))
  );;if
)
(defun getdata () 
(setq edata (entget (ssname (ssget "X" (list (cons 0 "INSERT") (cons 2 bname))) 0)))
 (setq attdata (entget (entnext (dxf -1 edata))))
 (if (= (cdr (assoc 0 attdata)) "ATTRIB")
  (progn
    (setq x T)
    (setq edata (entget (entnext (dxf -1 edata))))
  (while x
(setq eb1 (dxf 1 edata));; = Attribute Value
        (setq eb2 (dxf 2 edata));; = Attribute TAG
        (alert (strcat "Tag = " eb2 "\nValue = " eb1))
        (setq edata (entget (entnext (dxf -1 edata))))
        (if (eq (dxf 0 edata) "SEQEND") (setq x nil))
    );;while
   );;progn
(alert "This block is present but miss attribute.")
  );;if
(setq bname nil)
  (princ)
)
(defun dxf (code elist)
(cdr (assoc code elist))
);defun

[Kerry]

sure, one item at a time ..

Do you know what the DXF 66 does ?
(setq ss (ssget "_X" '((0 . "INSERT") (66 . 1) (cons (2  blockNameToFind)))))

Think about passing the getdata function the  blockNameToFind

Think about returning the required info to the calling routine ;
ie : (setq val (getdata blockNameToFind) )

Think about localising your variables.

Think about testing the length of the selectionSet and advising the user that there is more than ONE block in the drawing.
 

[Andrea]

sure, one item at a time ..

Do you know what the DXF 66 does ?
(setq ss (ssget "_X" '((0 . "INSERT") (66 . 1) (cons (2  blockNameToFind)))))

Think about passing the getdata function the  blockNameToFind

Think about returning the required info to the calling routine ;
ie : (setq val (getdata blockNameToFind) )

Think about localising your variables.

Think about testing the length of the selectionSet and advising the user that there is more than ONE block in the drawing.
 

Thanks Kerry..
I'll think a little bit more.. 

[Kerry]

How did you go ? ?