Topic: Lsp2Arx ang_dec function

[LE]

I am working translating some of my lisp function into arx, here is ang_dec function, that's calculate the delta, have a look and would like to hear if that's how you would write the function/translation or if it is a better way.... I like to know!.

Hope that makes some sense.

[LE]

Something is not right with the code... I'll post it back again....

[Chuck Gabriel]

I would change the return type to Acad::ErrorStatus and have the function return a value indicating success or failure.

[LE]

I would change the return type to Acad::ErrorStatus and have the function return a value indicating success or failure.

I think I got this running Chuck, thank you.... I end up using the calls inside of one of my methods instead of as a general function.... for now.

Also, I am noticed, that the call of acedGetEnv does not work this:

Code: [Select]

char* var;
if (acedGetEnv("ArcDrawAngleInput",var) != RTNORM) {
acedSetEnv("ArcDrawAngleInput","1");
}

I end up using this:

Code: [Select]

const char* var;
var = acdbHostApplicationServices()->getEnv("ArcDrawAngleInput");
std::string strVar(var);

acutPrintf("ArcDrawAngleInput %s\n", strVar.c_str());

if (atoi(strVar.c_str())==1) {

My question will be, why ?.... I supposed was making the calls right... or was late last night no coffee or age?....

int
acedGetEnv(
const char * sym,
char * var);

sym Input environment variable name to get, which is case sensitive in all environments (Visual LISP, ObjectARX, and VB/ActiveX)
var Output preallocated buffer to be filled in with environment variable value (a buffer size of 1024 bytes should be sufficient)

Thanks.

[Chuck Gabriel]

According to the blurb you quoted from the help, you need to initialize your char* var to point to a valid buffer.

You could have done either:

// buffer on the stack
char var[1024];

or

// buffer on the heap
char* var = new char[1024];
// do your stuff
delete[] var;

[LE]

Here is the latest about the function ang_dec in lsp and arx

Code: [Select]

(defun ang_dec (/ grad mnt seg uniang)
  (if (not (getenv "ArcDrawAngleInput"))
    (setenv "ArcDrawAngleInput" "1"))
  (setq uniang (atoi (getenv "ArcDrawAngleInput")))
  (if (null uniang)
    (setq uniang 1))
  (if (= uniang 1)
    (progn (setq grad (getreal "\nDegrees: ")
mnt  (getreal "\nMinutes: ")
seg  (getreal "\nSeconds: " ))
   (+ grad (/ mnt 60.0) (/ seg 3600.0)))
    (setq grad (* (/ (getreal "\nDecimal degrees: ") 400) 360))))


Code: [Select]

static ads_real ang_dec()
{
ads_real delta;
char var[1024];
if (acedGetEnv("ArcDrawAngleInput",var) != RTNORM) {
acedSetEnv("ArcDrawAngleInput","1");
acedGetEnv("ArcDrawAngleInput",var);
}
switch (atoi(var)) {
case 1:
acutPrintf("\nAngle input format: DMS [sexagesimal]\n");
ads_real grad,mnt,seg;
acedInitGet(RSG_NONEG,"");
if (acedGetReal("\nDegrees: ",&grad)==RTNORM) {
acedInitGet(RSG_NONEG,"");
if (acedGetReal("\nMinutes: ",&mnt)==RTNORM) {
acedInitGet(RSG_NONEG,"");
if (acedGetReal("\nSeconds: ",&seg)==RTNORM) {
delta=grad+mnt/60.0+seg/3600.0;
return delta;
}//if seconds
}//if minutes
}//if degrees
else {return FALSE;}
break;
case 0:
acutPrintf("\nAngle input format: Decimal Degrees [centesimals]\n");
ads_real decDeg;
acedInitGet(RSG_NONEG,"");
if (acedGetReal("\nDecimal degrees: ",&decDeg)==RTNORM){
delta=decDeg/400*360;
return delta;
}//if decimal degrees
else {return FALSE;}
break;
}
}


[LE]

Some pecata minuta.... I know no one noticed:

Code: [Select]

int ang_dec(ads_real delta) {
char var[1024];
if (acedGetEnv("ArcDrawAngleInput",var) != RTNORM) {
acedSetEnv("ArcDrawAngleInput","1");
acedGetEnv("ArcDrawAngleInput",var);
}
switch (atoi(var)) {
case 1:
acutPrintf("\nAngle input format: DMS [sexagesimal]\n");
ads_real grad,mnt,seg;
acedInitGet(RSG_NONEG,"");
if (acedGetReal("\nDegrees: ",&grad)==RTNORM) {
acedInitGet(RSG_NONEG,"");
if (acedGetReal("\nMinutes: ",&mnt)==RTNORM) {
acedInitGet(RSG_NONEG,"");
if (acedGetReal("\nSeconds: ",&seg)==RTNORM) {
delta=grad+mnt/60.0+seg/3600.0;
return TRUE;
}//if seconds
}//if minutes
}//if degrees
else {return FALSE;}
break;
case 0:
acutPrintf("\nAngle input format: Decimal Degrees [centesimals]\n");
ads_real decDeg;
acedInitGet(RSG_NONEG,"");
if (acedGetReal("\nDecimal degrees: ",&decDeg)==RTNORM){
delta=decDeg/400*360;
return TRUE;
}//if decimal degrees
else {return FALSE;}
break;
}
}

Then it can be use like:

Code: [Select]

ads_real delta;
if (ang_dec(delta)==TRUE) {