Author Topic: -={ Challenge }=- Enclose lines (Read 5832 times)

kasmo · « **Reply #30 on:** July 01, 2023, 08:21:28 AM »

Quote from: El Jefe on July 01, 2023, 08:07:12 AM

Quote from: kasmo on July 01, 2023, 07:54:59 AM
Good enough for the sample dwg, hehe

are you sure?

Quote
Command: OUTLINE
Select objects: Specify opposite corner: 61 found
Select objects:
; error: no function definition: REMOVE

Not my fault you're using inferior CAD software

I changed it now to vl-remove just for you

JohnK · « **Reply #31 on:** July 01, 2023, 10:57:39 AM »

Quote from: VovKa on July 01, 2023, 05:09:48 AM

this is the first time i see a program that needs a full week to be tested
as for Saturdays - not working

Quote from: El Jefe on June 30, 2023, 10:33:52 PM

Saturday here

Okay I fixed my code above (I had a paren misplaced). ...Hopefully I got it fixed so it could be tested on Saturday/Sunday.

VovKa · « **Reply #32 on:** July 01, 2023, 11:38:43 AM »

Quote from: JohnK on July 01, 2023, 10:57:39 AM

Okay I fixed my code above (I had a paren misplaced). ...Hopefully I got it fixed so it could be tested on Saturday/Sunday.

of course i fixed the misplaced paren myself before testing
https://imgur.com/a/0xKVC0z

zak26 · « **Reply #33 on:** July 01, 2023, 11:41:43 AM »

Quote from: El Jefe on June 30, 2023, 10:31:27 PM

enl doesn't like this case

This didn't happened on my side, could you send me your test file to test it further?

Edit: Not needed, I found an example where it happens, working on it.

JohnK · « **Reply #34 on:** July 01, 2023, 11:51:51 AM »

Quote from: VovKa on July 01, 2023, 11:38:43 AM

Quote from: JohnK on July 01, 2023, 10:57:39 AM
Okay I fixed my code above (I had a paren misplaced). ...Hopefully I got it fixed so it could be tested on Saturday/Sunday.
of course i fixed the misplaced paren myself before testing
https://imgur.com/a/0xKVC0z

Ugh! I’ll have to put one of the sort algorithms into my mock-up to handle a window selection. But what happens if you have the items preselected before the program is called (I imagine it wouldn’t make any difference at all)?

VovKa · « **Reply #35 on:** July 01, 2023, 12:18:04 PM »

Quote from: JohnK on July 01, 2023, 11:51:51 AM

But what happens if you have the items preselected before the program is called (I imagine it wouldn’t make any difference at all)?

it does not make any difference

zak26 · « **Reply #36 on:** July 01, 2023, 02:12:42 PM »

Still having this kind of problem, making it recursive did fix the mayor problems but this is still remaining on this kind of shapes (on the dwg)

Lee Mac · « **Reply #37 on:** July 01, 2023, 05:59:15 PM »

Quote from: zak26 on July 01, 2023, 02:12:42 PM

Still having this kind of problem, making it recursive did fix the mayor problems but this is still remaining on this kind of shapes (on the dwg)

Will probably post my code next week - the algorithm isn't particularly clever though.

It's Alive! · « **Reply #38 on:** July 01, 2023, 11:17:15 PM »

another method, make some assumptions

Rotate each line seg to align with Y
Sort the line segs by X.
If needed, flip each seg so its kind of codirectional to Y
Build the pline halfs
Rotate it back

Code - Python: [Select]

import PyRx as Rx
import PyGe as Ge
import PyGi as Gi
import PyDb as Db
import PyAp as Ap
import PyEd as Ed
from functools import cmp_to_key
 
def segCmp(segL, segR):
    pl = segL.midPoint()
    pr = segR.midPoint()
    if pl.x < pr.x:
        return -1
    elif pl.x > pr.x:
        return 1
    else:
        return 0
 
def PyRxCmd_pydoit():
    try:
        filter = [(Db.DxfCode.kDxfStart, "LINE,LWPOLYLINE")]
        ssres = Ed.Editor.select(filter)
        if ssres[0] != Ed.PromptStatus.eNormal:
            return
        
        ss = ssres[1].toList()
        dir = None
        segs = []
 
        for id in ss:
            if id.isDerivedFrom(Db.Curve.desc()):
                curve = Db.Curve(id)
                segs.append(Ge.LineSeg3d(
                    curve.getStartPoint(), curve.getEndPoint()))
                if dir == None:
                    dir = curve.getEndPoint() - curve.getStartPoint()
 
        dir.normalize()
        xform = Ge.Matrix3d()
        xform.setToRotation(dir.angleTo(
            Ge.Vector3d.kYAxis, Ge.Vector3d.kZAxis), Ge.Vector3d.kZAxis, Ge.Point3d.kOrigin)
 
        for seg in segs:
            seg.transformBy(xform)
 
        segs.sort(key=cmp_to_key(segCmp))
 
        for seg in segs:
            if seg.getStartPoint().y > seg.getEndPoint().y:
                seg.reverseParam()
 
        pline = Db.Polyline(len(segs) * 2)
 
        n = 0
        for ind in range(0, len(segs)):
            p = segs[ind].getStartPoint()
            pline.addVertexAt(n, Ge.Point2d(p.x, p.y))
            n += 1
 
        n = len(segs)
        for ind in reversed(range(0, len(segs))):
            p = segs[ind].getEndPoint()
            pline.addVertexAt(n, Ge.Point2d(p.x, p.y))
            n += 1
 
        pline.setClosed(True)
        pline.setColorIndex(1)
        pline.transformBy(xform.invert())
        
        db = Db.HostApplicationServices().workingDatabase()
        model = Db.BlockTableRecord(db.modelSpaceId(), Db.OpenMode.ForWrite)
        model.appendAcDbEntity(pline)
 
    except Exception as err:
        print(err)
 

kasmo · « **Reply #39 on:** July 02, 2023, 04:16:33 AM »

Quote from: zak26 on July 01, 2023, 02:12:42 PM

Still having this kind of problem, making it recursive did fix the mayor problems but this is still remaining on this kind of shapes (on the dwg)

Assuming the lines were drawn in order works well in this case.

Code - Auto/Visual Lisp: [Select]

(defun c:ol ( / l l2 eg )
  (foreach x (vl-remove-if 'listp (mapcar 'cadr (ssnamex (ssget "_:L"))))
    (setq l (append l (list (vlax-curve-getstartpoint x))))
    (setq l2 (append l2 (list (vlax-curve-getendpoint x))))
  )
  (entmakex (append (list '(0 . "LWPOLYLINE")
                          '(100 . "AcDbEntity")
                          '(100 . "AcDbPolyline")
                          (cons 90 (+ (length l) (length l2)))
                          '(70 . 1))
                          (mapcar '(lambda (x) (cons 10 x)) (append l (reverse l2))))
  )
)
 

Running multiple functions with different approaches and returning the outline with something like the lowest average vertex length would probably yield the best results.

domenicomaria · « **Reply #40 on:** July 02, 2023, 03:04:54 PM »

Code - Auto/Visual Lisp: [Select]

(defun :LWP-EMK-V-LST   (v-lst)
   (entmake 
      (append
            (list   '(0 . "LWPOLYLINE")   '(100 . "AcDbEntity")   '(100 . "AcDbPolyline")   (cons 90 (length v-lst) ) )
            (apply 'append    (mapcar '(lambda (i) (list (cons 10 i ) ) )  v-lst) )
      )
   )
)
 
(defun :SS>OBJECT-LIST (ss / ind l)
   (setq ind 0)
   (repeat (sslength ss)
      (setq l (cons (vlax-ename->vla-object (ssname ss ind) ) l) )      (setq ind (+ 1 ind) )
   )
   (reverse l)
)
 
 
(defun C:PARALLEL-PLINES-SHAPE (
                                   /
                                   -base-ang -base-ang-90 base-ang e-pt i i-pt-0 i-pt-1 o o-e-pt o-s-pt o-x-ang
                                   p0 s-pt sorted-lst sp-ep-xp-lst ss ss-obj-lst v-lst x-ang x-dst x-ep
                                   x-int x-obj x-sp
                               )
   (setvar 'nomutt 1)  (princ "\nnselect  objects :")
   (setq ss (ssget '( (0 . "LWPOLYLINE"))))
   (setvar 'nomutt 0)
 
   (setq ss-obj-lst    (:SS>OBJECT-LIST    ss ) )
   
 
   (setq x-obj       (car ss-obj-lst)
         s-pt        (vlax-curve-getStartPoint x-obj)
         e-pt        (vlax-curve-getEndPoint   x-obj)
         base-ang    (angle s-pt e-pt)
         -base-ang   (angle e-pt s-pt )
         -base-ang-90 (- base-ang (/ pi 2.0) )
         i-pt-0       s-pt
         i-pt-1      (polar i-pt-0 (+ base-ang (/ pi 2.0) ) (distance s-pt e-pt) )
   )
 
   (setq sp-ep-xp-lst
      (mapcar   '(lambda (o)   
                   (setq o-s-pt     (vlax-curve-getStartPoint o)
                        o-e-pt     (vlax-curve-getEndPoint   o)
                        o-x-ang    (angle o-s-pt o-e-pt)
                  )
                  (cond
                     ( (equal o-x-ang  base-ang 1e-6) (list o-s-pt o-e-pt  (inters i-pt-0 i-pt-1 o-s-pt o-e-pt nil) ) )
                     ( (equal o-x-ang -base-ang 1e-6) (list o-e-pt o-s-pt  (inters i-pt-0 i-pt-1 o-s-pt o-e-pt nil) ) )
                     (t (progn (princ "pline is not parallel to the others one !") nil) )
                  )
               )
               ss-obj-lst
      )
   )
 
   (setq sp-ep-xp-lst (vl-remove nil sp-ep-xp-lst) )
 
   
   (setq p0 (caddr (car sp-ep-xp-lst) )  )
   
   (setq sorted-lst   (vl-sort   (mapcar '(lambda (i)
                                          (setq x-sp (car i) x-ep (cadr i) x-int (caddr i)
                                                x-ang (angle p0 x-int )  x-dst (distance x-int p0)
                                          )
                                          (if(equal x-ang -base-ang-90 1e-6) (setq x-dst (* x-dst -1.0) ) ) 
                                          (list x-sp x-ep x-dst)
                                       )
                                       sp-ep-xp-lst
                              )
                              '(lambda (j k) (< (caddr j) (caddr k) ) )
                     )
   )
 
   (setq v-lst (append (mapcar 'car sorted-lst)   (reverse (mapcar 'cadr sorted-lst) ) ) )
   (setq v-lst (append v-lst (list (car v-lst) ) ) )
   (setvar "cecolor" "240")
   (:LWP-EMK-V-LST v-lst)
)
 
 
(defun c:PPS () (C:PARALLEL-PLINES-SHAPE) )
   

If PLINES are PARALLEL,
even if they were NOT DRAWN in SEQUENCE
and even if they have OPPOSITE DIRECTIONS,
this one seems to work well !

https://drive.google.com/file/d/19WI-iLc1_uHEaddjnA9NJpXMqYz-tbrk/view?usp=sharing

It's Alive! · « **Reply #41 on:** July 02, 2023, 06:06:26 PM »

Quote from: domenicomaria on July 02, 2023, 03:04:54 PM

...

Well done!

kdub_nz · « **Reply #42 on:** July 02, 2023, 06:19:18 PM »

This may be an edge case :
What happens with a bow-tie shape drawn with non-sequential multi-directional parallel lines with a deep v notch.
A wavy edge where the distance between the ends exceeds twice the line spacing may also fail some algorithms.

Because of the stipulation for parallel lines my intuition would be to make a temporary ucs with X aligled with the collection elements.

Sort the collection bottom to top in Y direction.

Build a points collection by iteration up then down the collection

Build the closed boundary using the points

It would need a bit of translation between ucs <-> world but no complex math.

Regards,

It's Alive! · « **Reply #43 on:** July 02, 2023, 06:43:10 PM »

my last one fails if the lines are greater than 90.
maybe calculate an average

domenicomaria · « **Reply #44 on:** July 03, 2023, 05:22:55 AM »

the first problem is: "what is the problem?"

is this maybe ?

"given a set of lines in the XY plane,
however oriented and of any length,
determine the smallest polygon
containing them"

News:

Author Topic: -={ Challenge }=- Enclose lines (Read 5832 times)

kasmo

Re: -={ Challenge }=- Enclose lines

JohnK

Re: -={ Challenge }=- Enclose lines

VovKa

Re: -={ Challenge }=- Enclose lines

zak26

Re: -={ Challenge }=- Enclose lines

JohnK

Re: -={ Challenge }=- Enclose lines

VovKa

Re: -={ Challenge }=- Enclose lines

zak26

Re: -={ Challenge }=- Enclose lines

Lee Mac

Re: -={ Challenge }=- Enclose lines

It's Alive!

Re: -={ Challenge }=- Enclose lines

kasmo

Re: -={ Challenge }=- Enclose lines

domenicomaria

Re: -={ Challenge }=- Enclose lines

It's Alive!

Re: -={ Challenge }=- Enclose lines

kdub_nz

Re: -={ Challenge }=- Enclose lines

It's Alive!

Re: -={ Challenge }=- Enclose lines

domenicomaria

Re: -={ Challenge }=- Enclose lines