Topic: Help Improve Code

[Ambo]

Hi there, I'm trying to write a subroutine on renaming a viewport layer by searching a viewport for specific frozen layer names.  It's working but the list of layers to be included in the search keeps on growing and ending up with so many "(and" on my code.  I know that there's a much better way of writing this but I just don't know how.  Could someone show me a more efficient way of writing the below lines please. OR... is there a similar function to express tool's "acet-viewport-frozen-layer-list" but for thawed layers? I've already searched to no avail. I'm thinking that if I can get a subroutine to do the opposite then I don't need the long list of frozen layers anymore.   Thank you.

Code: [Select]

(setq layer_list (acet-viewport-frozen-layer-list
(acet-currentviewport-ename)))

(if (and (and (member "Layer 1" layer_list)
(member "Layer 2" layer_list)
(member "Layer 3" layer_list)))
(progn
(setq lname "For Tender")
(setq lname "For Draft")))

[roy_043]

There is no need for:

Code - Auto/Visual Lisp: [Select]

1. (and (and ...))

It is the same as:

Code - Auto/Visual Lisp: [Select]

1. (and ...)

Alternative for your code:

Code - Auto/Visual Lisp: [Select]

1. (if
2.   (vl-every
3.     '(lambda (lay) (vl-position lay layer_list))
4.     '("Layer 1" "Layer 2" "Layer 3")
5.   )
6.   (setq lname "For Tender")
7.   (setq lname "For Draft")
8. )

When posting code, please use code tags.

[Ambo]

Thanks roy_043!  I'm learning a lot from kind people like you in this forum and apologies for forgetting to use the code tags.