Topic: Fast Demolition Code

[cmwade77]

I am rewritting our LISP routine that draws our demolition hatching due to several bugs and to fix some workflow issues. I have it most of the way there, but the problem seems to come when selecting more than one open polyline. For some reason when I do, one of the polylines errors out with: ; error: ActiveX Server returned the error: unknown name: "OFFSET"

Here's the code, any assistance that anyone can provide in figuring out what is wrong would be greatly appreciated.

<<Removed Old Code>>

[cmwade77]

Nevermind, I found it, I was apparently missing a ), code is updated above if it helps anyone and please feel free to let me know if you find any other problems.

Ok, apparently the outline code used from Lee doesn't outline blocks, can anyone help me fix that?

[cmwade77]

Google is my friend, I found this post here: http://www.theswamp.org/index.php?topic=26664.msg358674#msg358674

I was able to adapt this code into something workable, here is the updated code:
<<Removed Old Code>>

There may still be bugs in it, so I would greatly appreciate any debugging that you may be able to assist with.

[cmwade77]

Ok, I now have code that should work better, but I would greatly appreciate it if anyone could take a look at it and check for bugs.

<<Removed old code>>


This code will draw demolition hatching over any selected objects, it should work with any AutoCAD object that the boundary command will work on.

[77077]

Ok, I now have code that should work better, but I would greatly appreciate it if anyone could take a look at it and check for bugs.

Hi cmwade77 .
This routine only hatch ? Can you upload a demo( gif) ?

[danallen]

No luck with Bricscad v13, crashes after selecting line.

Code: [Select]

: fd
Select objects to demolish:
Select entities:
Entities in set: 1
Select entities:

; ----- LISP : Call Stack -----
; [0]...C:FD
; [1].....LM:OUTLINE <<--
;
; ----- Error around expression -----
'DISTANCE
;
; error : too few / too many arguments at [EVAL]

[Lee Mac]

Hi Chris,

You may want to use the latest iteration of my LM:outline function, published on my site here - I added some additional error trapping to account for situations in which the bounding box of the set could not be determined.

Lee

[danallen]

that may be it, I selected a vertical line to cause the error

[cmwade77]

that may be it, I selected a vertical line to cause the error

Hmm, if it were a PLINE, that should be handled before I ever call Lee's routine, but if it's just a regular line, I don't really handle that anywhere, but I probably should.

[cmwade77]

Ok, I now have code that should work better, but I would greatly appreciate it if anyone could take a look at it and check for bugs.

Hi cmwade77 .
This routine only hatch ? Can you upload a demo( gif) ?

I honestly am not sure how to create a demo gif, any suggestions for free tools to do so?

[cmwade77]

Hi Chris,

You may want to use the latest iteration of my LM:outline function, published on my site here - I added some additional error trapping to account for situations in which the bounding box of the set could not be determined.

Lee

Lee, I am starting to wonder if I would ever finish a routine without your help.

[MP]

I honestly am not sure how to create a demo gif, any suggestions for free tools to do so?

www.getsharex.com

[roy_043]

As danallen's test shows there is an issue with LM:outline if the 'sel' input only contains elements that do not produce an outline. In that case the return value is an empty selection set, instead of nil as you might expect.

My advice would be:
Change Lee's code so that it returns nil if there is no outline. Whenever you call LM:outline you can then check for a nil return value and act accordingly.

[roy_043]

The problem that danallen indicated is caused by this line:

Code: [Select]

(setq fh_SS (LM:Outline h_SS))If the user selection contains only a single line, h_SS will be an empty selection set. LM:Outline doesn't work with empty selection sets.

[Lee Mac]

Lee, I am starting to wonder if I would ever finish a routine without your help.

I'm delighted to be able to assist you 

My advice would be:
Change Lee's code so that it returns nil if there is no outline. Whenever you call LM:outline you can then check for a nil return value and act accordingly.

...LM:Outline doesn't work with empty selection sets.

Good catch roy -

I agree that the function should be modified to return nil rather than an empty selection set if the outline cannot be generated, however, I don't think the function should be modified to accept a null selection set, as I feel this should be the responsibility of the caller.