Author Topic: help with a lisp (Read 10736 times)

Kerry · « **Reply #15 on:** March 27, 2014, 03:57:52 PM »

There are a few number ranges that are not evaluated.

Draw yourself a numberLine and mark off the ranges you ARE testing.
http://en.wikipedia.org/wiki/Number_line

You may need to add conditionals and assignments for those ranges ...

Kerry · « **Reply #16 on:** March 27, 2014, 04:01:16 PM »

It looks like you are missing some parenthesis in your conditional statement

(cond
<HERE> (and (>= area 750) (<= area 1200) <and HERE>

.. do stuff
)
.. more conditionals
)

pedroantonio · « **Reply #17 on:** March 27, 2014, 04:16:14 PM »

I add the parenthesis
The lisp run and when i select 3 option gives me this error !!!
; error: bad argument type: numberp: nil

Code - Auto/Visual Lisp: [Select]

 (defun c:test4
       (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          ((>= area 700)
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 ()
  (cond ((<= sdarea 400)  ; I don't know if this is correct maxD = 400
           (setq sdarea (* area 0.8)
                 skarea (* area 0.6)
           )
          )          
    )
  )
  (defun _option3 ()
 
      (cond ((and (>= area 750) (<= area 1200)
           (setq sdarea (+ 100 ( / (- area 750) 9))
                 skarea (* area 0.1)
           )
          )
                    
           ((and (> area 1200) (<= area 2000)
           (setq sdarea (+ 150 ( / (- area 1200) 16))
                 skarea (* area 0.1)
           )
          )
           ((and (> area 2000) (< area 4000)
           (setq sdarea 0
                 skarea 0
                    )
          )
 
           ((= area 4000)
           (setq sdarea 200
                 skarea (* area 0.1)
           )
          )
          ((and (> area 4000) (<= area 8000)
           (setq sdarea (+ 200 ( * 0.02 (- area 4000)))
                 skarea (* area 0.1)
           )
          )
          
          ((> area 8000)
           (setq sdarea (+ 280 ( * 0.01 (- area 8000)))
                 skarea (* area 0.1)
             )
           )
         )
       )
     )
    )
  )
)
 
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (initget 7)
(TEXTPAGE)
  (PROMPT
    "\n choose option :
 
   1. Choose 1 for this ...
   2. Choose 2 for this ...
   3. Choose 3 for this ...
   4. Choose 4 for this ...
 
" )
      (setq area   (vlax-curve-getarea ent)
            option (getint "Select Option 1 to 4 : ")
      )
      (cond ((= option 1) (_Option1))
            ((= option 2) (_Option2))
            ((= option 3) (_Option3))
            ((= option 4) (_Option4))
            (t (alert "Read the prompt, Idiot\nUsing Option 4. ") (_Option4))
      )
      (princ (strcat "\n Selected Area = "
                     (rtos area 2 2)
                     "\n D = "
                     (rtos sdarea 2 2)
                     " sq.m"
                     "\n K = "
                     (rtos skarea 2 2)
                     " sq.m"
             )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 
 
 

Kerry · « **Reply #18 on:** March 27, 2014, 04:22:06 PM »

Quote from: Topographer on March 27, 2014, 04:16:14 PM

I add the parenthesis and now gives me

< .. >

Have another look ... your conditional test is mixed with the assignment code.

pedroantonio · « **Reply #19 on:** March 27, 2014, 04:30:53 PM »

I update the code but i still have the same problom with the option 3
; error: bad argument type: numberp: nil

Code - Auto/Visual Lisp: [Select]

 (defun c:test4
       (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          ((>= area 700)
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 ()
    (cond ((<= area 2000)
            (setq sdarea  (* area 0.8)
             skarea (* area 0.6)
           )
          )     
         ((> area 2000)
           (setq sdarea (+ 400 ( * 0.05 (- area 2000)))
                 skarea (* area 0.1)
           )
          )     
    )
  )
  (defun _option3 ()
 
      (cond ((and (>= area 750) (<= area 1200)
           (setq sdarea (+ 100 ( / (- area 750) 9))
                 skarea (* area 0.1)
           )
          )
 
           ((and (> area 1200) (<= area 2000)
           (setq sdarea (+ 150 ( / (- area 1200) 16))
                 skarea (* area 0.1)
           )
          )
           ((and (> area 2000) (< area 4000)
           (setq sdarea 0
                 skarea 0
                    )
          )
 
           ((= area 4000)
           (setq sdarea 200
                 skarea (* area 0.1)
           )
          )
          ((and (> area 4000) (<= area 8000)
           (setq sdarea (+ 200 ( * 0.02 (- area 4000)))
                 skarea (* area 0.1)
           )
          )
 
          ((> area 8000)
           (setq sdarea (+ 280 ( * 0.01 (- area 8000)))
                 skarea (* area 0.1)
             )
           )
         )
       )
     )
    )
  )
)
 
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (initget 7)
(TEXTPAGE)
  (PROMPT
    "\n choose option :
 
   1. Choose 1 for this ...
   2. Choose 2 for this ...
   3. Choose 3 for this ...
   4. Choose 4 for this ...
 
" )
      (setq area   (vlax-curve-getarea ent)
            option (getint "Select Option 1 to 4 : ")
      )
      (cond ((= option 1) (_Option1))
            ((= option 2) (_Option2))
            ((= option 3) (_Option3))
            ((= option 4) (_Option4))
            (t (alert "Read the prompt, Idiot\nUsing Option 4. ") (_Option4))
      )
      (princ (strcat "\n Selected Area = "
                     (rtos area 2 2)
                     "\n D = "
                     (rtos sdarea 2 2)
                     " sq.m"
                     "\n K = "
                     (rtos skarea 2 2)
                     " sq.m"
             )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 
 
 

Kerry · « **Reply #20 on:** March 27, 2014, 04:33:40 PM »

Try something like this for _option2

Code - Auto/Visual Lisp: [Select]

(defun _option2 ()
  (cond (area
         (setq sdarea (min 400.0 (* area 0.8))
               skarea (* area 0.6)
         )
        )
  )
)

Kerry · « **Reply #21 on:** March 27, 2014, 04:35:56 PM »

Try this formatting for option3
I haven't looked at the logic

Code - Auto/Visual Lisp: [Select]

 
(defun _option3 ()
     (cond ((and (>= area 750) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 1200) (<= area 2000))
            (setq sdarea (+ 150 (/ (- area 1200) 16))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 2000) (< area 4000))
            (setq sdarea 0
                  skarea 0
            )
           )
           ((= area 4000)
            (setq sdarea 200
                  skarea (* area 0.1)
            )
           )
           ((and (> area 4000) (<= area 8000))
            (setq sdarea (+ 200 (* 0.02 (- area 4000)))
                  skarea (* area 0.1)
            )
           )
           ((> area 8000)
            (setq sdarea (+ 280 (* 0.01 (- area 8000)))
                  skarea (* area 0.1)
            )
           )
     )
   )
 
 

pedroantonio · « **Reply #22 on:** March 27, 2014, 04:44:59 PM »

Thank you Kerry .Now the lisp works fine. Can you explain me were was the mistake. I had exactly the same function before and not working properly !!!

Kerry · « **Reply #23 on:** March 27, 2014, 04:50:30 PM »

Quote from: Topographer on March 27, 2014, 04:44:59 PM

Thank you Kerry .Now the lisp works fine. Can you explain me were was the mistake. I had exactly the same function before and not working properly !!!

The error was in the parenthesis.
Have a look at this Post reply

Quote from: Kerry on March 27, 2014, 04:01:16 PM

It looks like you are missing some parenthesis in your conditional statement

(cond
<HERE> (and (>= area 750) (<= area 1200) <and HERE>

.. do stuff
)
.. more conditionals
)

Did you build tests for each conditional ?
If you fix the edge cases and the missing ranges you may not need to look at the code again after testing.

pedroantonio · « **Reply #24 on:** March 27, 2014, 05:16:08 PM »

Kerry , The only problem i have is with this

Code - Auto/Visual Lisp: [Select]

((and (>= area 750) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
 

For area = 750 and i change the code to this

Code - Auto/Visual Lisp: [Select]

((and (<= 750 area) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
 

I test it and work. What is your opinion ?

Thanks

Kerry · « **Reply #25 on:** March 27, 2014, 05:19:47 PM »

Quote from: Topographer on March 27, 2014, 05:16:08 PM

< .. >
I test it and work. What is your opinion ?

Thanks

The logic is similar I believe ... just different test values.

pedroantonio · « **Reply #26 on:** March 27, 2014, 05:31:58 PM »

Kerry, Option 3 crass again for area = 750 i dont know why

; error: bad argument type: numberp: nil

Code - Auto/Visual Lisp: [Select]

 (defun c:test4
       (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          ((>= area 700)
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 ()
    (cond ((<= area 2000)
            (setq sdarea  (* area 0.8)
             skarea (* area 0.6)
           )
          )     
         ((> area 2000)
           (setq sdarea (+ 400 ( * 0.05 (- area 2000)))
                 skarea (* area 0.1)
           )
          )     
    )
  )
 
(defun _option3 ()
     (cond ((and (>= area 750) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 1200) (<= area 2000))
            (setq sdarea (+ 150 (/ (- area 1200) 16))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 2000) (< area 4000))
            (setq sdarea 0
                  skarea 0
            )
           )
           ((= area 4000)
            (setq sdarea 200
                  skarea (* area 0.1)
            )
           )
           ((and (> area 4000) (<= area 8000))
            (setq sdarea (+ 200 (* 0.02 (- area 4000)))
                  skarea (* area 0.1)
            )
           )
           ((> area 8000)
            (setq sdarea (+ 280 (* 0.01 (- area 8000)))
                  skarea (* area 0.1)
            )
           )
     )
   )
 
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (initget 7)
(TEXTPAGE)
  (PROMPT
    "\n choose option :
 
   1. Choose 1 for this ...
   2. Choose 2 for this ...
   3. Choose 3 for this ...
   4. Choose 4 for this ...
 
" )
      (setq area   (vlax-curve-getarea ent)
            option (getint "Select Option 1 to 4 : ")
      )
      (cond ((= option 1) (_Option1))
            ((= option 2) (_Option2))
            ((= option 3) (_Option3))
            ((= option 4) (_Option4))
            (t (alert "Read the prompt, Idiot\nUsing Option 4. ") (_Option4))
      )
      (princ (strcat "\n Selected Area = "
                     (rtos area 2 2)
                     "\n D = "
                     (rtos sdarea 2 2)
                     " sq.m"
                     "\n K = "
                     (rtos skarea 2 2)
                     " sq.m"
             )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 
 

Kerry · « **Reply #27 on:** March 27, 2014, 05:42:41 PM »

is area an integer
area = 750

or a real at 749.9999999999998

I'd close AutoCAD and reload the code.

Have you written tests yet ?

Where does the code crash .. on which line
I assume you're testing in VLIDE with Break on Error toggled ON and using Last Break Source Ctrl-F9 after the crash.

pedroantonio · « **Reply #28 on:** March 27, 2014, 06:03:59 PM »

I change the code with this and work fine

Code - Auto/Visual Lisp: [Select]

 (defun _option3 ()
           (cond ((= area 750)
            (setq sdarea 100
                  skarea (* area 0.1)
            )
           )
            ((and (> area 750) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
                      ((and (> area 1200) (<= area 2000))
            (setq sdarea (+ 150 (/ (- area 1200) 16))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 2000) (< area 4000))
            (setq sdarea 0
                  skarea 0
            )
           )
           ((= area 4000)
            (setq sdarea 200
                  skarea (* area 0.1)
            )
           )
           ((and (> area 4000) (<= area 8000))
            (setq sdarea (+ 200 (* 0.02 (- area 4000)))
                  skarea (* area 0.1)
            )
           )
           ((> area 8000)
            (setq sdarea (+ 280 (* 0.01 (- area 8000)))
                  skarea (* area 0.1)
            )
           )
     )
   )
 
 

Thank you Kerry

Kerry · « **Reply #29 on:** March 28, 2014, 04:39:20 AM »

Quote from: Topographer on March 27, 2014, 06:03:59 PM

I change the code with this and work fine

< .. >

Thank you Kerry

Great. Glad I could help.

Just an observation :
I notice that the code you posted is not well formatted.
I'd suggest that use the VLIDE to format your code. A lot of the problems you have will be resolved by just accepting the formatting provided. Sometimes unbalanced statements are a little more obvious.

This is your code back ... just reformatted. You can see the flow a little easier because the 'paragraphs' line up a little better. This makes it easier to find faults in the logic.

In some regards VLIDE is a crap editor and it's disappointing that AutoDesk have not improved it in the last 15 years but it is a resource we should make the most of.

Code - Auto/Visual Lisp: [Select]

 
(defun _option3 ()
  (cond ((= area 750)
         (setq sdarea 100
               skarea (* area 0.1)
         )
        )
        ((and (> area 750) (<= area 1200))
         (setq sdarea (+ 100 (/ (- area 750) 9))
               skarea (* area 0.1)
         )
        )
        ((and (> area 1200) (<= area 2000))
         (setq sdarea (+ 150 (/ (- area 1200) 16))
               skarea (* area 0.1)
         )
        )
        ((and (> area 2000) (< area 4000))
         (setq sdarea 0
               skarea 0
         )
        )
        ((= area 4000)
         (setq sdarea 200
               skarea (* area 0.1)
         )
        )
        ((and (> area 4000) (<= area 8000))
         (setq sdarea (+ 200 (* 0.02 (- area 4000)))
               skarea (* area 0.1)
         )
        )
        ((> area 8000)
         (setq sdarea (+ 280 (* 0.01 (- area 8000)))
               skarea (* area 0.1)
         )
        )
  )
)
 
 ;|«Visual LISP© Format Options»
(80 2 45 2 nil "end of " 80 45 1 0 nil nil nil nil T)
;*** DO NOT add text below the comment! ***|;
 

Regards,

News:

Author Topic: help with a lisp (Read 10736 times)

Kerry

Re: help with a lisp

Kerry

Re: help with a lisp

pedroantonio

Re: help with a lisp

Kerry

Re: help with a lisp

pedroantonio

Re: help with a lisp

Kerry

Re: help with a lisp

Kerry

Re: help with a lisp

pedroantonio

Re: help with a lisp

Kerry

Re: help with a lisp

pedroantonio

Re: help with a lisp

Kerry

Re: help with a lisp

pedroantonio

Re: help with a lisp

Kerry

Re: help with a lisp

pedroantonio

Re: help with a lisp

Kerry

Re: help with a lisp