Topic: How to run a lisp when close file ?

[kruuger]

Glad to help, though I fear we've led you to the dark side. If you think you've made errors before, wait till you've made an error in reactors  ... they're DANGEROUS beyond belief!

So true.. Dangerous reactor is.

@hasanCAD/kruuger

Think about this. what are the conditions as when to trigger the lisp routine? Every time the user invoke a save* command? in the event the user saves the file and continues working on the file?
after a while the user click save again, then that will be two Filehistory lines. You may need to use a counter within the lisp code to determine that it ran at least once, then it should the repalce the string rather than writing a new line.

_close reator is indeed the way to go

i'm using this reactor to save info about user who modify the file.
after few days of work i have nice history in DICTIONARY
of course i can review with separate program
this is what you want HasanCAD ?
kruuger

[Coder]

Why not include command CLOSE at the bottom of the routine and exclude using reactors .... :pissed:

[kruuger]

Why not include command CLOSE at the bottom of the routine and exclude using reactors .... :pissed:

and how to run program to save history on close without reactor ?
kruuger

[irneb]

You could undefine the close command, then your defun would be named c:close and inside it you call "._CLOSE" to run the "undefined" command.

Or use the vla-Close on the current document rather. Also you might then have to implement some sort of "Do you want to save changes" dialog. Personally I agree with this idea more, there's less to go wrong, and you've got more control over what's happening.

[kruuger]

You could undefine the close command, then your defun would be named c:close and inside it you call "._CLOSE" to run the "undefined" command.

Or use the vla-Close on the current document rather. Also you might then have to implement some sort of "Do you want to save changes" dialog. Personally I agree with this idea more, there's less to go wrong, and you've got more control over what's happening.

probably should work. i don't know how close reactor but save works very well. i;m working with this routine over 2 years with 40 people.
there was not a single problem. history are always in drawings
kruuger

[Coder]

and how to run program to save history on close without reactor ?
kruuger

I mean when the user run the code , the text would be created and the command close would close the drawing .

[HasanCAD]

...
this is what you want HasanCAD ?
kruuger

YES this is what I want

[pBe]

after few days of work i have nice history in DICTIONARY
kruuger

Nice idea,
Will that be separate Dictionary for each drawing file on an external file? does it keep a record on the drawing itself?

[BlackBox]

Thanks pBe I'll study yours

I guess the best way to do that is via reactor

How is this?
I do not know whats reactor.

Code - Auto/Visual Lisp: [Select]

1. (Defun AtSaveCommand (calling-reactor b)
2.   (if
3.     (or
4.       (= (car b) "QSAVE")
5.       (= (car b) "SAVEAS")
6.       (= (car b) "SAVE")
7.     )
8.     (C:SLOWNIK)
9.   )
10. )
11.  
12. (Defun loadTheSaveReactor ()
13.   (vl-load-com)
14.   (if *FileOnSave* (vlr-remove *FileOnSave*))
15.   (setq *FileOnSave* (vlr-command-reactor nil '((:vlr-commandwillStart . AtSaveCommand))))
16. )
17.  
18. (loadTheSaveReactor)

i'm using this when someone save the drawing. works very well.
easy to modify to CLOSE.
kruuger

FWIW - I've always preferred the OR function when calls may be made more than once within a Defun (I've also used Cond as needed):

Code - Auto/Visual Lisp: [Select]

1.  
2.  
3.  
4. (vl-load-com)
5. ;;;--------------------------------------------------------------------;
6. ;;; Reactors:Start function
7. (defun Reactors:Start  ()
8.  
9.   ;; Command reactors
10.   (or *Reactors_Command*
11.       (setq *Reactors_Command*
12.              (vlr-command-reactor
13.                nil
14.                '((:vlr-commandCancelled . Callback:CommandEnded)
15.                  (:vlr-commandEnded . Callback:CommandEnded)
16.                  (:vlr-commandFailed . Callback:CommandEnded)
17.                  (:vlr-commandWillStart . Callback:CommandWillStart)))))
18.  
19.   ;; <- Other reactors (i.e., AcDb, DocManager, Editor, Object, etc.
20.  
21.   (prompt "\n \n  >>  Reactors Loaded ")
22.   (princ))
23. ;;;--------------------------------------------------------------------;
24. ;;; Callback:CommandEnded function
25. (defun Callback:CommandEnded  (rea cmd / cmdName)
26.   (cond
27.     ((wcmatch (setq cmdName (car cmd))
28.               "COPY,GRIP_STRETCH,MOVE,SCALE,STRETCH")                   ; Cursorsize
29.      (progn
30.        (setvar 'cursorsize *Reactor_CursorSize*)
31.        (setq *Reactor_CursorSize* nil)))
32.  
33.     ((wcmatch (setq cmdName (car cmd)) "**SAVE*")                       ; Save
34.      (c:SlowNik))
35.  
36.     ((and capslock
37.           (wcmatch cmdName
38.                    "BLOCK,*EDIT*,*TEXT*,*LAYERSTATE*,*LEADER*"))        ; Text edits
39.  
40.      ;; Restore original capslock setting
41.      (capslock *Reactor_CapsLock*)
42.      (setq *Reactor_CapsLock* nil))
43.  
44.     ;; <- Other commands
45.  
46.     ))
47. ;;;--------------------------------------------------------------------;
48. ;;; Callback:CommandWillStart function
49. (defun Callback:CommandWillStart  (rea cmd / cmdName)
50.   (cond ((wcmatch (setq cmdName (car cmd))
51.                   "COPY,GRIP_STRETCH,MOVE,SCALE,STRETCH")               ; Cursorsize
52.          (progn
53.            (setq *Reactor_CursorSize* (getvar 'cursorsize))
54.            (setvar 'cursorsize 100)))
55.  
56.         ((wcmatch cmdName "**SAVE*")                                    ; Save
57.          (c:SlowNik))
58.  
59.         ((and capslock
60.               (wcmatch cmdName
61.                        "*BLOCK,*EDIT*,*TEXT*,*LAYERSTATE*,*LEADER*"))   ; Text edits
62.  
63.          ;; Store original capslock setting, and turn capslock on
64.          (setq *Reactor_CapsLock* (capslock))
65.          (capslock T))
66.  
67.         ;; <- Other commands
68.  
69.         ))
70. ;;;--------------------------------------------------------------------;
71. (Reactors:Start)
72. (princ)
73.  

... A few extra goodies are included, free of charge. LoL :kewl:

[kruuger]

after few days of work i have nice history in DICTIONARY
kruuger

Nice idea,
Will that be separate Dictionary for each drawing file on an external file? does it keep a record on the drawing itself?

i store user info only in drawing:

Code - Auto/Visual Lisp: [Select]

1. UserHistory [under named object dictionary]
2. |
3. |---Item_1 (xrecord)
4. |---Item_2 (xrecord)
5. |---Item_3 (xrecord)

but this can be very easy save to file

...
this is what you want HasanCAD ?
kruuger

YES this is what I want

please find attached files and make a test.
the coding is TERRIBLE. maybe it is time to rewrite this mess 
load all files. after save command type AUTOR to see the dwg log.
k.

[HasanCAD]

...
A few extra goodies are included, free of charge. LoL :kewl:

I like every think if is free 

[HasanCAD]

...
the coding is TERRIBLE. maybe it is time to rewrite this mess 
...

YES it is

You know when I read these 2 replies

http://docs.autodesk.com/ACD/2011/ENU/filesALG/WS73099cc142f4875516d84be10ebc87a53f-7c34.htm
and
http://docs.autodesk.com/ACD/2011/ENU/filesALR/WS1a9193826455f5ff1a32d8d10ebc6b7ccc-67b0.htm

and

Also from the same website you used for reference on you code:
http://www.afralisp.net/visual-lisp/tutorials/reactors-part-1.php

My feeling was that both of us on a boat and you pushed me in the sea and said " teach yourself the swimming"

[HasanCAD]

...
please find attached files and make a test.
...

That perfect

but when open, save and close the file gives me one line in history

[kruuger]

...
please find attached files and make a test.
...

That perfect

but when open, save and close the file gives me one line in history

if one person is working on file, there is only one line per day. each save replace only time.
when someone else save the dwg program add them to history.
if file back to you program will "catch you" again.
is this clear ?

rewritten AUTOR.LSP to LOG.LSP (new shortcut LOG)
added option to sort columns.
dcl file is created on the fly (Save login.dcl not required)

kruuger

[BlackBox]

What is to prevent the user from opening the drawing, and doing nothing for several hours and saving the drawing (effectively producing nothing). Won't their time still be logged?

Perhaps it would be prudent to incorporate a Sysvar Reactor that monitors Cmdactive, and when commands are not active, the timer is prgramatically stopped. Just a thought, as this thread somewhat reminds me an AUGI thread about CadTempo.