Topic: shortening a lisp quick question

[diarmuid]

Hi Guys, quick question:

Is there a shorter way of writing this?

Code: [Select]

(if (or(tblsearch "block" "M-STagLin01")
        (tblsearch "block" "M-STagLin02")
        (tblsearch "block" "M-STagLin03")
        (tblsearch "block" "M-STagLin04"))
            (progn
            (Alert  (strcat "\nIncorrect Line-tag line in use in this P&ID. Please repair "
                           "\nthe drawing using the Button utility provided. Should you"
                    "\nrequire assisatance please contact tech-ops.")
            )
            )
 )
 

[ElpanovEvgeniy]

(and (vl-some '(lambda (a) (tblsearch "block" (strcat "M-STagLin0" a))) '("1" "2" "3" "4"))
     (Alert (strcat "\nIncorrect Line-tag line in use in this P&ID. Please repair "
                    "\nthe drawing using the Button utility provided. Should you"
                    "\nrequire assisatance please contact tech-ops."
            ) ;_  strcat
     ) ;_  Alert
)

[Pepe]

Maybe this?

Code: [Select]

(if (vl-some '(lambda (x) (tblsearch "BLOCK" x)) '("M-STagLin01" "M-STagLin02" "M-STagLin03" "M-STagLin04"))
  (Alert "\nIncorrect Line-tag line in use in this P&ID. Please repair\nthe drawing using the Button utility provided. Should you\nrequire assisatance please contact tech-ops.")
  )
Slainte!

[T.Willey]

I would roll my own table search function where you could supply a list of names to search for, and either return after it finds one, or have it return an associate list, with the names found, and the block definition entity.

With each ' tblsearch ' call, you are stepping though all block definitions ( or all until the one is found ), and since you might call it multiple times, that is a slow way to do it.

[ronjonp]

What about using tblobjname?

[dgorsman]

Calling (vla-Item...) on the Blocks collection might be an acceptable substitute (with the (vl-catch-all-apply...) wrappings of course).

[Pepe]

Evgeny:

I didn't see your reply before I posted mine (same ways, but different).

Only a question about (just to improve myself): Why AND instead IF  ? (I suppose it's in order to avoid an ELSE, but it could have it's own logic...)

Thanks in advance.

[diarmuid]

Thanks for all of the input Guys

go raibh maith agat

[diarmuid]

Thanks for the help,

The reason i was getting the help window appearing was my code showed:

(command "explode" "l" "")

This was incorrect, the extra "" at the end was not needed. (sure when you type out the command you need an extra "enter" to exit the comment, but from inside a lisp you dont when you select "last".

Regards

Diarmuid

[diarmuid]

Sorry guys, wrong topic, ive posted it to the correct topic

 

[chlh_jd]

just Readily

Code: [Select]

(if (vl-some '(lambda (x) (tblsearch "BLOCK" (strcat "M-STagLin0" x)))
     '("1" "2" "3" "4")
    )
  (Alert
    "\nIncorrect Line-tag line in use in this P&ID. Please repair\nthe drawing using the Button utility provided. Should you\nrequire assisatance please contact tech-ops."
  )
)


[chlh_jd]

oh Evgeniy  & Pepe has Provided the shorten