Topic: handle numbers

[Robert98]

I'm beginner in autolisp programming and at a peace of my codes an error occurs , please tell me what is my mistake ? :realmad:
code :

(defun mta (/ x y z)
  ;multiply x and y and if z is not nil and is any number so add it to x*y
  (setq p (* x y))
  (cond
    ((z nil) (princ (+ p 0)))      
    ((numberp z) (princ (+ p z)))

  )               ;end cond
)

[ronjonp]

If I'm understanding your question ... see if this makes any sense to you:

Code: [Select]

(setq pt (getpoint))

(setq X*Y (* (car pt) (cadr pt)))

(if (and (setq z (caddr pt)) (numberp z))
  (alert (rtos (+ X*Y z)))
)

[HasanCAD]

An answer from a beginner

In case of using this code as a subroutine

Code: [Select]

(defun mta (x y z /)
  ;multiply x and y and if z is not nil and is any number so add it to x*y
  (setq p (* x y))
  (cond
    ((=z nil) (princ (+ p 0)))     
    ((numberp z) (princ (+ p z)))

  );end cond
)
In case of using this code as a separate lisp
* PS command line is MTA

Code: [Select]

(defun c:mta (/ pnt1 pnt2 x y z)
  ;multiply x and y and if z is not nil and is any number so add it to x*y
  (setq pnt1 (getpoint "\n pick Lower left corner"))
  (setq pnt2 (getcorner pnt1 "\n pick Upper right corner")
x (- (car pnt2) (car pnt1))
y (- (cadr pnt2) (cadr pnt1))
z (- (caddr pnt2) (caddr pnt1))
)
  (setq p (* x y))
  (cond
    ((=z nil) (princ (+ p 0)))     
    ((numberp z) (princ (+ p z)))

  );end cond
)

[CAB]

My simple answer.

Code: [Select]

(defun mta (x ; variable value supplied by calling routine
            y
            z
            / p)
  ;multiply x and y and if z is not nil and is any number so add it to x*y
  (setq p (* (x y)) ; note that if both are integer's the result will be an integer
        ;;  if one is a real number the result will be a real number
        (princ "\n") ; line feed
  (cond
    ((null z) (princ (+ p 0)))      
    ((numberp z) (princ (+ p z)))
    (t (princ (+ p 0))(princ " Z is not a number or nil"))
  )               ;end cond
)


(defun c:test()
  (mta 10 2 nil)
  (princ)
)

[HasanCAD]

Another option with alert message

Code: [Select]

(defun c:mta (/ x y z)
  ;multiply x and y and if z is not nil and is any number so add it to x*y
  (setq pnt1 (getpoint "\n pick Lower left corner"))
  (setq pnt2 (getcorner pnt1 "\n pick Upper right corner")
x (- (car pnt2) (car pnt1))
y (- (cadr pnt2) (cadr pnt1))
z (- (caddr pnt2) (caddr pnt1))
)
  (setq p (* x y))
  (cond
    ((= z 0.0) (alert (strcat "Area = "(rtos (+ p 0) 2 2))))     
    ((numberp z) (alert (strcat "volume= "(rtos (+ p z) 2 2))))

  );end cond
)

[T.Willey]

Felt left out.  Here is my entry.

Code: [Select]

(defun mta ( x y z ) (+ (if (numberp z) z 0) (* x y)))

[ronjonp]

Felt left out.  Here is my entry.

Code: [Select]

(defun mta ( x y z ) (+ (if (numberp z) z 0) (* x y)))

You beat me 

[MP]

Felt left out.  Here is my entry.

Code: [Select]

(defun mta ( x y z ) (+ (if (numberp z) z 0) (* x y)))

Without a more lucid description of the op's wants I think this is the answer, good job Tim.

[T.Willey]

Felt left out.  Here is my entry.

Code: [Select]

(defun mta ( x y z ) (+ (if (numberp z) z 0) (* x y)))

You beat me  

Figured all other ways were posted, so decide to post one that I would use, even though it might not be easy to read for someone beginning.  

Felt left out.  Here is my entry.

Code: [Select]

(defun mta ( x y z ) (+ (if (numberp z) z 0) (* x y)))

Without a more lucid description of the op's wants I think this is the answer, good job Tim.

Thanks Michael.

[Robert98]

If I'm understanding your question ... see if this makes any sense to you:

Code: [Select]

(setq pt (getpoint))

(setq X*Y (* (car pt) (cadr pt)))

(if (and (setq z (caddr pt)) (numberp z))
  (alert (rtos (+ X*Y z)))
)

An answer from a beginner

In case of using this code as a subroutine

Code: [Select]

(defun mta (x y z /)
  ;multiply x and y and if z is not nil and is any number so add it to x*y
  (setq p (* x y))
  (cond
    ((=z nil) (princ (+ p 0)))     
    ((numberp z) (princ (+ p z)))

  );end cond
)
In case of using this code as a separate lisp
* PS command line is MTA

Code: [Select]

(defun c:mta (/ pnt1 pnt2 x y z)
  ;multiply x and y and if z is not nil and is any number so add it to x*y
  (setq pnt1 (getpoint "\n pick Lower left corner"))
  (setq pnt2 (getcorner pnt1 "\n pick Upper right corner")
x (- (car pnt2) (car pnt1))
y (- (cadr pnt2) (cadr pnt1))
z (- (caddr pnt2) (caddr pnt1))
)
  (setq p (* x y))
  (cond
    ((=z nil) (princ (+ p 0)))     
    ((numberp z) (princ (+ p z)))

  );end cond
)

thanks for your tips , but I don't have a single point with x , y , z coordinates.my x , y , z are any positive number for example distances for area and volume computations . I don't pick any point and my "mta" function means is : multiply,then , if maybe add z value

[ronjonp]

Perhaps a bit more of what you're trying to accomplish  ... to me a "Z" value would be related to a point? Either way ... IMO Tim's solution is the most straight forward answer. Your X and Y are always numbers correct?

[alanjt]

If they are points, wouldn't it be easier to use something like one of the following?

Code: [Select]

(defun mta (lst)
  (+ (* (car lst) (cadr lst))
     (if (numberp (caddr lst))
       (caddr lst)
       0.
     )
  )
)

OR

(defun mta (lst)
  (+ (* (car lst) (cadr lst))
     (cond ((caddr lst))
           (0.)
     )
  )
)
That way you could also apply it to a list of point lists with mapcar.

[CAB]

Robert you will find the Lispers usually use variable names "x" "y" and "z" for processing
point data. You should use something line "n1" "n2" and "n3" for numbers.
Just a suggestion.

[Robert98]

Robert you will find the Lispers usually use variable names "x" "y" and "z" for processing
point data. You should use something line "n1" "n2" and "n3" for numbers.
Just a suggestion.

Dear CAB, that's a good idea and I'll use it at my future codes.
special thanks to all members that helped me.