Topic: ResbufList class

[gswang]

命令: (resbuf_remove 1 2 3 4 5)
(1 2 3 4 5)     ；Not what i want.

   static int ads_resbuf_remove(void)
   {
      ResbufList _list = acedGetArgs();

      ResbufList args = _list;
      ResbufList_iterator iter = args.begin();

      int i = 0;
      for(; iter != args.end(); ++iter)
      {
         if (i == 1)
            _list.remove(const_cast<resbuf*>(&(*iter)));

         i++;
      }
      
      acedRetList(_list);

      return (RSRSLT);
   }

[It's Alive!]

Ah! I see the problem I will fix it tonight

[gswang]

Thank you Daniel, recently busy, right?

[It's Alive!]

Try it now 

Code: [Select]

// (rbtest 1 2 3 4 5 6 7 8 9 0)
  static int ads_rbtest(void)
   {
      ResbufList args = acedGetArgs();

      //added this
      args.removeAt(1);

      ResbufList_iterator iter = args.begin();
      int i = 0;
      for(; iter != args.end(); ++iter)
      {
        if (i == 1)
             args.remove(iter);
         i++;
      }
      acedRetList (args);
      return (RSRSLT);
   }


[It's Alive!]

BTY, I changed a couple of function names  :whistle:

[Kerry]

BTY, I changed a couple of function names  :whistle:

.. and here's the documentation

[It's Alive!]

I know, I know.... but I did comment the code (a little) 

[It's Alive!]

I changed push_back(resbuf*)  to only accept a single node (for performance) and added  append_front(resbuf*) and append_back(resbuf*)  for chains.

[Kerry]

I know, I know.... but I did comment the code (a little) 

It's cool Daniel ... I'm just stirring 

[gswang]

 :?The push_back function could not work correctly!
ResbufList returnBuffer;
for(size_t idx =0; idx<points.length(); idx++)
{
resbuf *pTmp = acutNewRb(RT3DPOINT);
pTmp->resval.rpoint[0] = points[idx].x;
pTmp->resval.rpoint[1] = points[idx].y;
pTmp->resval.rpoint[2] = points[idx].z;
returnBuffer.push_back(pTmp);
}

[It's Alive!]

fixed, try it now

[frtfff]

 

[It's Alive!]

why the long face?

[pkohut]

A year after the comments and I finally get to take at look at the changes you made. Looks good Daniel.

Code: [Select]

inline ResbufList_iterator ResbufList::begin()
{
  return (mpHead == NULL ? NULL : mpHead);
}
Compiler will probably optimize to:
   return mpHead;
but if not then it's a wasted if statement.


The loops structures in ResbufList::at and ResbufList::removeAt can become -

Code: [Select]

ResbufList_iterator ResbufList::at( const size_t idx )
{ 
  for(size_t nItems = 0, resbuf *pRbTemp = mpHead ; pRbTemp != NULL ; pRbTemp = pRbTemp->rbnext, ++nItems)
  {
    if(idx == nItems)
      return pRbTemp;
  }
  return NULL;
}


[frtfff]

Good code,but I don't know how to use.