Topic: ( Challenge ) How fast can you convert these?

[Kerry]

Command: Test4
Ellapsed time: 0.0625 seconds

This had me a little excited till I realised that all the points were already converted to circles

[CAB]

Stumbled across this:

[Kerry]

hey, Alan ... don't just sit there with an enigmatic smile on your face ; tell us the story

[CAB]

I was trying to run down some info on reactors & stumbled into this in my library.

See pages 27+

[Kerry]

Thanks Alan.

[It's Alive!]

Great stuff, Thanks Cab

[CAB]

Right place at the right time.
Still looking for more material on vLisp Object Reactors. All I've found are simple examples.

[Spike Wilbury]

Here is my stab.-

Total run time: 0.078 seconds

(if I removed those lines marked with total run time)

Code: [Select]

static void PointsToCircles(void)
{
CLapseTime ltTotal;
AcDbBlockTableRecordPointer pBTR(acdbCurDwg()->currentSpaceId(), AcDb::kForWrite);
if (pBTR.openStatus() != Acad::eOk) return;
AcDbBlockTableRecordIterator* pIterator = NULL;
if (pBTR->newIterator(pIterator) != Acad::eOk) return;
for (pIterator->start(); !pIterator->done(); pIterator->step())
{
AcDbObjectId objId;
pIterator->getEntityId(objId);
//if (pIterator->getEntityId(objId) != Acad::eOk) return; // Total run time: 0.125 seconds
AcDbObjectPointer<AcDbPoint> pPoint(objId, AcDb::kForRead);
if(pPoint.openStatus() == Acad::eOk)
{
AcDbCircle *pCircle = new AcDbCircle(pPoint->position(), pPoint->normal(), 1.0);
if (pCircle && pBTR->appendAcDbEntity(pCircle) == Acad::eOk)
{
pCircle->close(); // Total run time: 0.078 seconds

pPoint->upgradeOpen(); // Total run time: 0.109 seconds
pPoint->erase();
}
else
delete pCircle; // Total run time: 0.094 seconds
}
}
delete pIterator;
acutPrintf(_T("\nTotal run time: %.3f seconds"), ltTotal.LapseTimeSeconds());
}


[Spike Wilbury]

Here is my stab.-

Total run time: 0.078 seconds

(if I removed those lines marked with total run time)

Code: [Select]

static void PointsToCircles(void)
{
CLapseTime ltTotal;
AcDbBlockTableRecordPointer pBTR(acdbCurDwg()->currentSpaceId(), AcDb::kForWrite);
if (pBTR.openStatus() != Acad::eOk) return;
AcDbBlockTableRecordIterator* pIterator = NULL;
if (pBTR->newIterator(pIterator) != Acad::eOk) return;
for (pIterator->start(); !pIterator->done(); pIterator->step())
{
AcDbObjectId objId;
pIterator->getEntityId(objId);
//if (pIterator->getEntityId(objId) != Acad::eOk) return; // Total run time: 0.125 seconds
AcDbObjectPointer<AcDbPoint> pPoint(objId, AcDb::kForRead);
if(pPoint.openStatus() == Acad::eOk)
{
AcDbCircle *pCircle = new AcDbCircle(pPoint->position(), pPoint->normal(), 1.0);
if (pCircle && pBTR->appendAcDbEntity(pCircle) == Acad::eOk)
{
pCircle->close(); // Total run time: 0.078 seconds

pPoint->upgradeOpen(); // Total run time: 0.109 seconds
pPoint->erase();
}
else
delete pCircle; // Total run time: 0.094 seconds
}
}
delete pIterator;
acutPrintf(_T("\nTotal run time: %.3f seconds"), ltTotal.LapseTimeSeconds());
}


But, after running Paul code and including the erase of the point - his approach takes the same 0.094 seconds vs. 0.125 seconds ==== 0.031 dif.


Was a great excercise !

[gile]

I make advantage of this challenge to keep on learning C# (even it's a LISP forum, sorry CAB).
I tried a way using a selection set rather than scanning all database, it seems to be a little faster (0.5 on my system).
Thanks to Kerry for all the nice little tricks he shows me.

Code: [Select]

using System;
using Autodesk.AutoCAD.ApplicationServices;
using Autodesk.AutoCAD.DatabaseServices;
using Autodesk.AutoCAD.EditorInput;
using Autodesk.AutoCAD.Runtime;

namespace Point2Circle
{
    public class MyClass
    {
        [CommandMethod("Test2")]
        public void Test2()
        {
            DateTime start = DateTime.Now;
            Editor ed = Application.DocumentManager.MdiActiveDocument.Editor;
            Database db = HostApplicationServices.WorkingDatabase;
            TypedValue[] tValues = { new TypedValue((int)DxfCode.Start, "POINT") };
            SelectionFilter selFilter = new SelectionFilter(tValues);
            PromptSelectionResult result = ed.SelectAll(selFilter);
            if (result.Status == PromptStatus.OK)
            {
                ObjectId[] selSet = result.Value.GetObjectIds();
                using (Transaction tr = db.TransactionManager.StartTransaction())
                {
                    BlockTable bt = (BlockTable)tr.GetObject(db.BlockTableId, OpenMode.ForRead);
                    BlockTableRecord btr = (BlockTableRecord)tr.GetObject(bt[BlockTableRecord.ModelSpace], OpenMode.ForWrite);
                    foreach (ObjectId objId in selSet)
                    {
                        DBPoint pt = tr.GetObject(objId, OpenMode.ForWrite) as DBPoint;
                        if (pt != null)
                        {
                            Circle c = new Circle(pt.Position, pt.Normal, 15.0);
                            pt.Erase();
                            btr.AppendEntity(c);
                            tr.AddNewlyCreatedDBObject(c, true);
                        }
                    }
                    tr.Commit();
                    TimeSpan time = (DateTime.Now - start);
                    ed.WriteMessage("Elapsed time: {0} seconds", (time.TotalSeconds));
                }
            }
        }
    }
}

[CAB]

I'm just jealous of your multilingual programmers.

[gile]

I'm very very much comfortable with LISP

Here's a little comparative between foreach, mapcar, repeat and while statements.

Commande: TEST_FOREACH
 < Elapsed time: 1.188000 seconds. >

Commande: TEST_MAPCAR
 < Elapsed time: 1.172000 seconds. >

Commande: TEST_REPEAT
 < Elapsed time: 1.140000 seconds. >

Commande: TEST_WHILE
 < Elapsed time: 1.125000 seconds. >

Code: [Select]

(defun c:test_foreach (/ time ss)
  (setq time (getvar 'millisecs))
  (and
    (setq ss (ssget "x" '((0 . "point"))))
    (foreach p (ssnamex ss)
      (entmakex
(list
  (cons 0 "CIRCLE")
  (assoc 10 (entget (cadr p)))
  (cons 40 15.0)
)
      )
      (entdel (cadr p))
    )
  )
  (princ
    (strcat "\n < Elapsed time: "
    (rtos (/ (- (getvar 'millisecs) time) 1000.0) 2 6)
    " seconds. > "
    )
  )
  (princ)
)

(defun c:test_mapcar (/ time ss)
  (setq time (getvar 'millisecs))
  (and (setq ss (ssget "_X" '((0 . "POINT"))))
       (mapcar '(lambda (x)
  (entmakex
    (list
      '(0 . "CIRCLE")
      (assoc 10 (entget (cadr x)))
      '(40 . 15.)
    )
  )
  (entdel (cadr x))
)
       (ssnamex ss)
       )
  )
  (princ
    (strcat "\n < Elapsed time: "
    (rtos (/ (- (getvar 'millisecs) time) 1000.0) 2 6)
    " seconds. > "
    )
  )
  (princ)
)

(defun c:test_repeat (/ time ss n pt)
  (setq time (getvar 'millisecs))
  (and
    (setq ss (ssget "x" '((0 . "POINT"))))
    (repeat (setq n (sslength ss))
      (setq pt (ssname ss (setq n (1- n))))
      (entmakex
(list
  (cons 0 "CIRCLE")
  (assoc 10 (entget pt))
  (cons 40 15.0)
)
      )
      (entdel pt)
    )
  )
  (princ
    (strcat "\n < Elapsed time: "
    (rtos (/ (- (getvar 'millisecs) time) 1000.0) 2 6)
    " seconds. > "
    )
  )
  (princ)
)

(defun c:test_while (/ time ss n pt)
  (setq time (getvar 'millisecs))
  (and (setq ss (ssget "_X" '((0 . "POINT"))))
       (setq n -1)
       (while (setq pt (ssname ss (setq n (1+ n))))
(entmakex
   (list
     '(0 . "CIRCLE")
     (assoc 10 (entget pt))
     '(40 . 15.)
   )
)
(entdel pt)
       )
  )
  (princ
    (strcat "\n < Elapsed time: "
    (rtos (/ (- (getvar 'millisecs) time) 1000.0) 2 6)
    " seconds. > "
    )
  )
  (princ)
)

[ronjonp]

Another variant for mapcar    < Elapsed time: 1.031000 seconds. >

Code: [Select]

(defun c:test_mapcar (/ time addcircle)

  (defun addcircle (e /)
    (entmakex (list
'(0 . "CIRCLE")
(assoc 10 (entget e))
'(40 . 15.)
      )
    )
    (entdel e)
  )

  (setq time (getvar 'millisecs))
  (mapcar 'addcircle
  (mapcar 'cadr (ssnamex (ssget "_X" '((0 . "POINT")))))
  )
  (princ
    (strcat "\n < Elapsed time: "
    (rtos (/ (- (getvar 'millisecs) time) 1000.0) 2 6)
    " seconds. > "
    )
  )
  (princ)
)

[It's Alive!]

Duration: 0.586035376004492 sec   

Code: [Select]

using Autodesk.AutoCAD.Runtime;
using Autodesk.AutoCAD.EditorInput;
using Autodesk.AutoCAD.DatabaseServices;

using AcAp = Autodesk.AutoCAD.ApplicationServices;
using AcDb = Autodesk.AutoCAD.DatabaseServices;

[assembly: CommandClass(typeof(ExecMethod.Commands))]
//++--
namespace ExecMethod
{
  public class Commands
  {
    [CommandMethod("doit")]
    public static void doit()
    {
      HiPerfTimer pt = new HiPerfTimer();
      pt.Start();
      Editor ed = AcAp.Application.DocumentManager.MdiActiveDocument.Editor;
      Database db = AcDb.HostApplicationServices.WorkingDatabase;
      AcDb.TransactionManager tm = db.TransactionManager;
      try
      {
        using (Transaction tr = tm.StartTransaction())
        {
          BlockTableRecord blockTableRecord =
            tr.GetObject(SymbolUtilityServices.GetBlockModelSpaceId(db),
                OpenMode.ForWrite) as BlockTableRecord;

          foreach (ObjectId entId in blockTableRecord)
          {
            DBPoint point = tr.GetObject
              (entId, OpenMode.ForWrite, false) as DBPoint;

            if (point != null)
            {
              Circle c = new Circle(point.Position, point.Normal, 15.0);
              blockTableRecord.AppendEntity(c);
              tr.AddNewlyCreatedDBObject(c, true);
              point.Erase();
            }
          }
          tr.Commit();
        }
        pt.Stop();
        ed.WriteMessage("Duration: {0} sec\n", pt.Duration);
      }
      catch (System.Exception ex)
      {
        ed.WriteMessage(ex.Message);
        ed.WriteMessage(ex.StackTrace);
      }
    }
  }
}


[ronjonp]

Duration: 0.586035376004492 sec   

Code: [Select]

using Autodesk.AutoCAD.Runtime;
using Autodesk.AutoCAD.EditorInput;
using Autodesk.AutoCAD.DatabaseServices;

using AcAp = Autodesk.AutoCAD.ApplicationServices;
using AcDb = Autodesk.AutoCAD.DatabaseServices;

[assembly: CommandClass(typeof(ExecMethod.Commands))]
//++--
namespace ExecMethod
{
  public class Commands
  {
    [CommandMethod("doit")]
    public static void doit()
    {
      HiPerfTimer pt = new HiPerfTimer();
      pt.Start();
      Editor ed = AcAp.Application.DocumentManager.MdiActiveDocument.Editor;
      Database db = AcDb.HostApplicationServices.WorkingDatabase;
      AcDb.TransactionManager tm = db.TransactionManager;
      try
      {
        using (Transaction tr = tm.StartTransaction())
        {
          BlockTableRecord blockTableRecord =
            tr.GetObject(SymbolUtilityServices.GetBlockModelSpaceId(db),
                OpenMode.ForWrite) as BlockTableRecord;

          foreach (ObjectId entId in blockTableRecord)
          {
            DBPoint point = tr.GetObject
              (entId, OpenMode.ForWrite, false) as DBPoint;

            if (point != null)
            {
              Circle c = new Circle(point.Position, point.Normal, 15.0);
              blockTableRecord.AppendEntity(c);
              tr.AddNewlyCreatedDBObject(c, true);
              point.Erase();
            }
          }
          tr.Commit();
        }
        pt.Stop();
        ed.WriteMessage("Duration: {0} sec\n", pt.Duration);
      }
      catch (System.Exception ex)
      {
        ed.WriteMessage(ex.Message);
        ed.WriteMessage(ex.StackTrace);
      }
    }
  }
}


Cheater...that's like bringing a gun to a knife fight