Topic: Intermediate Challenge - Building Outline

[CAB]

The challenge is to write a lisp that would create a building outline from user input of the keyboard only.
The idea is to limit the keystrokes needed.
Here is some pseudo code I dreamed up, your may vary.
Extra credit if there is an UNDO key.

Code: [Select]

1 - Option for lines or plines
2 - Get start point
3 - Get direction, numeric keypad or arrow keys
       numbers 1 7 9 3 = 45 degree lines
       else if ENTER then quit.
4 - Get distance, Feet then if dot key get decimal feet
      else if space bar or zero or minus key then get inches
      else if ENTER end of distance
5 - Repeat 3 and 4
The thread that spawned the idea.
http://www.theswamp.org/index.php?topic=22794.0

[alanjt]

do you think you should link the thread where this all started so everyone can have a little something to work with?

[T.Willey]

Here you go.  Could be better, but it is cool for now.   

Code: [Select]

(defun c:Challenge (/ Pt PtList Ang Dist EntryStr Pos GrVecList PlObj)
   
    (if
        (and
            (setq Pt (getpoint "\n Select starting point: "))
            (setq PtList
                (cons
                    (cadr Pt)
                    (cons
                        (car Pt)
                        PtList
                    )
                )
            )
            (setq GrVecList (list Pt 1))
        )
        (while (/= (setq EntryStr (getstring "\n Enter direction and distance [ie. 825 = 90 degrees at 25 feet]: ")) "")
            (setq Ang (substr EntryStr 1 1))
            (setq Dist (substr EntryStr 2))
            (setq Ang
                (cond
                    ((= Ang "1")
                        (+ pi (* pi 0.25))
                    )
                    ((= Ang "2")
                        (+ pi (* pi 0.5))
                    )
                    ((= Ang "3")
                        (+ pi (* pi 0.75))
                    )
                    ((= Ang "4")
                        pi
                    )
                    ((= Ang "6")
                        0.0
                    )
                    ((= Ang "7")
                        (* pi 0.75)
                    )
                    ((= Ang "8")
                        (* pi 0.5)
                    )
                    ((= Ang "9")
                        (* pi 0.25)
                    )
                )
            )
            (setq Dist
                (cond
                    ((setq Pos (vl-string-search "." Dist))
                        (+
                            (* 12 (distof (substr Dist 1 Pos)))
                            (* (distof (substr Dist (1+ Pos))) 12)
                        )
                    )
                    ((setq Pos (vl-string-search "-" Dist))
                        (+
                            (* 12 (distof (substr Dist 1 Pos)))
                            (distof (substr Dist (+ 2 Pos)))
                        )
                    )
                    (t (* 12 (distof Dist)))
                )
            )
            (setq GrVecList
                (cons
                    (setq Pt (polar Pt Ang Dist))
                    (cons
                        1
                        (cons
                            Pt
                            GrVecList
                        )
                    )
                )
            )
            (setq PtList
                (cons
                    (cadr Pt)
                    (cons
                        (car Pt)
                        PtList
                    )
                )
            )
            (grvecs (reverse (cddr GrVecList)))
        )
    )
    (if (> (length PtList) 2)
        (setq PlObj
            (vlax-invoke
                (vlax-get
                    (vla-get-ActiveDocument (vlax-get-Acad-Object))
                    (if (equal (getvar 'CVPort) 1)
                        'PaperSpace
                        'ModelSpace
                    )
                )
                'AddLightWeightPolyline
                (reverse PtList)
            )
        )
    )
    (if
        (=
            (progn
                (initget "Line Polyline")
                (getkword "\n New object should be [Line/Polyline] <Polyline>: ")
            )
            "Line"
        )
        (progn
            (vlax-invoke PlObj 'Explode)
            (vla-Delete PlObj)
        )
    )
    (redraw)
    (princ)
)


[CAB]

Tim, Nicely done and works well.
Only comment is if you pan or zoom the vectors are lost.

[alanjt]

that's awesome tim!
i can't believe how this is turning out.

i did notice that if you type in an invalid string (ie: 2) then it just ends and you don't get anything.

[T.Willey]

Tim, Nicely done and works well.
Only comment is if you pan or zoom the vectors are lost.

Thanks Alan.  Yea I know about the changing the view thingy, but will let someone else solve that.  But it should redraw with each new element entered.

that's awesome tim!
i can't believe how this is turning out.

i did notice that if you type in an invalid string (ie: 2) then it just ends and you don't get anything.

Thanks.  Yea there is no error checking, but this is a proof of idea.  This is open for others to build upon, and I think I wrote it in a fashion that people could add to it simply.  Well I hope I did. 

[Dinosaur]

What would have to be done to this to make it work in foot units to two decimal places ie. 24.68'?  One of our more tedious tasks is to take an architectural foundation plan and draw a footprint in decimal feet for a site plan.  We waste a large chunk of time converting units, offsetting and filleting.  I am sure something like this would make it much less error prone and tedious.

[CAB]

Not a big deal, my routine addresses that.
As Tim said his routine addresses the basic requirements and others may build upon it.

I can't post mine as it isn't complete yet but here is where i am headed.

Code: [Select]

    ;;  decode distance entry, where nn is a number key
    ;;  Although UNITS are set to Inches in the Drawing the User
    ;;   Input is primarily in Feet and Inches but the following
    ;;   numeric input is allowable.
    ;;
    ;;  nn[ENTER] Feet
    ;;  nn.nn[ENTER] Feet & decimal feet
    ;;  nn-nn[ENTER] Feet & inches
    ;;  nn-nn.nn[ENTER] Feet & inches plus decimal inches
    ;;  nn-nn n/n[ENTER] Feet & inches plus fractional inches
    ;;  * and dir = 1 3 7 9 -> Triangle Mode, distance if of
    ;;     the right angle leg
    ;;  nn+ Inches
    ;;  nn.nn+ Inches & decimal inches
    ;;  nn n/n+ Inches & fractional inches
    ;;  C c Close polyline

[alanjt]

i know keith had a big part in this one, but here it is anyway:

Code: [Select]

(defun line_info(/ bear bldg_direction bldg_dist)
(princ "\n       7        8        9")
(princ "\n    (45°NW)    (UP)   (45°NE)")
(princ "\n       4                 6")
(princ "\n     (LEFT)           (RIGHT)")
(princ "\n       1        2        3")
(princ "\n    (45°SW)   (DOWN)  (45°SE)")
  (initget "1 2 3 4 6 7 8 9 Quit")
(setq bldg_direction (getkword "\nDirection (8=Up, 6=Right, 2=Down, 4=Left), <Quit>: "))
  (cond
  ((= bldg_direction "Quit")(setq bldg_direction nil))
  ((= bldg_direction "")(setq bldg_direction nil))
  ((= bldg_direction "6")(setq bldg_direction "0"))
  ((= bldg_direction "9")(setq bldg_direction "45"))
  ((= bldg_direction "8")(setq bldg_direction "90"))
  ((= bldg_direction "7")(setq bldg_direction "135"))
  ((= bldg_direction "4")(setq bldg_direction "180"))
  ((= bldg_direction "1")(setq bldg_direction "225"))
  ((= bldg_direction "2")(setq bldg_direction "270"))
  ((= bldg_direction "3")(setq bldg_direction "315"))
)
  (if (/= bldg_direction nil)
  (progn
     (setq bldg_dist (getdist "\nLengh of wall: "))
     (setq bear (strcat "@" (rtos bldg_dist) "<" bldg_direction))
  )
  (setq bear nil)
)
 
)

(defun c:bldg-draw( / begin_point bear)
(setq begin_point (getpoint "\nBeginning point for building: "))
(setq bear (line_info))
(command "line" begin_point bear)
  (while (setq bear (line_info))
  (command bear)
)
  (command)
(princ)
);defun


[CAB]

Good job Alan, you skills are improving.
I have some alternative code methods to show you but it will have to wait until tomorrow.

[T.Willey]

Here is another version that has more options, kind of like what Alan was suggesting.

Code: [Select]

(defun c:Challenge (/ Pt PtList Ang Dist EntryStr Pos- Pos. 2Pos- GrVecList PlObj StPt flag)
   
    (if
        (and
            (setq Pt (getpoint "\n Select starting point: "))
            (setq StPt Pt)
            (setq PtList
                (cons
                    (cadr Pt)
                    (cons
                        (car Pt)
                        PtList
                    )
                )
            )
            (setq GrVecList (list Pt 1))
        )
        (while
            (and
                (not flag)
                (not (initget 128 "Close Entry"))
                (setq EntryStr (getkword "\n Enter direction and distance [Close/Entry format]: "))
            )
            (cond
                ((= EntryStr "Close")
                    (setq PtList
                        (cons
                            (cadr StPt)
                            (cons
                                (car StPt)
                                PtList
                            )
                        )
                    )
                    (setq flag T)
                )
                ((= EntryStr "Entry")
                    (prompt
                        (strcat
                            "\nHow to correctly entry data."
                            "\nThe first number is the angle, based on the number pad:"
                            "\n 1 = 225"
                            "\n 2 = 270"
                            "\n 3 = 315"
                            "\n 4 = 180"
                            "\n 5 = Enter angle or pick angle on screen"
                            "\n 6 = 0"
                            "\n 7 = 135"
                            "\n 8 = 90"
                            "\n 9 = 45"
                            "\n"
                            "\nThe next numbers are the distance, and should be entered like:"
                            "\n nn = feet"
                            "\n nn.nn = feet plus decimal feet"
                            "\n nn-nn = feet plus inches"
                            "\n nn-nn.nn = feet plus inches plus decimal inches"
                            "\n nn-nn-n/n = feet plus inches plus a fraction of an inch"
                            "\n"
                            "\nSo a number entered 825-6 equals a line the length of 25'-6\" at 90 degrees from the last point."
                        )
                    )
                    (textscr)
                )
                ((> (strlen EntryStr) 1)
                    (setq Ang (substr EntryStr 1 1))
                    (setq Dist (substr EntryStr 2))
                    (setq Ang
                        (cond
                            ((= Ang "1")
                                (+ pi (* pi 0.25))
                            )
                            ((= Ang "2")
                                (+ pi (* pi 0.5))
                            )
                            ((= Ang "3")
                                (+ pi (* pi 0.75))
                            )
                            ((= Ang "4")
                                pi
                            )
                            ((= Ang "5")
                                (getangle "\n Enter desired angle: ")
                            )
                            ((= Ang "6")
                                0.0
                            )
                            ((= Ang "7")
                                (* pi 0.75)
                            )
                            ((= Ang "8")
                                (* pi 0.5)
                            )
                            ((= Ang "9")
                                (* pi 0.25)
                            )
                            (t nil)
                        )
                    )
                    (setq Dist
                        (cond
                            (
                                (and
                                    (setq Pos- (vl-string-search "-" Dist))
                                    (setq Pos. (vl-string-search "." Dist Pos-))
                                )
                                (+
                                    (* 12 (distof (substr Dist 1 Pos-)))
                                    (distof (substr Dist (+ 2 Pos-) (1- (- Pos. Pos-))))
                                    (distof (substr Dist (1+ Pos.)))
                                )
                            )
                            (
                                (and
                                    (setq Pos- (vl-string-search "-" Dist))
                                    (setq 2Pos- (vl-string-search "-" Dist (1+ Pos-)))
                                    (vl-string-search "/" Dist 2Pos-)
                                )
                                (+
                                    (* 12 (distof (substr Dist 1 Pos-)))
                                    (distof (substr Dist (+ 2 Pos-) (1- (- 2Pos- Pos-))))
                                    (distof (substr Dist (+ 2 2Pos-)))
                                )
                            )
                            ((setq Pos. (vl-string-search "." Dist))
                                (+
                                    (* 12 (distof (substr Dist 1 Pos.)))
                                    (* (distof (substr Dist (1+ Pos.))) 12)
                                )
                            )
                            ((setq Pos- (vl-string-search "-" Dist))
                                (+
                                    (* 12 (distof (substr Dist 1 Pos-)))
                                    (distof (substr Dist (+ 2 Pos-)))
                                )
                            )
                            ((= Dist "")
                                nil
                            )
                            (t (* 12 (distof Dist)))
                        )
                    )
                    (if
                        (and
                            (= (type Ang) 'REAL)
                            (= (type Dist) 'REAL)
                        )
                        (progn
                            (setq GrVecList
                                (cons
                                    (setq Pt (polar Pt Ang Dist))
                                    (cons
                                        1
                                        (cons
                                            Pt
                                            GrVecList
                                        )
                                    )
                                )
                            )
                            (setq PtList
                                (cons
                                    (cadr Pt)
                                    (cons
                                        (car Pt)
                                        PtList
                                    )
                                )
                            )
                            (grvecs (reverse (cddr GrVecList)))
                        )
                    )
                )
            )
        )
    )
    (if (> (length PtList) 2)
        (setq PlObj
            (vlax-invoke
                (vlax-get
                    (vla-get-ActiveDocument (vlax-get-Acad-Object))
                    (if (equal (getvar 'CVPort) 1)
                        'PaperSpace
                        'ModelSpace
                    )
                )
                'AddLightWeightPolyline
                (reverse PtList)
            )
        )
    )
    (if
        (=
            (progn
                (initget "Line Polyline")
                (getkword "\n New object should be [Line/Polyline] <Polyline>: ")
            )
            "Line"
        )
        (progn
            (vlax-invoke PlObj 'Explode)
            (vla-Delete PlObj)
        )
    )
    (redraw)
    (princ)
)


[alanjt]

Code: [Select]

"\n 5 = Enter angle or pick angle on screen"
you completely read my mind, i was working on figuring that one out.

yours is beyond incredible!

[T.Willey]

Code: [Select]

"\n 5 = Enter angle or pick angle on screen"
you completely read my mind, i was working on figuring that one out.

Thought that might be wanted.  I think I would use it.

yours is beyond incredible!

Thanks.  Years of practice, and still learning, but you are in the right spot to learn, and seems like you have the right attitude for it, so I'm guessing it won't take you long.

[GDF]

Similar...here is one to draw with bearing info. Just modify the code for direction in lieu of bearing.
Nice dialog box interface.

Cadalyst Get the Code! Browseby Joon Hong, p.68 LL.LSP and LL2.DCL help you quickly draw bearing lines. The list box in the dialog stores a list of the lines you've input for reuse. ...
new.cadalyst.com/code/browseyear.cfm?fullyear=2002 - 55k - Cached - Similar pages

[alanjt]

Code: [Select]

"\n 5 = Enter angle or pick angle on screen"
you completely read my mind, i was working on figuring that one out.

Thought that might be wanted.  I think I would use it.

yours is beyond incredible!

Thanks.  Years of practice, and still learning, but you are in the right spot to learn, and seems like you have the right attitude for it, so I'm guessing it won't take you long.

yeah, i only started learing lisp in my free time about 8-9 months ago.
most of mine are simple, but they are improving.

i can't believe how much i've learned since i came here.

[CAB]

OK this is a rough draft with limited testing.
<edit: added UNITS detection for Feet or Inches>
<edit: added more comments, added to Help, changed keys to string, added ability to change Line Mode at any prompt.>
<edit: added error handler>
ESCAPE will result in the elimination of lines drawn.

[Dinosaur]

Unless I am missing something, this still scales everything up 12 when the drawing is in decimal units.  On reflection, just using it as is and scaling down when finished may be better than doing it within the routine as we get some rounding weirdness converting to 2 decimal places from arch., especially when fractions get involved.  Otherwise, this seems to work quite well after I finally read the input instructions.

[CAB]

Glad it worked for you. My intent was to provide input flexability with a minimum of key strokes.
I work in ACAD with inches as my primary unit of measure but entering foundation from a hand drawn plan I need feet and don't want to have to enter the foot and inch marks. This works well for me. I assume from you comments that you use feet as your units?

Keep in mind that this is my first draft & only two other have contributeted to the thread.
I got some good ideas from Tim's work as my original thought was to get the distance & options via grread.
The 5 key for angle is a good one.

As for the Units, I might add some code to detect the DWG units & compensate for that in the calculations.

PS I need to add an error routine to clean up any line left behind if the user Escapes.

[Dinosaur]

Yes, decimal units with the drawing set to feet - no choice as our design software needs that to work.  I can't even enter a distance in foot and inch format.  I have to convert them to decimal first and if the distances are strange enough, the numbers don't close even when the line work does.  What complicates things more is my program will add a length label as a connected element to each segment and won't allow any fudge factor unless I make a special expression or hold my nose make the number manually.  I prefer to keep it in the program in because if the building moves, mirrors or rotates the lengths follow along and reposition automatically.  Yes, I am very spoiled and lazy.

[CAB]

What is your INSUNITS set to? 2 perhaps?

OK revised the code above to detect  Feet or Inches from INSUNITS.
You should be able to use fractions now.

[litss]

Nice routine, CAB!

One suggestion:

Would it be better to combine the "Pick Direction" part with the "Enter direction and distance [825=90 deg for 25'/Help/Undo]" part by using the "getpoint" function instead of the "getstring". We can input pre-defined direction by keyboard like 45,90 ect. At the same time, we can also use mouse to pick a special direction at any time needed. As to the key "5", I suggest, it could be use as the trigger for special direction input. We could input special num, like "536-6000". Here, "5" means special direction input triggered, "36" means the direction of line, "6000" means the length of line. You might need a "-" to seperate direction and length in case of mistreating special direction like "37.5", "97.52" or "185" ect.

This way, the input might be more easy, would it?

[Dinosaur]

What is your INSUNITS set to? 2 perhaps?

OK revised the code above to detect  Feet or Inches from INSUNITS.
You should be able to use fractions now.

I still have insunits set to 0 because of a bunch of old blocks and older drawings containing them, but this works perfectly with it set to 0 as well.  Thanks for the addition . . . there will be fewer blasphemous words issued for architects and their drawings from our office henceforth.

[CAB]

litss,
Glad you like the routine and thanks for your suggestion.
My thought is that the User angle [5] would seldom be used, so I can't get excited about improving it beyond its present functionality.

[CAB]

Stephen,
Glad it is going to be a useful lisp for you.

[alanjt]

man Alan, i never thought this routine would get to this point. i was happy when keith helped me with my conditions, but this...is...AWESOME.

thanks so much

[CAB]

Thanks Alan.

Just updated the code
added more comments
added to Help
changed keys to string for readability
added ability to changed Line Mode at any prompt

[Krushert]

CAB,
Another keeper

SWeeet!

[T.Willey]

I finally had a chance to test it, nice work Alan.  I think you did a good job, and I don't think I need to compete anymore.  :kewl:

[CAB]

Thanks Ted.

Tim,
I just had more time to invest in this LISP and did nothing that you wouldn't had you had the time.

[CAB]

One more update, added error handler
ESCAPE will result in the elimination of lines drawn.

Code is here:
http://www.theswamp.org/index.php?topic=22796.msg274577#msg274577