Topic: Creating new layer with plot styles

[mcarson]

Seem to have a few issues adding named plot style to a new layer on creation.

Code: [Select]

/// <summary>
/// Creates a new layer
/// </summary>
/// <param name="layerName"></param>
/// <param name="layerColor"></param>
/// <param name="lineweightName"></param>
/// <param name="plotstyleName"></param>
/// <param name="linetypeName"></param>
/// <returns></returns>
/// <remarks>Attempts to avoid the erased objectid API bug</remarks>
public ObjectId CreateLayer(string layerName, short layerColor, LineWeight lineweightName, string plotstyleName)
{
   
    //Create objectid varaible for layer
    ObjectId layerId;
    //Get the current database
    Database db = HostApplicationServices.WorkingDatabase;
   
    //Start the transaction manager with a new write transaction
    using (Transaction tr = db.TransactionManager.StartTransaction()) {
        //Get layer table from database
        LayerTable lt = (LayerTable)tr.GetObject(db.LayerTableId, OpenMode.ForWrite);
        //Check if layer exists
        if (lt.Has(layerName)) {
            //Return the existing layer
            layerId = lt(layerName);
            if (layerId.IsErased) {
                //OK, layer has been purged in the current drawing session,
                //We do NOT want to use the layer in it's current state
                //Set a new layer record and change the status of the erased
                //layer to false
                LayerTableRecord ltr = (LayerTableRecord)tr.GetObject(layerId, OpenMode.ForWrite, true);
                ltr.Erase(false);
                //return the layer record
                layerId = ltr.Id;
            }
        }
        else {
            //the layer has never existed in the current drawing
            //For test purposes, we are only allowing colors from 1 to 255
            if (layerColor > 255) {
                Layers.PrintToCmdLine(string.Format("" + Strings.Chr(10) + " ERROR: Could not use LayerColor \"{0}\", using 0 instead.", layerColor));
                layerColor = 0;
            }
           
            //Create new layer record
            LayerTableRecord ltr = new LayerTableRecord();
            //Set the name for the new record
            ltr.Name = layerName;
            //Set the color for the new record
            ltr.Color = Autodesk.AutoCAD.Colors.Color.FromColorIndex(ColorMethod.ByAci, layerColor);
            //Set the layer default lineweight
            ltr.LineWeight = lineweightName;
            //Set the plot style for the layer
            //--------------- Crashes here...
            ltr.PlotStyleName = "Color_7"
            //Add the layer record and get the objectid
            layerId = lt.Add(ltr);
            //Add the layer to the database
            tr.AddNewlyCreatedDBObject(ltr, true);
        }
        //Commit the transaction
        tr.Commit();
    }
    //Return the object id so we can make changes if needed
    return layerId;
}
I sorta know why it's breaking - the current drawing does not use named plot styles.

Now, for the real problem:

How do I convertpstyles and convertctb in .NET code?

[mcarson]

For an update:

I have not found a method to complete this task in .NET, however as a workaround I am first checking the pstylemode variable.

Code: [Select]

/// <summary>
/// Indicates whether the current drawing is in a Color-Dependent or Named Plot Style mode.
/// </summary>
/// <returns>0: Uses named plot style tables in the current drawing
///1: Uses color-dependent plot style tables in the current drawing</returns>
/// <remarks></remarks>
public bool PlotStyleMode()
{
    bool result = false;
    if (Convert.ToInt32(AcadApp.GetSystemVariable("pstylemode")) == 1) {
        result = true;
    }
    return result;
}
If named plot styles are being used in the current drawing, I can set the plot style per layer. If not, ignore the setting and continue

[It's Alive!]

Nice work Mark, and welcome to the Swamp! 

[mcarson]

Another update:
This is really starting to get to me;
I compiled and loaded the functions into AutoCAD and guess what? another error eNoDatabase 

Right, so I am guessing when this is because I have no plotstyle with this name. Changed it to "Black" - same error
I added another function to add my plot style table file to the layout

Code: [Select]

/// <summary>
/// Adds a plot style to the current layout and sets it current
/// </summary>
/// <param name="strPlotStyleName"></param>
/// <remarks></remarks>
public void AddPlotStyle(string strPlotStyleName)
{
    Database db = HostApplicationServices.WorkingDatabase;
    LayoutManager lm = LayoutManager.Current;
    using (Transaction tr = db.TransactionManager.StartTransaction()) {
       
        PlotSettingsValidator psv = PlotSettingsValidator.Current;
        Layout layout = (Layout)tr.GetObject(lm.GetLayoutId(lm.CurrentLayout), OpenMode.ForWrite);
        psv.SetCurrentStyleSheet(layout, strPlotStyleName);
        tr.Commit();
    }
}
Same error.

Can anyone point me in the right direction?

[It's Alive!]

I’ll try and point you somewhere, I don’t know if it’s the right direction though. 
According to the docs, the layer should already be added to the database before you screw with it.

Check this out

Code: [Select]

//Hi Kerry :)
using AcAp = Autodesk.AutoCAD.ApplicationServices;
using AcEd = Autodesk.AutoCAD.EditorInput;
using AcGe = Autodesk.AutoCAD.Geometry;
using AcRx = Autodesk.AutoCAD.Runtime;
using AcDb = Autodesk.AutoCAD.DatabaseServices;
using AcWd = Autodesk.AutoCAD.Windows;
#endregion

[assembly: CommandClass(typeof(ExecMethod.Commands))]

namespace ExecMethod
{
  public class Commands
  {
    public ObjectId CreateLayer(string layerName, short layerColor, LineWeight lineweightName)
    {
      Editor ed = AcAp.Application.DocumentManager.MdiActiveDocument.Editor;
      ObjectId layerId = ObjectId.Null;
      Database db = HostApplicationServices.WorkingDatabase;
      try
      {
        using (Transaction tr = db.TransactionManager.StartTransaction())
        {
          LayerTable lt = (LayerTable)tr.GetObject(db.LayerTableId, OpenMode.ForWrite);
          if (lt.Has(layerName))
          {
            layerId = lt[layerName];
            if (layerId.IsErased)
            {
              LayerTableRecord ltr = (LayerTableRecord)tr.GetObject(layerId, OpenMode.ForWrite, true);
              ltr.Erase(false);
              layerId = ltr.Id;
            }
          }
          else
          {
            if (layerColor > 255)
            {
              ed.WriteMessage(string.Format(" ERROR: Could not use LayerColor \"{0}\", using 0 instead.", layerColor));
              layerColor = 0;
            }
            LayerTableRecord ltr = new LayerTableRecord();
            ltr.Name = layerName;
            ltr.Color = Autodesk.AutoCAD.Colors.Color.FromColorIndex(ColorMethod.ByAci, layerColor);
            ltr.LineWeight = lineweightName;
            layerId = lt.Add(ltr);
            tr.AddNewlyCreatedDBObject(ltr, true);
          }
          tr.Commit();
        }
      }
      catch (System.Exception ex)
      {
        ed.WriteMessage(ex.StackTrace);
      }
      return layerId;
    }

    public void AddPlotStyle(ObjectId id, string strPlotStyleName)
    {
      Database db = HostApplicationServices.WorkingDatabase;
      Editor ed = AcAp.Application.DocumentManager.MdiActiveDocument.Editor;
      if (db.PlotStyleMode == false)
      {
        using (Transaction tr = db.TransactionManager.StartTransaction())
        {
          DictionaryWithDefaultDictionary d =
            (DictionaryWithDefaultDictionary)tr.GetObject
                (db.PlotStyleNameDictionaryId, OpenMode.ForRead);

          LayerTableRecord ltr =
               (LayerTableRecord)tr.GetObject(id, OpenMode.ForWrite);

          ltr.PlotStyleNameId = d.GetAt(strPlotStyleName);
          tr.Commit();
        }
      }
    }

    [CommandMethod("doit")]
    public void doit()
    {
      AddPlotStyle(this.CreateLayer("Daniel", 7, LineWeight.ByLayer), "Normal");
    }
  }
}




[It's Alive!]

Sorry, I’m an idiot, It still crashes 

[sinc]

I couldn't get it to work, either, when I tried setting the PlotStyleName.  Instead, I set the PlotStyleNameId.

There is working code for this in the AcadUtilities library available for download from Quux Software.  The solution actually contains three projects, and two of them only work in Civil-3D.  But the AcadUtilities project should work in any version of Autocad (at least 2008, don't know about earlier versions).

If you download that, you can drag-n-drop a "Select Plot Style" control onto your form, and you are pretty much done.  You also need to instantiate a "command parameter" to go along with it.  Take a look at the "CreateLayerForm" class to see how to use it.

[sinc]

Oh shoot, and it occurs to me I should probably test that code with CTBs.

STBs are so much better, I forget that a lot of people are still using CTBs.  But I think all I need to do is add code that disables the control if the drawing is using CTBs, since it doesn't apply to CTB drawings.

[MP]

If you want to create a bigger fan base Sinc write a "The Pragmatist's Guide to Intelligent Plotting Using CTBs or STBs", because it's needed and doesn't exist.

[sinc]

If you want to create a bigger fan base Sinc write a "The Pragmatist's Guide to Intelligent Plotting Using CTBs or STBs", because it's needed and doesn't exist.

It would start with "Forget CTBs ever existed..."   

[Kerry]

I've only ever used CTB's , so I can't help

[David Hall]

If you want to create a bigger fan base Sinc write a "The Pragmatist's Guide to Intelligent Plotting Using CTBs or STBs", because it's needed and doesn't exist.

It would start with "Forget CTBs ever existed..."  

And that would create the mayhem that plotting in 2000 started

[It's Alive!]

I tried again, but failed miserably (in ARX  too), my suggestion would be to reflect upon the built-in layer
dialog as it is managed and see if you can find the mojo. I might have a look later as well.

Off to Disneyland to see if I can get my daughter to “Space Ranger” status on the Buzz Lightyear ride. 

[mcarson]

This post has grown arms and legs!

It seems that it is not possible to assign a plot style name from a new inserted plot style table when no objects are using the plot style name.
i.e.
Open a new drawing

• Run the add plot style table function:

Code: [Select]

public void AddPlotStyleTable(string plotstyletableName)
{
    Database db = HostApplicationServices.WorkingDatabase;
    Editor ed = Application.DocumentManager.MdiActiveDocument.Editor;
    LayoutManager lm = LayoutManager.Current;
   
    try {
        ed.WriteMessage(Strings.ChrW(10) + "Starting transaction...");
        using (Transaction tr = db.TransactionManager.StartTransaction) {
            ed.WriteMessage(Strings.ChrW(10) + "Setting the psv to the current layout: " + lm.CurrentLayout);
            PlotSettingsValidator psv = PlotSettingsValidator.Current;
            Layout ly = (Layout)tr.GetObject(lm.GetLayoutId(lm.CurrentLayout), OpenMode.ForWrite);
            ed.WriteMessage(Strings.ChrW(10) + "Adding the plot style table");
            psv.SetCurrentStyleSheet(ly, plotstyletableName);
            tr.Commit();
        }
    }
    catch (Exception ex) {
        Interaction.MsgBox(ex.ToString);
    }
}
Adding a plot style table that exists in your support paths

• Add the posted solution by Daniel

Code: [Select]

public void doit()
{
    AddPlotStyleTable("test.stb");
    AddPlotStyle(CreateLayer("Test Layer", 1, LineWeight.LineWeight000), "Black");
}
The function fails eKeyNotFound
The plot style has yet to be assigned to an object, and is not in use (I guess)

Now try this..

• New AutoCAD session
• Add a line to model space
• Change the objects properties to use the Black plot style name in the test.stb
• Execute the program

Works now (or for me anyway)

We could try to add a line by code and assign the plot style name from the plot style table, but again will be facing the problem where the plot style name is not in use and therefore cannot be assigned.
A workaround could be to insert a block (one that has the plot style table attached and the plot style names in use) before the layer is created, then afterwards, delete and purge.
But this, in my opinion is not 'managed' .net development; the creation of a layer requires a block to be stored somewhere in the support paths?

[mcarson]

I've only ever used CTB's , so I can't help

The thing is, I am attempting to use both CTBs and STBs - both of which have similar issues.

[It's Alive!]

Try this 

Code: [Select]

//Hi Kerry :)
using AcAp = Autodesk.AutoCAD.ApplicationServices;
using AcEd = Autodesk.AutoCAD.EditorInput;
using AcGe = Autodesk.AutoCAD.Geometry;
using AcRx = Autodesk.AutoCAD.Runtime;
using AcDb = Autodesk.AutoCAD.DatabaseServices;
using AcWd = Autodesk.AutoCAD.Windows;
#endregion

[assembly: CommandClass(typeof(ExecMethod.Commands))]

namespace ExecMethod
{
  public class Commands
  {
    public ObjectId CreateLayer(string layerName, short layerColor, LineWeight lineweightName)
    {
      Editor ed = AcAp.Application.DocumentManager.MdiActiveDocument.Editor;
      ObjectId layerId = ObjectId.Null;
      Database db = HostApplicationServices.WorkingDatabase;

      using (Transaction tr = db.TransactionManager.StartTransaction())
      {
        LayerTable lt = (LayerTable)tr.GetObject(db.LayerTableId, OpenMode.ForWrite);
        if (lt.Has(layerName))
        {
          layerId = lt[layerName];
          if (layerId.IsErased)
          {
            LayerTableRecord ltr = (LayerTableRecord)tr.GetObject(layerId, OpenMode.ForWrite, true);
            ltr.Erase(false);
            layerId = ltr.Id;
          }
        }
        else
        {
          if (layerColor > 255)
          {
            ed.WriteMessage(string.Format(" ERROR: Could not use LayerColor \"{0}\", using 0 instead.", layerColor));
            layerColor = 0;
          }
          LayerTableRecord ltr = new LayerTableRecord();
          ltr.Name = layerName;
          ltr.Color = Autodesk.AutoCAD.Colors.Color.FromColorIndex(ColorMethod.ByAci, layerColor);
          ltr.LineWeight = lineweightName;
          layerId = lt.Add(ltr);
          tr.AddNewlyCreatedDBObject(ltr, true);
        }
        tr.Commit();
      }
      return layerId;
    }

    //
    public void AddPlotStyle(string PlotStyleName)
    {
      Database db = AcAp.Application.DocumentManager.MdiActiveDocument.Database;
      if (db.PlotStyleMode == false)
      {
        using (Transaction tr = db.TransactionManager.StartTransaction())
        {
          using (PlaceHolder hldr = new PlaceHolder())
          {
            DictionaryWithDefaultDictionary d =
              (DictionaryWithDefaultDictionary)tr.GetObject
                  (db.PlotStyleNameDictionaryId, OpenMode.ForWrite);
            d.SetAt(PlotStyleName, hldr);
            tr.Commit();
          }
        }
      }
    }

    //
    public void AddPlotStyleToLayer(ObjectId id, string PlotStyleName)
    {
      Database db = AcAp.Application.DocumentManager.MdiActiveDocument.Database;
      if (db.PlotStyleMode == false)
      {
        using (Transaction tr = db.TransactionManager.StartTransaction())
        {
          DictionaryWithDefaultDictionary d =
            (DictionaryWithDefaultDictionary)tr.GetObject
                (db.PlotStyleNameDictionaryId, OpenMode.ForRead);

          LayerTableRecord ltr =
               (LayerTableRecord)tr.GetObject(id, OpenMode.ForWrite);
          ltr.PlotStyleNameId = d.GetAt(PlotStyleName);
          tr.Commit();
        }
      }
    }

    [CommandMethod("doit")]
    public void doit()
    {
      Editor ed = AcAp.Application.DocumentManager.MdiActiveDocument.Editor;
      try
      {
        string plotstyle = "Style 1";
        AddPlotStyle(plotstyle);
        ObjectId id = this.CreateLayer("Daniel", 7, LineWeight.ByLayer);
        AddPlotStyleToLayer(id, plotstyle);
      }
      catch (System.Exception ex)
      {
        ed.WriteMessage("\n" + ex.Message + "\n" + ex.StackTrace);
      }
    }
  }
}


[It's Alive!]

this gave me the clue
http://discussion.autodesk.com/thread.jspa?messageID=395084

[mcarson]

Excellent!

What you have provided works in itself. I now have to build it into my program.

Thanks very much!

[Bryco]

PlaceHolder hldr, that's a pretty cool find Daniel, this C# stuff doesn't seem to get any easier. I used to think the vba help files were bad but compared to C# they are amazing.

[Kerry]

well researched Daniel !

[It's Alive!]

Excellent!

What you have provided works in itself. I now have to build it into my program.

Thanks very much!

You’re welcome, I must admit I probably would never had got this one if it wasn’t for Art Cooney’s post. 

[mcarson]

Another can of worms...

Attempt to add the layer more than once, and have a look at the ACAD layer dialog each time
The plot style name does not stay assigned to the layer, instead it moves with each new layer.

Am I getting this all wrong?

[It's Alive!]

you might try testing if the style exists ie

Code: [Select]

public void AddPlotStyle(string PlotStyleName)
    {
      Database db = AcAp.Application.DocumentManager.MdiActiveDocument.Database;
      if (db.PlotStyleMode == false)
      {
        using (Transaction tr = db.TransactionManager.StartTransaction())
        {
          using (PlaceHolder hldr = new PlaceHolder())
          {
            DictionaryWithDefaultDictionary d =
              (DictionaryWithDefaultDictionary)tr.GetObject
                  (db.PlotStyleNameDictionaryId, OpenMode.ForWrite);

            if (!d.Contains(PlotStyleName))//added
              d.SetAt(PlotStyleName, hldr);

            tr.Commit();
          }
        }
      }
    }


[mcarson]

I just done that while waiting on a reply; you're faster than I am!

Works now!

Thanks again!

I'll post my full code over the weekend

[It's Alive!]

Good deal!, usually the code I post is rough draft, 
you should probably add your error checking, try catches etc.,
and maybe even pass the working database as a parameter.

[Kerry]

Latitude 22°17'33.02"N  Longitude 113°57'1.73"E

Dan, what's your Vertitude ?

[MP]

Dan, what's your Vertitude ?

Kinda personal dontcha think?

 

[It's Alive!]

Latitude 22°17'33.02"N  Longitude 113°57'1.73"E

Dan, what's your Vertitude ?

33rd floor, maybe 100 or so meters MSL

PS. If you visit, bring black licorice 

[stevenh0616]

Thanks everyone for this great set of posts... this all worked really well as I encountered the same issues.

I think I saw someone ask about checking if the drawing uses CTBs or STBs. Here is some code to do just that, and it works well. Basically it just checks the system variable PSTYLEMODE and returns a boolean value, so if it's style mode, then you can apply the plot style to the layers.

Code - vb.net: [Select]

1. Public Shared Function GetPlotStyleModeTrueColorFalseStyle() As Boolean
2.         Dim result As Boolean = False
3.         If Convert.ToInt32(Application.GetSystemVariable("pstylemode")) = 1 Then
4.             result = True
5.         End If
6.         Return result
7.     End Function