Topic: Question: Delete a named layout from Database

[Glenn R]

You're welcome Dan.

You could still change this:

Code: [Select]

AcDbObjectPointer<AcDbDictionary> pDictionary(pDb->layoutDictionaryId(),AcDb::kForRead);

to this though:

Code: [Select]

AcDbDictionaryPointer pDictionary(pDb->layoutDictionaryId(),AcDb::kForRead);

As I mentioned previously, AcDbDictionaryPointer is already defined for you...just a thought.

Cheers,
Glenn.

[It's Alive!]

Doh! You did say it was already defined
Edited code.

Thanks Again

[Glenn R]

Dan,

Have you tried just deleting the layout itself and NOT iterating over all the entities in the layout and erasing each one first? I would have thought just deleting the layout would do the trick...

Cheers,
Glenn.

[It's Alive!]

Well…Um…No…I just assumed…I’ll need to test this 

[It's Alive!]

new code 

Code: [Select]

  static Acad::ErrorStatus deletelayout(const CString &FileName , const CString &LayoutName)
  {
    Acad::ErrorStatus es;
    AcDbObjectId LayoutId = AcDbObjectId::kNull;
    AcDbBlockTableRecordIterator *pBlkTblRcdItr = NULL;

    //a Smart Pointer to the database
    std::auto_ptr<AcDbDatabase> pDb(new AcDbDatabase(Adesk::kFalse));
    es = pDb->readDwgFile(FileName);
    if(es != Acad::eOk)
      return es;

    //Get the layout Dictionary from the Database
    AcDbDictionaryPointer pDictionary(pDb->layoutDictionaryId(),AcDb::kForRead);
    if(pDictionary.openStatus() != Acad::eOk)
      return es;

    //Get the Layout
    es = pDictionary->getAt(LayoutName, LayoutId);
    if(es != Acad::eOk)
      return es;

    AcDbObjectPointer<AcDbLayout> pLayout(LayoutId, AcDb::kForWrite);
    if(pLayout.openStatus() != Acad::eOk)
      return es;

    //erase the layout
    es = pLayout->erase();

    //closeup
    es = pDb->saveAs(FileName);
    return es;
  }


[It's Alive!]

Dan,

Have you tried just deleting the layout itself and NOT iterating over all the entities in the layout and erasing each one first? I would have thought just deleting the layout would do the trick...

Cheers,
Glenn.

You were right, just delete the layout.  :kewl:

[Glenn R]

Try this:

Code: [Select]

  static Acad::ErrorStatus deletelayout(const CString &FileName , const CString &LayoutName)
  {
    Acad::ErrorStatus es;
    AcDbObjectId LayoutId = AcDbObjectId::kNull;

    //a Smart Pointer to the database
    std::auto_ptr<AcDbDatabase> pDb(new AcDbDatabase(Adesk::kFalse));
    es = pDb->readDwgFile(FileName);
    if(es != Acad::eOk)
      return es;

    //Get the layout Dictionary from the Database
    AcDbDictionaryPointer pDictionary(pDb->layoutDictionaryId(),AcDb::kForRead);
    if(pDictionary.openStatus() != Acad::eOk)
      return es;

    //Get the Layout
    es = pDictionary->getAt(LayoutName, LayoutId);
    if(es != Acad::eOk)
      return es;

    es = pDictionary->remove(LayoutId); // remove the layout
    if (es != Acad::eOk)
       acutPrintf("\nError: Unable to remove layout. Error code = %s.", acadErrorStatusText(es));

    //closeup
    es = pDb->saveAs(FileName);
    return es;
  }

Cheers,
Glenn.

[It's Alive!]

Hmm got this

[Glenn R]

That code I posted was done in Visual Notepad (read not tested at all), so maybe you do need to cast the dictionary entry to a layout and erase it, rather than just blatantly deleting the dictionary entry...was just a thought.

My suggestion/modification was taken directly from some old code of mine which was just blatantly removing the layout from the dictionary as I showed...

Cheers,
Glenn.

[Glenn R]

Dan,

Try changing the open status of pDictionary from AcDb::kForRead to AcDb::kForWrite or just before the 'remove', use upgradeOpen adn see how that goes...

Cheers,
Glenn.

[It's Alive!]

Dan,

Try changing the open status of pDictionary from AcDb::kForRead to AcDb::kForWrite or just before the 'remove', use upgradeOpen adn see how that goes...

Cheers,
Glenn.

I had changed that., I wonder if Erase() does some internal mojo such as removing all the objects that the layout owns..

[It's Alive!]

...Visual Notepad...
 

[Glenn R]

Dan,

Try changing the open status of pDictionary from AcDb::kForRead to AcDb::kForWrite or just before the 'remove', use upgradeOpen adn see how that goes...

Cheers,
Glenn.

I had changed that., I wonder if Erase() does some internal mojo such as removing all the objects that the layout owns..

Possibly...The old fucntion I mentioned was working on a drawing that was currently loaded into the editor, so maybe opening the dbase in memory as you've done makes a difference...small difference at the end of the day the extra cast to a layout and open...

Cheers,
Glenn.

[Dream.Fei]

Try this:

Code: [Select]

  static Acad::ErrorStatus deletelayout(const CString &FileName , const CString &LayoutName)
  {
    Acad::ErrorStatus es;
    .......
  }

Cheers,
Glenn.

If didn't erase all entity on this layout?

[MickD]

... I wonder if Erase() does some internal mojo such as removing all the objects that the layout owns..

As the layout is an AcDbObject and it's another block table record (i.e. it holds all of its own ent data), 'erase' should do the trick. IOW, is you set the erase flag to true, all the ent's int the layout btr should also be flagged and therefore deleted (not saved) on the save.
I don't know if it would make much difference but setting modelspace as current after the erase may make a difference (I'd like to think that if the layout didn't exist it would open in mspace or one that existed at least anyway).