Topic: CommandLine Class (Tonys)

[Kerry]

From a quick read, the 'static Commandline()' method is not actually a constructor in the sense we know of.

The constructor is defined as an instance initializer which is named .ctor in the IL. 

The 'static Commanline()' is a type initializer which is named .cctor in the IL. Type initializers are called static constructors in the C++/CLI and C# languages.

[It's Alive!]

Neato, I learned something new today   

[Kerry]

Neato, I learned something new today   

I've had a good day in that regard as well !

[TonyT]

Hi Luis.

The Command() method is supposed to be
the static contstructor, but I changed the
name of the class at the last minute, and
forget to also change the name of this too.

To make it work do the following:

static Commands()

Change to:

static void Commands()

or you can make your Hashtable inside of TypedValueFromObject() like:

static TypedValue TypedValueFromObject(Object val)
{
    Hashtable ResTypes = new Hashtable();
    ResTypes.Clear();
// with the following too or as it is in the original below
    ////ResTypes.Add(typeof(string), RTSTR);
    ////ResTypes.Add(typeof(double), RTREAL);
    ////ResTypes.Add(typeof(Point3d), RT3DPOINT);
    ////ResTypes.Add(typeof(ObjectId), RTENAME);
    ////ResTypes.Add(typeof(Int32), RTLONG);
    ////ResTypes.Add(typeof(Int16), RTSHORT);
    ////ResTypes.Add(typeof(Point2d), RTPOINT);
    ResTypes[typeof(string)] = RTSTR;
    ResTypes[typeof(double)] = RTREAL;
    ResTypes[typeof(Point3d)] = RT3DPOINT;
    ResTypes[typeof(ObjectId)] = RTENAME;
    ResTypes[typeof(Int32)] = RTLONG;
    ResTypes[typeof(Int16)] = RTSHORT;
    ResTypes[typeof(Point2d)] = RTPOINT;

    object o = ResTypes[val.GetType()];

    if (o == null)
        throw new InvalidOperationException("Unsupported type in Command() method");
    return new TypedValue(o.GetHashCode(), val); //((int)o, val);
}

And as the code above use GetHashCode() instead of the (int) cast.

[TonyT]

Sorry all, I renamed the class at the last minute, from
'Commands' to 'CommandLine', and forget to rename
the static constructor.



Thanks to Kerry for stumbling over that, as I didn't
know that it was broken.

Updated verison .cs and .vb versions are on my
website now, and hopefully they work.

Thanks guys ..I made some time to test this.

I believe you were correct first time Daniel ..
I made it a static constructor ;
static CommandLine()
{
...
}

and

changed
return new TypedValue((int) o, val)
to
return new TypedValue(Convert.ToInt32(o), val);
because of a casting error ..

and got back to where I started .. loading a CUI menu ..

Code: [Select]

        //
        //
        [CommandMethod("Test_ZE")]
        public void test_ze()
        {
            CommandLine.ZoomExtents();
        }
        [CommandMethod("Test_LoadDbCUI")]
        public void test_Laconic()
        {
           string MenuQualifiedName = "K:\\DbCon.cui";
           string MenuGroupName = "DBCONNECT";
           CommandLine.Command(
                "FileDia", "0",
                "CuiUnLoad", MenuGroupName,
                "CuiLoad", MenuQualifiedName,
                "FileDia", "1"
                );
        }
.. and thanks to Tony for the original.

Command: Test_LoadDbCUI
Customization file unloaded successfully. Customization Group: DBCONNECT
Customization file loaded successfully. Customization Group: DBCONNECT
Command:

DUH: fat finger spelling !

[Kerry]

Thanks for confirming that Tony.

I notice you've changed the TypedValueFromObject method to more refined code.

I'm still getting an InvalidCastException using the (int).... cast though.
When I use the Convert.ToInt32(ResTypes[t]) the methos executes without a qualm.

[TonyT]

Thanks again. 

The only change I needed to make was to change the
cast from (int) to (short).

I posted an updated version that should work now.

Thanks for confirming that Tony.

I notice you've changed the TypedValueFromObject method to more refined code.

I'm still getting an InvalidCastException using the (int).... cast though.
When I use the Convert.ToInt32(ResTypes[t]) the methos executes without a qualm.

[LE]

Thanks again. 

The only change I needed to make was to change the
cast from (int) to (short).

I posted an updated version that should work now.

Have not seen your updated code Tony, but before knowing the previous code status, I added the use of GetHashCode() in your TypedValueFromObject() function and the function samples were working without any
exceptions, in this case it is better to use the cast?

Thanks.

[TonyT]

Luis - Sorry, but I'm not really sure I understand what
you mean by 'use of GetHashCode()'...

Perhaps you can post the subject code and
it might be clearer.

Thanks again. 

The only change I needed to make was to change the
cast from (int) to (short).

I posted an updated version that should work now.

Have not seen your updated code Tony, but before knowing the previous code status, I added the use of GetHashCode() in your TypedValueFromObject() function and the function samples were working without any
exceptions, in this case it is better to use the cast?

Thanks.

[TonyT]

Out of what transpired in a thread on Autodesk's .NET
newsgroup, I made a minor enhancement to this class,
that allows you to set a static property, that when set
to true, causes the Command() method to automatically
insert "_non" into the command list, in front of Point3d
or Point2d arguments, to supress running osnaps.

I posted the update just now

Thanks for confirming that Tony.

I notice you've changed the TypedValueFromObject method to more refined code.

I'm still getting an InvalidCastException using the (int).... cast though.
When I use the Convert.ToInt32(ResTypes[t]) the methos executes without a qualm.

[Kerry]

Yes, I noticed that thread this morning.
I was thinking at the time that all thats needed now is nil and T 

Thanks again Tony, this has been a good educator.

[LE]

Luis - Sorry, but I'm not really sure I understand what
you mean by 'use of GetHashCode()'...

Perhaps you can post the subject code and
it might be clearer.

This one Tony;

In your previous code I tested with:

Code: [Select]

static TypedValue TypedValueFromObject(Object val)
{
    object o = ResTypes[val.GetType()];
    if (o == null)
        throw new InvalidOperationException("Unsupported type in Command() method");
   return new TypedValue(o.[color=blue]GetHashCode[/color](), val); //((int)o, val); <<====
 }

And your class works without a problem (testing the functions you have as sample there).

Thanks!

[TonyT]

Luis - We don't use GetHashCode() to convert an object
to an integer type, we use typecasting or Convert.

My code works fine if the cast is to (short) rather than (int).

Luis - Sorry, but I'm not really sure I understand what
you mean by 'use of GetHashCode()'...

Perhaps you can post the subject code and
it might be clearer.

This one Tony;

In your previous code I tested with:

Code: [Select]

static TypedValue TypedValueFromObject(Object val)
{
    object o = ResTypes[val.GetType()];
    if (o == null)
        throw new InvalidOperationException("Unsupported type in Command() method");
   return new TypedValue(o.[color=blue]GetHashCode[/color](), val); //((int)o, val); <<====
 }

And your class works without a problem (testing the functions you have as sample there).

Thanks!

[LE]

We don't use GetHashCode() to convert an object
to an integer type, we use typecasting or Convert.

My code works fine if the cast is to (short) rather than (int).

Thank you Tony

It make sense now... strange that was working here, but now I get it...

[TonyT]

Just updated it again.

Another 'enhancement' is that it can automatically
transform coordinate input from WCS to current UCS.

Yes, I noticed that thread this morning.
I was thinking at the time that all thats needed now is nil and T 

Thanks again Tony, this has been a good educator.