Topic: CommandLine Class (Tonys)

[Kerry]

I've been having a look at Tony's CommandLine class ;

Can someone who's familiar give me a hand please.
I've added using System.Collections; Namespace for the Hashtable class references .. I assume that's correct ?

The bit in the attached piccy has me stumped.
Part of the problem may be that I've never played with Hashtables, but the compiler errors have me scratching my head.

I'll just attach the relevant part .. Any Ideas ??

[It's Alive!]

is this a constructor where the class name is Commands? I can't see the class name from your pic
ps where can I see the whole class?

[Kerry]

Hi Daniel,
The ClassName is CommandLine

I'm reticent about posting the class ..
You'll find it here. http://www.caddzone.com/CommandLine.cs

[It's Alive!]

We’d probably better ask the boss but since there is no “return type”
I would say it’s a constructor and should be renamed CommandLine….
But But.. I really have no idea sorry for butting in..     

[Kerry]

don't be sorry, I'm glad to have someone sane to talk with at this hour of the night ..

[LE]

To make it work do the following:

static Commands()

Change to:

static void Commands()

or you can make your Hashtable inside of TypedValueFromObject() like:

static TypedValue TypedValueFromObject(Object val)
{
    Hashtable ResTypes = new Hashtable();
    ResTypes.Clear();
// with the following too or as it is in the original below
    ////ResTypes.Add(typeof(string), RTSTR);
    ////ResTypes.Add(typeof(double), RTREAL);
    ////ResTypes.Add(typeof(Point3d), RT3DPOINT);
    ////ResTypes.Add(typeof(ObjectId), RTENAME);
    ////ResTypes.Add(typeof(Int32), RTLONG);
    ////ResTypes.Add(typeof(Int16), RTSHORT);
    ////ResTypes.Add(typeof(Point2d), RTPOINT);
    ResTypes[typeof(string)] = RTSTR;
    ResTypes[typeof(double)] = RTREAL;
    ResTypes[typeof(Point3d)] = RT3DPOINT;
    ResTypes[typeof(ObjectId)] = RTENAME;
    ResTypes[typeof(Int32)] = RTLONG;
    ResTypes[typeof(Int16)] = RTSHORT;
    ResTypes[typeof(Point2d)] = RTPOINT;

    object o = ResTypes[val.GetType()];

    if (o == null)
        throw new InvalidOperationException("Unsupported type in Command() method");
    return new TypedValue(o.GetHashCode(), val); //((int)o, val);
}

And as the code above use GetHashCode() instead of the (int) cast.

[Kerry]

Thanks for the comments Luis.

One issue with assuming it's a void method is that it never gets called from inside the class .. so the hashtable would never get filled, unless I misunderstand what's happening .. which IS likely.

How efficient would it be clearing and reloading the hashtable for each call to TypedValueFromObject ?

[LE]

Thanks for the comments Luis.

One issue with assuming it's a void method is that it never gets called from inside the class .. so the hashtable would never get filled, unless I misunderstand what's happening .. which IS likely.

How efficient would it be clearing and reloading the hashtable for each call to TypedValueFromObject ?

I tried to use the code as-is and simple was adding a line in:

        public static int Command(params object[] args)           
        {
            Commands();
...

But, it gets filled every time is called, so that's why I used, what I have done in some of my functions, since the hashtable is being clear every time before is filled, and it is a very simple one, I don't think there is a overhead, but wait for the masters...

[LE]

I tested also by using the following to avoid the Clear() call

Code: [Select]

if (ResTypes.Count == 0)
{
    //ed.WriteMessage("\nEmpty ResTypes HatchTable!");
    ResTypes[typeof(string)]    = RTSTR;
    ResTypes[typeof(double)]    = RTREAL;
    ResTypes[typeof(Point3d)]   = RT3DPOINT;
    ResTypes[typeof(ObjectId)]  = RTENAME;
    ResTypes[typeof(Int32)]     = RTLONG;
    ResTypes[typeof(Int16)]     = RTSHORT;
    ResTypes[typeof(Point2d)]   = RTPOINT;
    //ed.WriteMessage("\nHatchTable count is {0}", ResTypes.Count);
}


[It's Alive!]

How efficient would it be clearing and reloading the hashtable for each call to TypedValueFromObject ?

Correct, that’s why I still think it’s a static constructor.
The static constructor and the static hashtable would be initialized upon loading of the class. Correct?

[LE]

Yes...

For doing that, change:

static void Commands()

To:

public CommandLine()

And test the class again... btw, the use of Clear() is not bad sample at all.

[It's Alive!]

I think that would be incorrect Luis, as only a static constructor initializes its object upon loading of the assembly

Change
 

Code: [Select]

static Commands() to
 

Code: [Select]

static CommandLine() ,
if you need to make another instance, you would need to add a public to the non static constructor the methods are static

Code: [Select]

public class myClass
{
  public myClass()
  {
    // Constructor.
  }
  static myClass()
  {
    // Initialization code goes here.
    // Can only access static members here.
  }
  //...
}


[LE]

I am using the arx wizard and was following the default constructors it creates, but I checked with the static and works too, here is the class modified.

[It's Alive!]

Great, you didn’t need to comment the first constructor.
It would not be the same as constructor overloading.

[Kerry]

Thanks guys ..I made some time to test this.

I believe you were correct first time Daniel ..
I made it a static constructor ;
static CommandLine()
{
...
}

and

changed
return new TypedValue((int) o, val)
to
return new TypedValue(Convert.ToInt32(o), val);
because of a casting error ..

and got back to where I started .. loading a CUI menu ..

Code: [Select]

        //
        //
        [CommandMethod("Test_ZE")]
        public void test_ze()
        {
            CommandLine.ZoomExtents();
        }
        [CommandMethod("Test_LoadDbCUI")]
        public void test_Laconic()
        {
           string MenuQualifiedName = "K:\\DbCon.cui";
           string MenuGroupName = "DBCONNECT";
           CommandLine.Command(
                "FileDia", "0",
                "CuiUnLoad", MenuGroupName,
                "CuiLoad", MenuQualifiedName,
                "FileDia", "1"
                );
        }
.. and thanks to Tony for the original.

Command: Test_LoadDbCUI
Customization file unloaded successfully. Customization Group: DBCONNECT
Customization file loaded successfully. Customization Group: DBCONNECT
Command:

DUH: fat finger spelling !