Topic: Simple add text

[mohnston]

I'm trying to add a piece of text to a drawing and then save and close the drawing.
This code runs without error but the text is not on the drawing when I open it to check.
There has to be something simple wrong.

Won't you help? Look deep inside yourself and do the right thing.

Code: [Select]

private void StampDrawing(string fullDwgPath, string stampString)
{
   Document ThisDrawing = Autodesk.AutoCAD.ApplicationServices.Application.DocumentManager.Open(fullDwgPa th);
   ThisDrawing.LockDocument();
   Database thisDB = ThisDrawing.Database;
   Autodesk.AutoCAD.ApplicationServices.TransactionManager tm = ThisDrawing.TransactionManager;
   using (Transaction trans = tm.StartTransaction())
   {
      BlockTable bt = (BlockTable)thisDB.BlockTableId.GetObject(OpenMode.ForWrite);
      BlockTableRecord modelsp = (BlockTableRecord)trans.GetObject(bt[BlockTableRecord.ModelSpace], OpenMode.ForWrite);

      DBText stampText = new DBText();
      stampText.TextString = stampString;
      stampText.Height = 12;
      stampText.HorizontalMode = TextHorizontalMode.TextRight;
      stampText.Rotation = 0;
      modelsp.AppendEntity(stampText);
      trans.TransactionManager.AddNewlyCreatedDBObject(stampText, true);
      trans.Commit();
   }
   tm.Dispose();
   ThisDrawing.CloseAndSave(fullDwgPath);
   thisDB.Dispose();
}


[Chuck Gabriel]

I don't see where you have set the location of the text.  Could that be it?

Here is some C++ code that might help.  I know it's not C#, but it's close enough that you should be able to get the gist of it.

Code: [Select]

AcDbObjectId AcadUtilities::addText(
const AcGePoint3d& insertion,
const double& height,
const double& rotation,
const AcDb::TextHorzMode& horizMode,
const AcDb::TextVertMode& vertMode,
const string& textString,
const string& layerName) {
AcDbObjectPointer<AcDbText> textObj;
if(textObj.create() != Acad::eOk) {
acutPrintf("\nUnable to create text object.");
return AcDbObjectId::kNull;
}
textObj->setHeight(height);
textObj->setRotation(rotation);
textObj->setHorizontalMode(horizMode);
textObj->setVerticalMode(vertMode);
textObj->setTextString(textString.c_str());
appendObject(textObj.object());
textObj->setLayer(layerName.c_str());
if((horizMode == AcDb::kTextLeft) && (vertMode == AcDb::kTextBase))
textObj->setPosition(insertion);
else
textObj->setAlignmentPoint(insertion);
return textObj->objectId();
}


[LE]

This works...

Code: [Select]

        [CommandMethod("ADDTEXT")]
        public void addText()
        {
            Document doc = acadApp.DocumentManager.MdiActiveDocument;
            Editor ed = doc.Editor;
            Database db = doc.Database;
            using (Transaction tr = db.TransactionManager.StartTransaction())
            {
                BlockTableRecord btr = (BlockTableRecord)tr.GetObject(db.CurrentSpaceId, OpenMode.ForWrite);
                DBText stampText = new DBText();
                stampText.TextString = "TESTING";
                stampText.Height = 12;
                stampText.HorizontalMode = TextHorizontalMode.TextRight;
                stampText.Rotation = 0;
                btr.AppendEntity(stampText);
                tr.AddNewlyCreatedDBObject(stampText, true);
                tr.Commit();
            }
        }


[LE]

Code: [Select]

BlockTable bt = (BlockTable)thisDB.BlockTableId.GetObject(OpenMode.ForWrite);
BlockTableRecord modelsp = (BlockTableRecord)trans.GetObject(bt[BlockTableRecord.ModelSpace], OpenMode.ForWrite);

After reviewing your code a little more, the problem is on those lines, change it to:

Code: [Select]

BlockTable bt = (BlockTable)tr.GetObject(db.BlockTableId, OpenMode.ForRead);
BlockTableRecord modelsp = (BlockTableRecord)tr.GetObject(bt[BlockTableRecord.ModelSpace], OpenMode.ForWrite);

Have fun

note: make sure you use your own thisDB instead of db

[mohnston]

You might be on the right track LE.
I made the changes you suggest but not joy.
I suspect it has something to do with working on a drawing that is not the current drawing when the code starts.

Code: [Select]

        private void StampDrawing(string fullDwgPath, string stampString, bool FullSize)
        {
            Document ThisDrawing = Autodesk.AutoCAD.ApplicationServices.Application.DocumentManager.Open(fullDwgPath);
            ThisDrawing.LockDocument();
            Database thisDB = ThisDrawing.Database;
            Autodesk.AutoCAD.DatabaseServices.TransactionManager tm = ThisDrawing.Database.TransactionManager;
            using (Transaction trans = tm.StartTransaction())
            {
                BlockTable bt = (BlockTable)trans.GetObject(thisDB.BlockTableId, OpenMode.ForWrite);
                BlockTableRecord modelsp = (BlockTableRecord)trans.GetObject(bt[BlockTableRecord.ModelSpace], OpenMode.ForWrite);
               
                DBText stampText = new DBText();
                stampText.TextString = stampString;
                stampText.Height = 12;
                stampText.HorizontalMode = TextHorizontalMode.TextRight;
                stampText.Rotation = 0;
                Point3d pIns = new Point3d(1070, 15, 0);
                stampText.Position = pIns;
                modelsp.AppendEntity(stampText);
                trans.TransactionManager.AddNewlyCreatedDBObject(stampText, true);
                trans.Commit();
            }
            tm.Dispose();
            ThisDrawing.CloseAndSave(fullDwgPath);
            thisDB.Dispose();
        }

Your example code doesn't do what I need.
I need to open a document, add the text, save the document and close it.

Chuck, thanks for the C++ but I'm C++ illiterate. It might as well be C%$#@.
I was concerned about the location of the text also. I thought I would tackle this first and make location another thread.
There is no setPosition or setAlignmentpoint method for DBText.
There is a Position property which I set in this revised code.
Text is not on drawing when I open it.

[LE]

Ok... I might end up running some tests if I had a chance.

For the alignment you need to use: TextHorizontalMode

[LE]

If I use, a session command, at least adds the text, but shows an error...

Code: [Select]

        [CommandMethod("TESTEXT", CommandFlags.Session)]
        public void txt()
        {
            StampDrawing("C:\\test.dwg", "TESTING", true);
        }


[LE]

I see.... you know what, the call to ThisDrawing is doing a Read-Only....

[LE]

Here is the code that is working, we need to make sure the preview will be saved...

Code: [Select]

        [CommandMethod("TXT", CommandFlags.Session)]
        public void txt()
        {
            StampDrawing("C:\\test.dwg", "TESTING", true);
        }

        private void StampDrawing(string fullDwgPath, string stampString, bool FullSize)
        {
            Document ThisDrawing = Autodesk.AutoCAD.ApplicationServices.Application.DocumentManager.Open(fullDwgPath, false);
            ThisDrawing.LockDocument();
            Database thisDB = ThisDrawing.Database;
            Autodesk.AutoCAD.DatabaseServices.TransactionManager tm = ThisDrawing.Database.TransactionManager;
            using (Transaction trans = tm.StartTransaction())
            {
                BlockTable bt = (BlockTable)trans.GetObject(thisDB.BlockTableId, OpenMode.ForWrite);
                BlockTableRecord modelsp = (BlockTableRecord)trans.GetObject(bt[BlockTableRecord.ModelSpace], OpenMode.ForWrite);
                DBText stampText = new DBText();
                stampText.TextString = stampString;
                stampText.Height = 12;
                stampText.HorizontalMode = TextHorizontalMode.TextRight;
                stampText.Rotation = 0;
                Point3d pIns = new Point3d(1070, 15, 0);
                stampText.Position = pIns;
                modelsp.AppendEntity(stampText);
                trans.TransactionManager.AddNewlyCreatedDBObject(stampText, true);
                trans.Commit();
            }
            tm.Dispose();
            ThisDrawing.CloseAndSave(fullDwgPath);
            thisDB.Dispose();
        }


[T.Willey]

Here is the code that is working, we need to make sure the preview will be saved...

This is how I did it.

Code: [Select]

db.RetainOriginalThumbnailBitmap = true;

[Kerry]

Just running past, no time to play ...

Luis, you may want to wrap the locdoc in a using statement so it behaves a little better

Code: [Select]

            using (DocumentLock doclock = doc.LockDocument())
            {
                using (Transaction tr = doc.TransactionManager.StartTransaction())
                {
                    // bla, bla

                }
            }    


:added:
... or at least disposing it by adding :
docLock.Dispose();

[LE]

Just running past, no time to play ...

Luis, you may want to wrap the locdoc in a using statement so it behaves a little better

Code: [Select]

            using (DocumentLock doclock = doc.LockDocument())
            {
                using (Transaction tr = doc.TransactionManager.StartTransaction())
                {
                    // bla, bla

                }
            }    

Kerry;
That's scary.... I was about to implement that in this moment.... do you read minds?.... anyway, I think Mark has something that is working now   - also, remember that Glenn mentioned that if it is wrap inside a using the transaction, there were no need of the lock doc?... or I am dreaming?

Thanks, Tim;

I have seen that statement but only before a SaveAs... no idea if it can be applied to CloseAndSave... care to test that anyone?

Cheers!

[T.Willey]

<snip>
no idea if it can be applied to CloseAndSave... care to test that anyone?

That is how I use it, before a SaveAs.  I'm sick, and not well enough to think in C# right now or I would.  Sorry Luis.

[Kerry]

That's scary.... I was about to implement that in this moment.... do you read minds?....

Yes, but only the positive vibes, I filter out all the negative stuff   

[mohnston]

Kerry;
.... anyway, I think Mark has something that is working now ...Cheers!

Not working.
I tried moving the procedure code out of my form class to regular class. No text.
 

I think it might have something to do with where I'm calling the code from. In my case it's a modal dialog.