Topic: Loop through each control

[latour_g]

I have a loop that goes through all the controls (all Button) in a panel.  For some reason, one button is ignore and one button is going twice in the loop.  Any idea why ?
 

Code: [Select]

            foreach (Control ct in this.panel2.Controls)
            {
                if (ct is Button)
                {
                    Button cbtn = (Button)ct;
                    lastBtn = cbtn;
                    if (cbtn.Name == cbtnName)
                    {
                        cbtn.BackColor = Color.Yellow; cbtn = btnLast;
                    }
                    else cbtn.BackColor = Color.Black;
                }
            }

Should I not use copy/paste to create my button ? I tried deleted the button and create another one but then it was another button that was being ignore  :ugly:

[MickD]

I don't know, but your logic with this line:

cbtn.BackColor = Color.Yellow; cbtn = btnLast;

is resetting your button back to normal, you save a copy as btnlast then copy it back over cbtn after you change it and returning it to its original state, this will make it look like it is being ignored yes?

[Andrey Bushman]

Code: [Select]

cbtn = btnLast;


Why you do it? This changing is not used anywhere. Next loop override it (cbtn variable lives in the "if" construction only).

[latour_g]

btnLast is use elsewhere to put the button back to black.  But I have deleted btnLast to only keep lastBtn.  I have place lastBtn = cbtn;
 in the if statement and now it's working fine :

Code: [Select]

           
             foreach (Control ct in this.panel2.Controls)
            {
                if (ct is Button)
                {
                    Button cbtn = (Button)ct;
                   
                    if (cbtn.Name == cbtnName)
                    {
                        lastBtn = cbtn;
                        cbtn.BackColor = Color.Yellow;
                    }
                    else cbtn.BackColor = Color.Black;
                }
            }

Thank you guys you don't know how much time I spent on that problem !!!  You opened my eyes