Print Page - help with a lisp

Code Red => AutoLISP (Vanilla / Visual) => Topic started by: pedroantonio on March 24, 2014, 09:36:50 AM

Title: help with a lisp
Post by: pedroantonio on March 24, 2014, 09:36:50 AM

I am trying to learn some things in lisp so i need help.

I write this code but a lot of things is missing .I want this lisp to do

1) Select a close polyline
2)give sd and sk
3)use the area of the close polyline to calculate D and K

Code - Auto/Visual Lisp: [Select]

(DEFUN C:TEST (/ area sd sk)
 
;Select a close polyline and use the area to calculate 
;d and k
 
  (SETQ SD ("\ngive sd (example 1.2): ")
  (SETQ SK ("\ngive sk (exmple 0.70 or 70%): ")
  (PRINC (STRCAT "\n D = " ((RTOS (* area sd) 2 2) " sq.m")
                 "\n K = " ((RTOS (* area sk) 2 2) " sq.m")
          )
          (PRINC)
 

Thanks

Title: Re: help with a lisp
Post by: efernal on March 24, 2014, 03:29:01 PM

Code - Auto/Visual Lisp: [Select]

(DEFUN c:test (/ area dxf ent sd sk)
  (IF (AND (SETQ ent (CAR (ENTSEL "\n-> Select a closed polyline : ")))
           (WCMATCH (CDR (ASSOC 0 (SETQ dxf (ENTGET ent)))) "*POLYLINE")
           (MEMBER (CDR (ASSOC 70 dxf)) '(1 129))
      )
    (PROGN
      (INITGET 7)
      (SETQ sd (GETREAL "\n Give sd (example 1.2) : "))
      (INITGET 7)
      (SETQ sk (GETREAL "\n Give sk in % (example 0.70) : "))
      (SETQ area (VLAX-GET-PROPERTY (VLAX-ENAME->VLA-OBJECT ent) 'area))
      (PRINC
        (STRCAT "\n D = " (RTOS (* area sd) 2 2) " sq.m" "\n K = " (RTOS (* area sk) 2 2) " sq.m")
      )
    )
    (PRINC "\n-> No valid polyline selected...")
  )
  (PRINC)
)
 

Title: Re: help with a lisp
Post by: alanjt on March 24, 2014, 03:34:55 PM

You could also use vlax-curve-getArea. Then you wouldn't have to convert it to a vla-object.

Title: Re: help with a lisp
Post by: efernal on March 24, 2014, 04:53:20 PM

As suggested by Alanjt

Code - Auto/Visual Lisp: [Select]

(DEFUN c:test (/ area dxf ent sd sk)
  (IF (AND (SETQ ent (CAR (ENTSEL "\n-> Select a closed polyline : ")))
           (WCMATCH (CDR (ASSOC 0 (SETQ dxf (ENTGET ent)))) "*POLYLINE")
           (MEMBER (CDR (ASSOC 70 dxf)) '(1 129))
      )
    (PROGN
      (INITGET 7)
      (SETQ sd (GETREAL "\n Give sd (example 1.2) : "))
      (INITGET 7)
      (SETQ sk (GETREAL "\n Give sk in % (example 0.70) : "))
      (SETQ area (VLAX-CURVE-GETAREA ent))
      (PRINC
        (STRCAT "\n D = " (RTOS (* area sd) 2 2) " sq.m" "\n K = " (RTOS (* area sk) 2 2) " sq.m")
      )
    )
    (PRINC "\n-> No valid polyline selected...")
  )
  (PRINC)
)

Title: Re: help with a lisp
Post by: pedroantonio on March 24, 2014, 06:00:33 PM

Thank you for the help

Title: Re: help with a lisp
Post by: pedroantonio on March 26, 2014, 12:32:05 PM

i want to update this lisp with few thing and i need help

first i want to add an oprtion menu

1)Choose 1 for this ...
2)Choose 2 for this ...
3)Choose 3 for this ...
4)Choose 4 for this ...

for 1

if Area < 700 sqm then D = 240 sqm and K = Area * 0.60
if Area >=700 sqm then D = 400 sqm and K = Area * 0.60
if Area =< 200 sqm then D = Area sqm and K = Area * 0.70

for 2

D = Area * 0.80 but max D= 400sqm
K= Area * 0.60

for 3

if Area = 4000 sqm then D = 200 sqm and K = Area * 0.10
if 4000 sqm < Area =<8000 sqm then D = 200 + (Area - 4000)*0.02 and K = Area * 0.10
if Area > 8000 sqm then D = 280 + (Area - 8000)*0.01 and K = Area * 0.10
if 750 sqm =< Area <1200 sqm then D = 100 + ((Area - 750) / 9) and K = Area * 0.10
if 1200 sqm =< Area =<2000 sqm then D = 150 + ((Area - 1200) / 16) and K = Area * 0.10

for 4

Is the code we have already

Thanks

Title: Re: help with a lisp
Post by: Kerry on March 26, 2014, 07:03:04 PM

Untested basic shell.

Code - Auto/Visual Lisp: [Select]

 
 
(defun c:test4
       (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          ((>= area 700)
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 () (alert "Option 2\nTo be Completed by Client ") (_Option4))
  (defun _option3 () (alert "Option 3\nTo be Completed by Client") (_Option4))
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (initget 7)
      (setq area   (vlax-curve-getarea ent)
            option (getint "Select Option 1 to 4 : ")
      )
      (cond ((= option 1) (_Option1))
            ((= option 2) (_Option2))
            ((= option 3) (_Option3))
            ((= option 4) (_Option4))
            (t (alert "Read the prompt, Idiot\nUsing Option 4. ") (_Option4))
      )
      (princ (strcat "\n Selected Area = "
                     (rtos area 2 2)
                     "\n D = "
                     (rtos sdarea 2 2)
                     " sq.m"
                     "\n K = "
                     (rtos skarea 2 2)
                     " sq.m"
             )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 02:44:23 AM

Thank you Kerry for the help . I add a start up menu but samething is wrong. I coplete options 2 and option 3 but i need to check the code

Code - Auto/Visual Lisp: [Select]

(defun c:test4
       (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          ((>= area 700)
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 ()
  (cond ((<= sdarea 400)  ; I don't know if this is correct maxD = 400
           (setq sdarea (* area 0.8)
                 skarea (* area 0.6)
           )
          )          
    )
  )
  (defun _option3 ()
 
    (cond ((<= area 4000)
           (setq sdarea (= 200)
                 skarea (* area 0.10)
           )
          )
      (( 4000 < area =<8000) ; I don't know how to write it
           (setq sdarea (+ 200 ( * 0.02 (- area 4000))) ; please check it  200 + (Area - 4000)*0.02
                 skarea (* area 0.1)
           )
          )
          ((> area 8000)
           (setq sdarea (+ 280 ( * 0.01 (- area 8000))) ; please check it  280 + (Area - 8000)*0.01
                 skarea (* area 0.1)
           )
          )
     (( 750 =< Area < 1200); I don't know how to write it
           (setq sdarea (+ 280 ( / 9 (- area 750))) ; please check it   D = 100 + ((Area - 750) / 9)
                 skarea (* area 0.1)
           )
          )
        (( 1200 =< Area =< 2000); I don't know how to write it
           (setq sdarea (+ 150 ( / 16 (- area 1200))) ; please check it    D = 150 + ((Area - 1200) / 16)
                 skarea (* area 0.1)
           )
          )
    )
  )
 
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (initget 7)
(TEXTPAGE)
  (PROMPT
    "\n choose option :
 
   1. Choose 1 for this ...
   2. Choose 2 for this ...
   3. Choose 3 for this ...
   4. Choose 4 for this ...
   
" )
      (setq area   (vlax-curve-getarea ent)
            option (getint "Select Option 1 to 4 : ")
      )
      (cond ((= option 1) (_Option1))
            ((= option 2) (_Option2))
            ((= option 3) (_Option3))
            ((= option 4) (_Option4))
            (t (alert "Read the prompt, Idiot\nUsing Option 4. ") (_Option4))
      )
      (princ (strcat "\n Selected Area = "
                     (rtos area 2 2)
                     "\n D = "
                     (rtos sdarea 2 2)
                     " sq.m"
                     "\n K = "
                     (rtos skarea 2 2)
                     " sq.m"
             )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 
 

Thanks

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 12:07:27 PM

i think i fix it

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 12:30:03 PM

I can't make time to look closely at the moment but option 2 seems incorrect.

I'll have a look when I finish up what I'm doing.

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 12:42:22 PM

Kerry if you can fix option 3. I fix option 2 but in option 3 i have calculation problems

Code - Auto/Visual Lisp: [Select]

  (defun _option3 ()
 
      (cond ((= area 4000)
           (setq sdarea (= 200)
                 skarea (* area 0.10)
           )
          )
      (( 4000 < area =<8000) ; I don't know how to write it
           (setq sdarea (+ 200 ( * 0.02 (- area 4000))) ; please check it  200 + (Area - 4000)*0.02
                 skarea (* area 0.1)
           )
          )
          ((area > 8000)
           (setq sdarea (+ 280 ( * 0.01 (- area 8000))) ; please check it  280 + (Area - 8000)*0.01
                 skarea (* area 0.1)
           )
          )
     (( 750 =< Area < 1200); I don't know how to write it
           (setq sdarea (+ 280 ( /  (- area 750) 9)) ; please check it   D = 100 + ((Area - 750) / 9)
                 skarea (* area 0.1)
           )
          )
        (( 1200 =< Area =< 2000); I don't know how to write it
           (setq sdarea (+ 150 ( / (- area 1200) 16)) ; please check it    D = 150 + ((Area - 1200) / 16)
                 skarea (* area 0.1)
           )
          )
    )
  )
 

thanks

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 01:46:15 PM

Kerry , I change the option 3 code but i have this problem

for 1200 < Area < = 2000 D = 150 + ((Area - 1200) / 16) and K = Area * 0.10

but

for 2000 < Area < 40000 D = 0 and K =0

I dont know how to write it

Please check all the functions

if Area = 4000 sqm then D = 200 sqm and K = Area * 0.10
if 4000 sqm < Area =<8000 sqm then D = 200 + (Area - 4000)*0.02 and K = Area * 0.10
if Area > 8000 sqm then D = 280 + (Area - 8000)*0.01 and K = Area * 0.10
if 750 sqm =< Area <1200 sqm then D = 100 + ((Area - 750) / 9) and K = Area * 0.10
if 1200 sqm =< Area =<2000 sqm then D = 150 + ((Area - 1200) / 16) and K = Area * 0.10

Code - Auto/Visual Lisp: [Select]

(defun _option3 ()
      (cond ((= area 4000)
           (setq sdarea 200
                 skarea (* area 0.1)
           )
          )
          ((> area 4000)
           (setq sdarea (+ 200 ( * 0.02 (- area 4000)))
                 skarea (* area 0.1)
           )
          )
          ((<= area 8000)
           (setq sdarea (+ 200 ( * 0.02 (- area 4000)))
                 skarea (* area 0.1)
           )
          )
          ((> area 8000)
           (setq sdarea (+ 280 ( * 0.01 (- area 8000)))
                 skarea (* area 0.1)
           )
          )
          ((>= area 750)
           (setq sdarea (+ 100 ( / (- area 750) 9))
                 skarea (* area 0.1)
           )
          )
          ((<= area 1200)
           (setq sdarea (+ 100 ( / (- area 750) 9))
                 skarea (* area 0.1)
           )
          )
           ((> area 1200)
           (setq sdarea (+ 150 ( / (- area 1200) 16))
                 skarea (* area 0.1)
           )
          )
           ((<= area 2000)
           (setq sdarea (+ 150 ( / (- area 1200) 16))
                 skarea (* area 0.1)
           )
          )
           ((> area 2000)
           (setq sdarea 0
                 skarea 0
           )
          )
           ((< area 4000)
           (setq sdarea 0
                 skarea 0
           )
          )
    )
  )
 
 

thanks

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 03:09:57 PM

Have a play with this for testing ... best not to change ( kdub:assert-expect <.> <.> )
Build your own tests.

Code - Auto/Visual Lisp: [Select]

 
 
;;;------------------------------------------------------------------
;;;------------------------------------------------------------------
;;;
;;; (kdub:assert-expect <teststatement> <expected>)
;;; kwb 20020715
;;; <teststatement> argument must be quoted
;|
( kdub:assert-expect '(+ 2 2) 4)
( kdub:assert-expect '(+ 2 2) (+ 1 3))
|;
(defun kdub:assert-expect (teststatement expected / catchit tmp)
  (if (vl-catch-all-error-p
        (setq catchit (vl-catch-all-apply
                        '=
                        (list expected (setq tmp (eval teststatement)))
                      )
        )
      )
    (alert (vl-catch-all-error-message catchit))
    ;; else
    (if (not catchit)
      (progn (mapcar 'princ
                     (list "\n **** Assertion Failure : "
                           (vl-prin1-to-string teststatement)
                           "\n expected : "
                           (vl-prin1-to-string expected)
                           " returned : "
                           (vl-prin1-to-string tmp)
                     )
             )
             ;; decide what to do here later ?
             (if *assert-debug_on*
               (princ "  ")
               (vl-exit-with-error (strcat "We bombed! "))
             )
      )
      (mapcar 'princ
              (list "\nAssertion-expect : "
                    (vl-prin1-to-string teststatement)
                    " returned : "
                    (vl-prin1-to-string tmp)
              )
      )
    )
  )
  (princ)
)
;;;------------------------------------------------------------------
;;;------------------------------------------------------------------
;;;
 

These are the tests I used for _option1()
You will need to load _option1() into memory ...

Code - Auto/Visual Lisp: [Select]

(setq area 1)
(_option1)
( kdub:assert-expect 'sdarea 1)
( kdub:assert-expect 'skarea 1)  ; a failing test
 
(setq area 199)
(_option1)
( kdub:assert-expect 'sdarea area)
( kdub:assert-expect 'skarea (* area 0.7))
 
(setq area 600)
(_option1)
( kdub:assert-expect 'sdarea 240)
( kdub:assert-expect 'skarea (* area 0.6))
 
(setq area 701)
(_option1)
( kdub:assert-expect 'sdarea 400)
( kdub:assert-expect 'skarea (* area 0.6))
 
 

Just comment out the tests when you're happy.
You can uncomment them when you make changes to your code under test in the future ....

Added:
Testing like this is one reason to keep your functions compact.

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 03:17:01 PM

Topographer,

Lets try a little self help.

Can you write tests for _option3()
Then we can look at the ones that fail.

Regards,

added:

See if something like these conditionals brings you joy

Code - Auto/Visual Lisp: [Select]

 
(= area 4000)
(and (> area 4000) (<= area 8000))
(> area 8000)
(and (>= area 750) (< area 1200))
(and (>= area 1200) (<= area 2000))
 
 

These are the conditionals you specified.
There seems to be some gaps in the range that will not be evaluated.

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 03:50:03 PM

I write this

Code - Auto/Visual Lisp: [Select]

(defun _option3 ()
      (cond  (and (>= area 750) (<= area 1200)
           (setq sdarea (+ 100 ( / (- area 750) 9))
                 skarea (* area 0.1)
           )
          )
                    
           (and (> area 1200) (<= area 2000)
           (setq sdarea (+ 150 ( / (- area 1200) 16))
                 skarea (* area 0.1)
           )
          )
           (and (> area 2000) (< area 4000)
           (setq sdarea 0
                 skarea 0
                    )
          )
 
           ((= area 4000)
           (setq sdarea 200
                 skarea (* area 0.1)
           )
          )
          (and (> area 4000) (<= area 8000)
           (setq sdarea (+ 200 ( * 0.02 (- area 4000)))
                 skarea (* area 0.1)
           )
          )
          
          ((> area 8000)
           (setq sdarea (+ 280 ( * 0.01 (- area 8000)))
                 skarea (* area 0.1)
           )
          )         
    )
  )
 
 

but i have problem with this

for 2000 < Area < 40000 ---> D = 0 and K =0

example

for area 3950 sqm --- > D= 455.56 and K= 395 , understand the fuction as Area >=750 .

I don't know what to do

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 03:57:52 PM

There are a few number ranges that are not evaluated.

Draw yourself a numberLine and mark off the ranges you ARE testing.
http://en.wikipedia.org/wiki/Number_line

You may need to add conditionals and assignments for those ranges ...

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 04:01:16 PM

It looks like you are missing some parenthesis in your conditional statement

(cond
<HERE> (and (>= area 750) (<= area 1200) <and HERE>

.. do stuff
)
.. more conditionals
)

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 04:16:14 PM

I add the parenthesis
The lisp run and when i select 3 option gives me this error !!!
; error: bad argument type: numberp: nil

Code - Auto/Visual Lisp: [Select]

 (defun c:test4
       (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          ((>= area 700)
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 ()
  (cond ((<= sdarea 400)  ; I don't know if this is correct maxD = 400
           (setq sdarea (* area 0.8)
                 skarea (* area 0.6)
           )
          )          
    )
  )
  (defun _option3 ()
 
      (cond ((and (>= area 750) (<= area 1200)
           (setq sdarea (+ 100 ( / (- area 750) 9))
                 skarea (* area 0.1)
           )
          )
                    
           ((and (> area 1200) (<= area 2000)
           (setq sdarea (+ 150 ( / (- area 1200) 16))
                 skarea (* area 0.1)
           )
          )
           ((and (> area 2000) (< area 4000)
           (setq sdarea 0
                 skarea 0
                    )
          )
 
           ((= area 4000)
           (setq sdarea 200
                 skarea (* area 0.1)
           )
          )
          ((and (> area 4000) (<= area 8000)
           (setq sdarea (+ 200 ( * 0.02 (- area 4000)))
                 skarea (* area 0.1)
           )
          )
          
          ((> area 8000)
           (setq sdarea (+ 280 ( * 0.01 (- area 8000)))
                 skarea (* area 0.1)
             )
           )
         )
       )
     )
    )
  )
)
 
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (initget 7)
(TEXTPAGE)
  (PROMPT
    "\n choose option :
 
   1. Choose 1 for this ...
   2. Choose 2 for this ...
   3. Choose 3 for this ...
   4. Choose 4 for this ...
 
" )
      (setq area   (vlax-curve-getarea ent)
            option (getint "Select Option 1 to 4 : ")
      )
      (cond ((= option 1) (_Option1))
            ((= option 2) (_Option2))
            ((= option 3) (_Option3))
            ((= option 4) (_Option4))
            (t (alert "Read the prompt, Idiot\nUsing Option 4. ") (_Option4))
      )
      (princ (strcat "\n Selected Area = "
                     (rtos area 2 2)
                     "\n D = "
                     (rtos sdarea 2 2)
                     " sq.m"
                     "\n K = "
                     (rtos skarea 2 2)
                     " sq.m"
             )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 
 
 

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 04:22:06 PM

Quote from: Topographer on March 27, 2014, 04:16:14 PM

I add the parenthesis and now gives me

< .. >

Have another look ... your conditional test is mixed with the assignment code.

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 04:30:53 PM

I update the code but i still have the same problom with the option 3
; error: bad argument type: numberp: nil

Code - Auto/Visual Lisp: [Select]

 (defun c:test4
       (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          ((>= area 700)
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 ()
    (cond ((<= area 2000)
            (setq sdarea  (* area 0.8)
             skarea (* area 0.6)
           )
          )     
         ((> area 2000)
           (setq sdarea (+ 400 ( * 0.05 (- area 2000)))
                 skarea (* area 0.1)
           )
          )     
    )
  )
  (defun _option3 ()
 
      (cond ((and (>= area 750) (<= area 1200)
           (setq sdarea (+ 100 ( / (- area 750) 9))
                 skarea (* area 0.1)
           )
          )
 
           ((and (> area 1200) (<= area 2000)
           (setq sdarea (+ 150 ( / (- area 1200) 16))
                 skarea (* area 0.1)
           )
          )
           ((and (> area 2000) (< area 4000)
           (setq sdarea 0
                 skarea 0
                    )
          )
 
           ((= area 4000)
           (setq sdarea 200
                 skarea (* area 0.1)
           )
          )
          ((and (> area 4000) (<= area 8000)
           (setq sdarea (+ 200 ( * 0.02 (- area 4000)))
                 skarea (* area 0.1)
           )
          )
 
          ((> area 8000)
           (setq sdarea (+ 280 ( * 0.01 (- area 8000)))
                 skarea (* area 0.1)
             )
           )
         )
       )
     )
    )
  )
)
 
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (initget 7)
(TEXTPAGE)
  (PROMPT
    "\n choose option :
 
   1. Choose 1 for this ...
   2. Choose 2 for this ...
   3. Choose 3 for this ...
   4. Choose 4 for this ...
 
" )
      (setq area   (vlax-curve-getarea ent)
            option (getint "Select Option 1 to 4 : ")
      )
      (cond ((= option 1) (_Option1))
            ((= option 2) (_Option2))
            ((= option 3) (_Option3))
            ((= option 4) (_Option4))
            (t (alert "Read the prompt, Idiot\nUsing Option 4. ") (_Option4))
      )
      (princ (strcat "\n Selected Area = "
                     (rtos area 2 2)
                     "\n D = "
                     (rtos sdarea 2 2)
                     " sq.m"
                     "\n K = "
                     (rtos skarea 2 2)
                     " sq.m"
             )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 
 
 

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 04:33:40 PM

Try something like this for _option2

Code - Auto/Visual Lisp: [Select]

(defun _option2 ()
  (cond (area
         (setq sdarea (min 400.0 (* area 0.8))
               skarea (* area 0.6)
         )
        )
  )
)

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 04:35:56 PM

Try this formatting for option3
I haven't looked at the logic

Code - Auto/Visual Lisp: [Select]

 
(defun _option3 ()
     (cond ((and (>= area 750) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 1200) (<= area 2000))
            (setq sdarea (+ 150 (/ (- area 1200) 16))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 2000) (< area 4000))
            (setq sdarea 0
                  skarea 0
            )
           )
           ((= area 4000)
            (setq sdarea 200
                  skarea (* area 0.1)
            )
           )
           ((and (> area 4000) (<= area 8000))
            (setq sdarea (+ 200 (* 0.02 (- area 4000)))
                  skarea (* area 0.1)
            )
           )
           ((> area 8000)
            (setq sdarea (+ 280 (* 0.01 (- area 8000)))
                  skarea (* area 0.1)
            )
           )
     )
   )
 
 

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 04:44:59 PM

Thank you Kerry .Now the lisp works fine. Can you explain me were was the mistake. I had exactly the same function before and not working properly !!!

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 04:50:30 PM

Quote from: Topographer on March 27, 2014, 04:44:59 PM

Thank you Kerry .Now the lisp works fine. Can you explain me were was the mistake. I had exactly the same function before and not working properly !!!

The error was in the parenthesis.
Have a look at this Post reply

Quote from: Kerry on March 27, 2014, 04:01:16 PM

It looks like you are missing some parenthesis in your conditional statement

(cond
<HERE> (and (>= area 750) (<= area 1200) <and HERE>

.. do stuff
)
.. more conditionals
)

Did you build tests for each conditional ?
If you fix the edge cases and the missing ranges you may not need to look at the code again after testing.

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 05:16:08 PM

Kerry , The only problem i have is with this

Code - Auto/Visual Lisp: [Select]

((and (>= area 750) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
 

For area = 750 and i change the code to this

Code - Auto/Visual Lisp: [Select]

((and (<= 750 area) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
 

I test it and work. What is your opinion ?

Thanks

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 05:19:47 PM

Quote from: Topographer on March 27, 2014, 05:16:08 PM

< .. >
I test it and work. What is your opinion ?

Thanks

The logic is similar I believe ... just different test values.

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 05:31:58 PM

Kerry, Option 3 crass again for area = 750 i dont know why

; error: bad argument type: numberp: nil

Code - Auto/Visual Lisp: [Select]

 (defun c:test4
       (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          ((>= area 700)
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 ()
    (cond ((<= area 2000)
            (setq sdarea  (* area 0.8)
             skarea (* area 0.6)
           )
          )     
         ((> area 2000)
           (setq sdarea (+ 400 ( * 0.05 (- area 2000)))
                 skarea (* area 0.1)
           )
          )     
    )
  )
 
(defun _option3 ()
     (cond ((and (>= area 750) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 1200) (<= area 2000))
            (setq sdarea (+ 150 (/ (- area 1200) 16))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 2000) (< area 4000))
            (setq sdarea 0
                  skarea 0
            )
           )
           ((= area 4000)
            (setq sdarea 200
                  skarea (* area 0.1)
            )
           )
           ((and (> area 4000) (<= area 8000))
            (setq sdarea (+ 200 (* 0.02 (- area 4000)))
                  skarea (* area 0.1)
            )
           )
           ((> area 8000)
            (setq sdarea (+ 280 (* 0.01 (- area 8000)))
                  skarea (* area 0.1)
            )
           )
     )
   )
 
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (initget 7)
(TEXTPAGE)
  (PROMPT
    "\n choose option :
 
   1. Choose 1 for this ...
   2. Choose 2 for this ...
   3. Choose 3 for this ...
   4. Choose 4 for this ...
 
" )
      (setq area   (vlax-curve-getarea ent)
            option (getint "Select Option 1 to 4 : ")
      )
      (cond ((= option 1) (_Option1))
            ((= option 2) (_Option2))
            ((= option 3) (_Option3))
            ((= option 4) (_Option4))
            (t (alert "Read the prompt, Idiot\nUsing Option 4. ") (_Option4))
      )
      (princ (strcat "\n Selected Area = "
                     (rtos area 2 2)
                     "\n D = "
                     (rtos sdarea 2 2)
                     " sq.m"
                     "\n K = "
                     (rtos skarea 2 2)
                     " sq.m"
             )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 
 

Title: Re: help with a lisp
Post by: Kerry on March 27, 2014, 05:42:41 PM

is area an integer
area = 750

or a real at 749.9999999999998

I'd close AutoCAD and reload the code.

Have you written tests yet ?

Where does the code crash .. on which line
I assume you're testing in VLIDE with Break on Error toggled ON and using Last Break Source Ctrl-F9 after the crash.

Title: Re: help with a lisp
Post by: pedroantonio on March 27, 2014, 06:03:59 PM

I change the code with this and work fine

Code - Auto/Visual Lisp: [Select]

 (defun _option3 ()
           (cond ((= area 750)
            (setq sdarea 100
                  skarea (* area 0.1)
            )
           )
            ((and (> area 750) (<= area 1200))
            (setq sdarea (+ 100 (/ (- area 750) 9))
                  skarea (* area 0.1)
            )
           )
                      ((and (> area 1200) (<= area 2000))
            (setq sdarea (+ 150 (/ (- area 1200) 16))
                  skarea (* area 0.1)
            )
           )
           ((and (> area 2000) (< area 4000))
            (setq sdarea 0
                  skarea 0
            )
           )
           ((= area 4000)
            (setq sdarea 200
                  skarea (* area 0.1)
            )
           )
           ((and (> area 4000) (<= area 8000))
            (setq sdarea (+ 200 (* 0.02 (- area 4000)))
                  skarea (* area 0.1)
            )
           )
           ((> area 8000)
            (setq sdarea (+ 280 (* 0.01 (- area 8000)))
                  skarea (* area 0.1)
            )
           )
     )
   )
 
 

Thank you Kerry

Title: Re: help with a lisp
Post by: Kerry on March 28, 2014, 04:39:20 AM

Quote from: Topographer on March 27, 2014, 06:03:59 PM

I change the code with this and work fine

< .. >

Thank you Kerry

Great. Glad I could help.

Just an observation :
I notice that the code you posted is not well formatted.
I'd suggest that use the VLIDE to format your code. A lot of the problems you have will be resolved by just accepting the formatting provided. Sometimes unbalanced statements are a little more obvious.

This is your code back ... just reformatted. You can see the flow a little easier because the 'paragraphs' line up a little better. This makes it easier to find faults in the logic.

In some regards VLIDE is a crap editor and it's disappointing that AutoDesk have not improved it in the last 15 years but it is a resource we should make the most of.

Code - Auto/Visual Lisp: [Select]

 
(defun _option3 ()
  (cond ((= area 750)
         (setq sdarea 100
               skarea (* area 0.1)
         )
        )
        ((and (> area 750) (<= area 1200))
         (setq sdarea (+ 100 (/ (- area 750) 9))
               skarea (* area 0.1)
         )
        )
        ((and (> area 1200) (<= area 2000))
         (setq sdarea (+ 150 (/ (- area 1200) 16))
               skarea (* area 0.1)
         )
        )
        ((and (> area 2000) (< area 4000))
         (setq sdarea 0
               skarea 0
         )
        )
        ((= area 4000)
         (setq sdarea 200
               skarea (* area 0.1)
         )
        )
        ((and (> area 4000) (<= area 8000))
         (setq sdarea (+ 200 (* 0.02 (- area 4000)))
               skarea (* area 0.1)
         )
        )
        ((> area 8000)
         (setq sdarea (+ 280 (* 0.01 (- area 8000)))
               skarea (* area 0.1)
         )
        )
  )
)
 
 ;|«Visual LISP© Format Options»
(80 2 45 2 nil "end of " 80 45 1 0 nil nil nil nil T)
;*** DO NOT add text below the comment! ***|;
 

Regards,

Title: Re: help with a lisp
Post by: CAB on March 28, 2014, 06:07:37 AM

Here is an observation; on options 1 & 2 you addresses the condition where the area was below a minimum value but in condition 3 you did not.
See my changes where option 3 has an error trap for values below 750.
Note also that condition statements will stop evaluating the conditions when one is true.
Therefore you do not need to bracket the value like

Code: [Select]

(and (> area 2000) (< area 4000))when you have already dealt with values below 2000 because the processing will never get this far for values <= 2000.
See my changes there too.
Lastly the last condition can simply be True and not

Code: [Select]

(> area 8000) as all other conditions have been addressed.

I also changed you user input for options 1 - 4 to use getKword instead of getinit.
This is a personal preference.

Code - Auto/Visual Lisp: [Select]

(defun c:test4 (/ _option1 _option2 _option3 _option4 area dxf ent sdarea skarea)
  (defun _option1 ()
    (cond ((<= area 200)
           (setq sdarea area
                 skarea (* area 0.7)
           )
          )
          ((< area 700)
           (setq sdarea 240
                 skarea (* area 0.6)
           )
          )
          (
           (setq sdarea 400
                 skarea (* area 0.6)
           )
          )
    )
  )
  (defun _option2 ()
    (cond ((<= area 2000)
           (setq sdarea (* area 0.8)
                 skarea (* area 0.6)
           )
          )
          (t
           (setq sdarea (+ 400 (* 0.05 (- area 2000)))
                 skarea (* area 0.1)
           )
          )
    )
  )
 
  (defun _option3 ()
    (cond ((< area 750)
           (princ "\nERROR: Area is too small")
          )
          ((= area 750)
           (setq sdarea 100
                 skarea (* area 0.1)
           )
          )
          ((<= area 1200)
           (setq sdarea (+ 100 (/ (- area 750) 9))
                 skarea (* area 0.1)
           )
          )
          ((<= area 2000)
           (setq sdarea (+ 150 (/ (- area 1200) 16))
                 skarea (* area 0.1)
           )
          )
          ((< area 4000)
           (setq sdarea 0
                 skarea 0
           )
          )
          ((= area 4000)
           (setq sdarea 200
                 skarea (* area 0.1)
           )
          )
          ((<= area 8000)
           (setq sdarea (+ 200 (* 0.02 (- area 4000)))
                 skarea (* area 0.1)
           )
          )
          (t
           (setq sdarea (+ 280 (* 0.01 (- area 8000)))
                 skarea (* area 0.1)
           )
          )
    )
  )
 
  (defun _option4 ()
    (initget 7)
    (setq sdarea (* area (getreal "\n Give sd (example 1.2) : ")))
    (initget 7)
    (setq skarea (* area (getreal "\n Give sk in % (example 0.70) : ")))
  )
 
 
 
  ;; Main -----
  (if (and (setq ent (car (entsel "\n-> Select a closed polyline : ")))
           (wcmatch (cdr (assoc 0 (setq dxf (entget ent)))) "*POLYLINE")
           (member (cdr (assoc 70 dxf)) '(1 129))
      )
    (progn
      (textpage)
      (prompt
        (strcat "\n choose option :" "\n " "\n  1. Choose 1 for this ..." "\n  2. Choose 2 for this ..."
                "\n  3. Choose 3 for this ..." "\n  4. Choose 4 for this ..." "\n"
               )
      )
      (setq area (vlax-curve-getarea ent))
      (initget 1 "1 2 3 4")
      (setq option (getkword "Select Option 1 to 4 : ")
      )
      (cond ((= option "1") (_option1))
            ((= option "2") (_option2))
            ((= option "3") (_option3))
            ((= option "4") (_option4))
      )
      (if area
        (princ (strcat "\n Selected Area = "
                       (rtos area 2 2)
                       "\n D = "
                       (rtos sdarea 2 2)
                       " sq.m"
                       "\n K = "
                       (rtos skarea 2 2)
                       " sq.m"
               )
        )
      )
    )
    (princ "\n-> No valid polyline selected...")
  )
  (princ)
)
(princ)
 
 ;|«Visual LISP© Format Options»
(120 2 2 2 nil "end of " 100 9 1 1 1 nil T nil T)
;*** DO NOT add text below the comment! ***|;

Title: Re: help with a lisp
Post by: pedroantonio on March 31, 2014, 03:34:22 AM

Kerry i have another question

1) I change all the code with this ,but i have some erros
2) i want to add two different comments at the end

a) if (oldare - anox) =< area <=(oldare + anox) then print comment 1
b) if area > (oldare + anox) or area < (oldare - anox) then print comment 2

Code - Auto/Visual Lisp: [Select]

(DEFUN
   C:test(/ _OPTION1 _OPTION2 OLDARE AREA DXF ENT ANOX)
  (DEFUN
     _OPTION1 ()
    (SETQ ANOX (* OLDARE 0.05))
    DEFUN
    _OPTION2
    ()
    (SETQ ANOX (* OLDARE 0.10))
    ;; Main -----
    (IF (AND
          (SETQ ENT (CAR (ENTSEL "\nSelect a close polyline: ")))
          (SETQ OLDARE (GETREAL "\ngive old area : "))
          (WCMATCH
            (CDR (ASSOC 0 (SETQ DXF (ENTGET ENT))))
            "*POLYLINE"
          )
          (MEMBER (CDR (ASSOC 70 DXF)) '(1 129))
        )
      (PROGN
        (INITGET 7)
        (TEXTPAGE)
        (PROMPT "\n text1  :
 
   1. option 1
   2. option 2")
        (SETQ
          AREA   (VLAX-CURVE-GETAREA ENT)
          OPTION (GETINT "choose 1 -->2: ")
        )
        (COND
          ((= OPTION 1) (_OPTION1))
          ((= OPTION 2) (_OPTION2))
          (T (ALERT "Select > 2 --> Auto select 2. ") (_OPTION2))
        )
        (PRINC
          (STRCAT
            "\n Area = "
            (RTOS AREA 2 2)
            " sqm"
            "\n Anotation Area = "
            (RTOS ANOX 2 2)
            " sqm"
            "\n comments: "
            "\n comment1....... "
            "\n comment2....... "
            "com "
          )
        )
      )
      (PRINC "\nError selection of polyline ...")
    )
    (PRINC)
  )
  (PRINC)
)
 

thanks

Title: Re: help with a lisp
Post by: Kerry on March 31, 2014, 04:34:15 AM

I'm certain if you apply yourself you can do this without too much trouble.

Regards,

Title: Re: help with a lisp
Post by: pedroantonio on March 31, 2014, 06:47:47 AM

Kerry i can't find the error :embarrassed:

Code - Auto/Visual Lisp: [Select]

(DEFUN
   C:TEST (/ _OPTION1 _OPTION2 OLDARE AREA DXF ENT ANOX)
  (DEFUN _OPTION1 () (SETQ ANOX (* OLDARE 0.05)))
  (DEFUN _OPTION2 () (SETQ ANOX (* OLDARE 0.10)))
  ;; Main -----
  (IF (AND
        (SETQ ENT (CAR (ENTSEL "\nSelect a close polyline: ")))
        (SETQ OLDARE (GETREAL "\ngive old area : "))
        (WCMATCH
          (CDR (ASSOC 0 (SETQ DXF (ENTGET ENT))))
          "*POLYLINE"
        )
        (MEMBER (CDR (ASSOC 70 DXF)) '(1 129))
      )
    (PROGN
      (INITGET 7)
      (TEXTPAGE)
      (PROMPT
        "\n text1  :
 
   1. option 1
   2. option 2
        "
      )
      (SETQ
        AREA   (VLAX-CURVE-GETAREA ENT)
        OPTION (GETINT "choose 1 -->2: ")
      )
      (COND
        ((= OPTION 1) (_OPTION1))
        ((= OPTION 2) (_OPTION2))
        (T (ALERT "Select > 2 --> Auto select 2. ") (_OPTION2))
      )
      (PRINC
        (STRCAT
          "\n Area = "
          (RTOS AREA 2 2)
          " sqm"
          "\n Anotation Area = "
          (RTOS ANOX 2 2)
          " sqm"
          "\n comments: "
          "\n "
          (COND
            ((AND
               (>= AREA (- OLDARE ANOX))
               (<= AREA (+ OLDARE ANOX))
               (PRINC "\n comment1")
               ((AND
                  (> AREA (+ OLDARE ANOX))
                  (< AREA (- OLDARE ANOX))
                  (PRINC "\n comment2")
                )
               )
             )
             (PRINC "\nError selection of polyline ...")
            )
            (PRINC)
          )
          (PRINC)
        )
      )
    )
  )
)
 ;|«Visual LISP© Format Options»
(72 2 40 2 nil "end of " 60 2 2 2 1 nil nil nil T)
;*** DO NOT add text below the comment! ***|;
 
 

Title: Re: help with a lisp
Post by: snownut2 on March 31, 2014, 06:59:39 AM

Take a look at you parenthesis around the "and" functions, and it appears you have variables (ie; comment1 & comment2) being used as text in the princ line. Look at using the strcat function

example;

Code: [Select]

(and 
    (foo1)
    (foo2)
)

You've seen enough examples here from others that you can figure this out. (time to cowboy up)

Title: Re: help with a lisp
Post by: Kerry on March 31, 2014, 07:19:34 AM

Additionally ;

Your conditional statement is unbalanced.

Study this
Each branch consists of a self contained Test and a statement set to execute if the test is true.

Code - Auto/Visual Lisp: [Select]

(cond ((and (true-or-false-test-01)
            (true-or-false-test-02)
       )
       (setq xxx 0102)
      )
      ((and (true-or-false-test-03)
            (true-or-false-test-04)
       )
       (setq xxx 0304)
      )
      ((and (true-or-false-test-01)
            (true-or-false-test-03)
       )
       (setq xxx 0103)
      )
      ((and (true-or-false-test-02)
            (true-or-false-test-03)
       )
       (setq xxx 0203)
      )
)
 

Title: Re: help with a lisp
Post by: pedroantonio on April 01, 2014, 10:25:53 AM

Kerry i can not understand it. Can you help me.

Thanks

Title: Re: help with a lisp
Post by: Kerry on April 01, 2014, 10:48:23 AM

Untested

Code - Auto/Visual Lisp: [Select]

 
(defun
   C:TEST (/ _OPTION1 _OPTION2 OLDARE AREA DXF ENT ANOX)
  (defun _OPTION1 () (setq ANOX (* OLDARE 0.05)))
  (defun _OPTION2 () (setq ANOX (* OLDARE 0.10)))
  ;; Main -----
  (if (and
        (setq
          ENT
           (car (entsel "\nSelect a close polyline: "))
        )
        (setq OLDARE (getreal "\ngive old area : "))
        (wcmatch
          (cdr (assoc 0 (setq DXF (entget ENT))))
          "*POLYLINE"
        )
        (member (cdr (assoc 70 DXF)) '(1 129))
      )
    (progn
      (initget 7)
      (textpage)
      (prompt
        "\n text1  :
 
   1. option 1
   2. option 2
        "
      )
      (setq
        AREA   (vlax-curve-getarea ENT)
        OPTION (getint "choose 1 -->2: ")
      )
      (cond
        ((= OPTION 1) (_OPTION1))
        ((= OPTION 2) (_OPTION2))
        (t
         (alert "Select > 2 --> Auto select 2. ")
         (_OPTION2)
        )
      )
      (princ
        (strcat
          "\n Area = "
          (rtos AREA 2 2)
          " sqm"
          "\n Anotation Area = "
          (rtos ANOX 2 2)
          " sqm"
          "\n comments: "
          "\n "
          (cond
            ((and
               (>= AREA (- OLDARE ANOX))
               (<= AREA (+ OLDARE ANOX))
             )
             (princ "\n comment1")
            )
            ((and
               (> AREA (+ OLDARE ANOX))
               (< AREA (- OLDARE ANOX))
             )
             (princ "\n comment2")
            )
          )
        )
      )
    )
    (princ "\nError selection of polyline ...")
  )
  (princ)
)
 
 
 
 
 

Title: Re: help with a lisp
Post by: pedroantonio on April 01, 2014, 10:54:15 AM

Thank you Kerry

Title: Re: help with a lisp
Post by: pedroantonio on April 01, 2014, 11:38:16 AM

Kerry I have problem with print comment 2
I change litle bit the code . But i still have print problem .Can you check it.

Code - Auto/Visual Lisp: [Select]

(DEFUN
   C:TEST (/ _OPTION1 _OPTION2 OLDARE AREA DXF ENT ANOX T1 T2)
  (DEFUN _OPTION1 () (SETQ ANOX (* OLDARE 0.05)))
  (DEFUN _OPTION2 () (SETQ ANOX (* OLDARE 0.10)))
  ;; Main -----
  (IF (AND
        (SETQ ENT (CAR (ENTSEL "\nSelect a close polyline: ")))
        (SETQ OLDARE (GETREAL "\ngive old area : "))
        (WCMATCH
          (CDR (ASSOC 0 (SETQ DXF (ENTGET ENT))))
          "*POLYLINE"
        )
        (MEMBER (CDR (ASSOC 70 DXF)) '(1 129))
      )
    (PROGN
      (INITGET 7)
      (TEXTPAGE)
      (PROMPT
        "\n text1  :
 
   1. option 1
   2. option 2
        "
      )
      (SETQ
        AREA   (VLAX-CURVE-GETAREA ENT)
        OPTION (GETINT "choose 1 -->2: ")
      )
      (COND
        ((= OPTION 1) (_OPTION1))
        ((= OPTION 2) (_OPTION2))
        (T (ALERT "Select > 2 --> Auto select 2. ") (_OPTION2))
      )
      (SETQ T1 (- OLDARE ANOX))
      (SETQ T2 (+ OLDARE ANOX))
      (PRINC
        (STRCAT
          "\n Area = "
          (RTOS AREA 2 2)
          " sqm"
          "\n Anotation Area = ± "
          (RTOS ANOX 2 2)
          " sqm"
          "\n "
          "\n comments: "
          "\n "
          (COND
            ((AND (>= AREA T1) (<= AREA T2))
             (PRINC
               "\n "
               (RTOS T1 2 2)
               " sqm <="
               (RTOS AREA 2 2)
               " <= "
               (RTOS T2 2 2)
               " sqm"
               "\n comment1"
             )
            )
            ((AND (> AREA T2) (< AREA T1))
             (PRINC
               (PRINC
                 "\n "
                 (RTOS T1 2 2)
                 " sqm > "
                 (RTOS AREA 2 2)
                 " > "
                 (RTOS T2 2 2)
                 "sqm"
                 "\n comment2"
               )
             )
            )
          )
        )
      )
      (PRINC "\nError selection of polyline ...")
    )
    (PRINC)
  )
  ;|«Visual LISP© Format Options»
(72 2 40 2 nil "end of " 60 2 2 2 1 nil nil nil T)
;*** DO NOT add text below the comment! ***|;
)
 

Thank you

Title: Re: help with a lisp
Post by: Kerry on April 01, 2014, 11:45:53 AM

Explain EXACTLY what is wrong.
What are your pre-condition values ?
What do you expect What ?
and what you get what ?

For the cause of the problem, look first at the things you changed.

Added:
Looking at your code, you need to fix the last several lines of code.
Compare my post with yours.
I'll look at your comment code when you respond satisfactorily to my information request.

Title: Re: help with a lisp
Post by: pedroantonio on April 01, 2014, 12:58:39 PM

Sorry Kerry.I will explain you now..

I want
a) when T1< = Area <= T2 to print T1< = Area <= T2 and comment 1
b) when T1>Area >T2 to print T1> Area > T2 and comment 2

Your code works only for comment 1 , for comment 2 gives error. I add in the code ths lines

Code - Auto/Visual Lisp: [Select]

 
 
(SETQ T1 (- OLDARE ANOX))
(SETQ T2 (+ OLDARE ANOX))
--------------------
-----------------
 
COND
            ((AND (>= AREA T1) (<= AREA T2))
             (PRINC
               "\n "
               (RTOS T1 2 2)
               " sqm <="
               (RTOS AREA 2 2)
               " <= "
               (RTOS T2 2 2)
               " sqm"
               "\n comment1"
             )
            )
            ((AND (> AREA T2) (< AREA T1))
             (PRINC
               (PRINC
                 "\n "
                 (RTOS T1 2 2)
                 " sqm > "
                 (RTOS AREA 2 2)
                 " > "
                 (RTOS T2 2 2)
                 "sqm"
                 "\n comment2"
               )
 

but i still have problem with the results . I test the code in autocad vlisp editor but i can not find were the problem is. if you can help.

Thanks

Title: Re: help with a lisp
Post by: Kerry on April 01, 2014, 01:05:11 PM

You're going to have to learn to listen bud !
I didn't ask for freaking code, I asked for data.

Give me values for comment 1
Area :
OLDARE :
ANOX :

Give me values for comment 2
Area :
OLDARE :
ANOX :

... as many combinations as you like.

Without knowing the data and the expected results I may as well just walk away.

added:
and please confirm the rules because this isn't what you've coded.

Quote

I want
a) when T1<= Area <= T2 to print T1<= Area <= T2 and comment 1
b) when T1 > Area >T2 to print T1> Area >T2 and comment 2

Title: Re: help with a lisp
Post by: pedroantonio on April 01, 2014, 01:28:52 PM

Karry here is the example

for option 1 (comment 1)
OLD AREA 8000sqm
Area 8062sqm
Anox 8000 * 0.05 = 400 sqm
T1 = 8000 - 400 = 7600 sqm
T2 = 8000 + 400 = 8400 sqm

7600< 8062 <8400 so
comment 1

for option 1 (comment 2)

OLD AREA 8000sqm
Area 9500sqm
Anox 8000 * 0.05 = 400 sqm
T1 = 8000 - 400 = 7600 sqm
T2 = 8000 + 400 = 8400 sqm

7600>9500 >8400 so
comment 2
-----------------------------------------------

for option 2 (comment 1)
OLD AREA 8000sqm
Area 7500sqm
Anox 8000 * 0.10 = 800 sqm
T1 = 8000 - 800 = 7200 sqm
T2 = 8000 + 800 = 8800 sqm

7200< 7500 <8800 so
comment 1

for option 2 (comment 2)

OLD AREA 8000sqm
Area 7100sqm
Anox 8000 * 0.10 = 800 sqm
T1 = 8000 - 800 = 7200 sqm
T2 = 8000 + 800 = 8800 sqm

Here we have a change in the code

7200>7100 so
comment 2

if we have

for option 2 (comment 2)

OLD AREA 8000sqm
Area 8950sqm
Anox 8000 * 0.10 = 800 sqm
T1 = 8000 - 800 = 7200 sqm
T2 = 8000 + 800 = 8800 sqm

Here we have a change in the code

8950 > 8800 so
comment 2

The comment 2 i thing need 3 options
T1>Area>T2
T1>Area
T2< Area

Title: Re: help with a lisp
Post by: Kerry on April 01, 2014, 02:02:35 PM

for option 1 (comment 2)

OLD AREA 8000sqm
Area 9500sqm
Anox 8000 * 0.05 = 400 sqm
T1 = 8000 - 400 = 7600 sqm
T2 = 8000 + 400 = 8400 sqm

7600>9500 >8400 so
comment 2
-----------------------------------------------

7600>9500 >8400 This is crap.

Title: Re: help with a lisp
Post by: pedroantonio on April 01, 2014, 02:09:57 PM

I know thats why i write

Quote

The comment 2 i thing need 3 options
T1>Area>T2
T1>Area
T2< Area

Title: Re: help with a lisp
Post by: ymg on April 01, 2014, 02:22:03 PM

Kerry,

Here somethig I use quite often as a test condition:

Quote

1$ (< 2 5 7)
T
_1$ (< 2 1 7)
nil

Title: Re: help with a lisp
Post by: Kerry on April 01, 2014, 02:31:14 PM

Please Test this in isolation :

Code - Auto/Visual Lisp: [Select]

 
(defun _PrintComments ()
  (setq T1 (- OLDARE ANOX))
  (setq T2 (+ OLDARE ANOX))
  (princ (strcat "\n ----------------"
                 (strcat "\n Area = " (rtos AREA 2 2) " sqm")
                 (strcat "\n Old Area = " (rtos oldare 2 2) " sqm")
                 (strcat "\n Anotation Area = ± " (rtos ANOX 2 2) " sqm")
                 "\n comments: "
         )
  )
  (cond
    ((<= T1 AREA T2)
     (princ (strcat "\n ----------------\n "
                    (strcat (rtos T1 2 2)
                            " sqm <= "
                            (rtos AREA 2 2)
                            " <= "
                            (rtos T2 2 2)
                            " sqm"
                    )
                    "\n comment1:"
            )
     )
    )
    ((> T1 AREA T2)
     (princ (strcat "\n ----------------\n "
                    (strcat (rtos T1 2 2)
                            " sqm > "
                            (rtos AREA 2 2)
                            " > "
                            (rtos T2 2 2)
                            " sqm"
                    )
                    "\n comment2:"
            )
     )
    )
    ((> T1 AREA)
     (princ
       (strcat "\n ----------------\n "
               (strcat (rtos T1 2 2) " sqm > " (rtos AREA 2 2) " sqm")
               "\n comment2:"
       )
     )
    )
    ((< T2 AREA)
     (princ
       (strcat "\n ----------------\n "
               (strcat (rtos T2 2 2) " sqm < " (rtos AREA 2 2) " sqm")
               "\n comment2:"
       )
     )
    )
    (t (princ "\n ----------------\n No suitable data."))
  )
  (princ "\n =======================\n")
  (princ)
)
 

With these tests
.... and I'd suggest you write some tests of your own as well.

Code - Auto/Visual Lisp: [Select]

 
;; TESTING CODE for (_PrintComments)
 
;; for option 1 (comment 1)
(setq area   8062
      oldare 8000
      anox   (* OLDARE 0.05)
      var    (_PrintComments)
)
;; for option 1 (comment 2)
(setq area   9500
      oldare 8000
      anox   (* OLDARE 0.05)
      var    (_PrintComments)
)
 
 
 
;; for option 2 (comment 1)
(setq area   7500
      oldare 8000
      anox   (* OLDARE 0.10)
      var    (_PrintComments)
)
;; for option 2 (comment 2)
(setq area   7100
      oldare 8000
      anox   (* OLDARE 0.10)
      var    (_PrintComments)
)
 
;; for option 2 (comment 2)
(setq area   8950
      oldare 8000
      anox   (* OLDARE 0.10)
      var    (_PrintComments)
)
 
 
 

My Results :

Quote

----------------
Area = 8062.00 sqm
Old Area = 8000.00 sqm
Anotation Area = ± 400.00 sqm
comments:
----------------
7600.00 sqm <= 8062.00 <= 8400.00 sqm
comment1:
=======================

----------------
Area = 9500.00 sqm
Old Area = 8000.00 sqm
Anotation Area = ± 400.00 sqm
comments:
----------------
8400.00 sqm < 9500.00 sqm
comment2:
=======================

----------------
Area = 7500.00 sqm
Old Area = 8000.00 sqm
Anotation Area = ± 800.00 sqm
comments:
----------------
7200.00 sqm <= 7500.00 <= 8800.00 sqm
comment1:
=======================

----------------
Area = 7100.00 sqm
Old Area = 8000.00 sqm
Anotation Area = ± 800.00 sqm
comments:
----------------
7200.00 sqm > 7100.00 sqm
comment2:
=======================

----------------
Area = 8950.00 sqm
Old Area = 8000.00 sqm
Anotation Area = ± 800.00 sqm
comments:
----------------
8800.00 sqm < 8950.00 sqm
comment2:
=======================

Then if you're happy try the combined code on real entitys.

Code - Auto/Visual Lisp: [Select]

 
(defun C:TEST (/         _PrintComments      _Option1  _Option2
               OLDARE    AREA      DXF       ENT       ANOX
               T1        T2
              )
  (defun _Option1 () (setq ANOX (* OLDARE 0.05)))
  (defun _Option2 () (setq ANOX (* OLDARE 0.10)))
  (defun _PrintComments ()
    (setq T1 (- OLDARE ANOX))
    (setq T2 (+ OLDARE ANOX))
    (princ
      (strcat "\n ----------------"
              (strcat "\n Area = " (rtos AREA 2 2) " sqm")
              (strcat "\n Old Area = " (rtos oldare 2 2) " sqm")
              (strcat "\n Anotation Area = ± " (rtos ANOX 2 2) " sqm")
              "\n comments: "
      )
    )
    (cond
      ((<= T1 AREA T2)
       (princ (strcat "\n ----------------\n "
                      (strcat (rtos T1 2 2)
                              " sqm <= "
                              (rtos AREA 2 2)
                              " <= "
                              (rtos T2 2 2)
                              " sqm"
                      )
                      "\n comment1:"
              )
       )
      )
      ((> T1 AREA T2)
       (princ (strcat "\n ----------------\n "
                      (strcat (rtos T1 2 2)
                              " sqm > "
                              (rtos AREA 2 2)
                              " > "
                              (rtos T2 2 2)
                              " sqm"
                      )
                      "\n comment2:"
              )
       )
      )
      ((> T1 AREA)
       (princ
         (strcat "\n ----------------\n "
                 (strcat (rtos T1 2 2) " sqm > " (rtos AREA 2 2) " sqm")
                 "\n comment2:"
         )
       )
      )
      ((< T2 AREA)
       (princ
         (strcat "\n ----------------\n "
                 (strcat (rtos T2 2 2) " sqm < " (rtos AREA 2 2) " sqm")
                 "\n comment2:"
         )
       )
      )
      (t (princ "\n ----------------\n No suitable data."))
    )
    (princ "\n =======================\n")
    (princ)
  )
  ;; Main -----
  (if
    (and (setq ENT (car (entsel "\nSelect a close polyline: ")))
         (wcmatch (cdr (assoc 0 (setq DXF (entget ENT)))) "*POLYLINE")
         (member (cdr (assoc 70 DXF)) '(1 129))
         (setq OLDARE (getreal "\ngive old area : "))
    )
     (progn
       (initget 7)
       (textpage)
       (prompt "\n text1  :
 
   1. option 1
   2. option 2
        "
       )
       (setq AREA   (vlax-curve-getarea ENT)
             OPTION (getint "choose 1 -->2: ")
       )
       (cond ((= OPTION 1) (_Option1))
             ((= OPTION 2) (_Option2))
             (t (alert "Select > 2 --> Auto select 2. ") (_Option2))
       )
       (_PrintComments)
     )
     (princ "\nError selection of polyline ...")
  )
  (princ)
)
 

Title: Re: help with a lisp
Post by: pedroantonio on April 01, 2014, 02:52:01 PM

thank you kerry i will test it..

Title: Re: help with a lisp
Post by: pedroantonio on April 04, 2014, 03:48:29 AM

Hello Kerry ..
I tried to add some comments on the results to the first code of this topic. The above method for showing me is difficult to use it because the Oprtion 2 and Option 3 have the same area 2000, but different comments. So I decided to add the comments in the code of each option. But something is written wrong but i don't know what.I don't know how to use (_PRINTCOMMENTS) .Could you help me with the code.
Thanks

Code - Auto/Visual Lisp: [Select]

(DEFUN
   C:DOMKAL (/ _PRINTCOMMENTS _OPTION1 _OPTION2 _OPTION3 _OPTION4 AREA
             DXF ENT SDAREA SKAREA
            )
  (DEFUN
     _OPTION1 ()
    (COND
      ((< AREA 200)
       (SETQ
         SDAREA AREA
         SKAREA
          (* AREA 0.7)
       )
       (PRINC
         (STRCAT
           "\n ---------------------\n "
           "\n bla bla bla bla."
           "\n bla bla bla bla."
           "\n bla bla bla bla."
           "\n bla bla bla bla."
          )
       )
      )
      ((< AREA 700)
       (SETQ
         SDAREA 240
         SKAREA
          (* AREA 0.6)
         (PRINC
           (STRCAT
             "\n ---------------------\n "
             "\n bla bla bla bla."
             "\n bla bla bla bla."
             "\n bla bla bla bla."
             "\n bla bla bla bla."
            )
         )
       )
       ((>= AREA 700)
         (SETQ
           SDAREA 400
           SKAREA
            (* AREA 0.6)
           (PRINC
             (STRCAT
               "\n ---------------------\n "
               "\n bla bla bla bla."
               "\n bla bla bla bla."
               "\n bla bla bla bla."
               "\n bla bla bla bla."
              )
           )
         )
       )
      )
      (DEFUN
       _OPTION2
       ()
       (COND
         ((<= AREA 2000)
          (SETQ
            SDAREA
             (* AREA 0.8)
            SKAREA
             (* AREA 0.6)
            (PRINC
              (STRCAT
                "\n ---------------------\n "
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
               )
            )
          )
          ((> AREA 2000)
            (SETQ
              SDAREA
               (+ 400 (* 0.05 (- AREA 2000)))
              SKAREA
               (* AREA 0.1)
              (PRINC
                (STRCAT
                  "\n ---------------------\n "
                  "\n bla bla bla bla."
                  "\n bla bla bla bla."
                  "\n bla bla bla bla."
                  "\n bla bla bla bla."
                 )
              )
            )
          )
         )
         (DEFUN
          _OPTION3
          ()
          (COND
            ((= AREA 750)
             (SETQ
               SDAREA 100
               SKAREA
                (* AREA 0.1)
               (PRINC
                 (STRCAT
                   "\n ---------------------\n "
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                  )
               )
             )
            )
            ((AND (> AREA 750) (<= AREA 1200))
             (SETQ
               SDAREA
                (+ 100 (/ (- AREA 750) 9))
               SKAREA
                (* AREA 0.1)
               (PRINC
                 (STRCAT
                   "\n ---------------------\n "
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                  )
               )
             )
            )
            ((AND (> AREA 1200) (<= AREA 2000))
             (SETQ
               SDAREA
                (+ 150 (/ (- AREA 1200) 16))
               SKAREA
                (* AREA 0.1)
               (PRINC
                 (STRCAT
                   "\n ---------------------\n "
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                   "\n bla bla bla bla."
                  )
               )
             )
            )
            ((AND (> AREA 2000) (< AREA 4000))
             (SETQ
               SDAREA 0
               SKAREA 0
               (PRINC
                 (STRCAT
                   "\n ---------------------\n "
               "\n bla bla bla bla."
                "\n bla bla bla bla."
               "\n bla bla bla bla."
                "\n bla bla bla bla."
             )
            )
          )
         )
         ((= AREA 4000)
          (SETQ
            SDAREA 200
            SKAREA
             (* AREA 0.1)
            (PRINC
              (STRCAT
                "\n ---------------------\n "
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
               )
            )
          )
         )
         ((AND (> AREA 4000) (<= AREA 8000))
          (SETQ
            SDAREA
             (+ 200 (* 0.02 (- AREA 4000)))
            SKAREA
             (* AREA 0.1)
            (PRINC
              (STRCAT
                "\n ---------------------\n "
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
               )
            )
          )
         )
         ((> AREA 8000)
          (SETQ
            SDAREA
             (+ 280 (* 0.01 (- AREA 8000)))
            SKAREA
             (* AREA 0.1)
            (PRINC
              (STRCAT
                "\n ---------------------\n "
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
               )
            )
          )
         )
       )
       (DEFUN
          _OPTION4 ()
         (INITGET 7)
         (SETQ SDAREA (* AREA (GETREAL "\n Give sd (example 1.2) : ")))
         (INITGET 7)
         (SETQ SKAREA (* AREA (GETREAL "\nGive sk (example 0.70) : ")))
       )
       (PRINC
         (STRCAT
           "\n Print Results"
           "\n -----------------------"
           (STRCAT "\n Selected Area = " (RTOS AREA 2 2) " sq.m")
           (STRCAT "\n D = " (RTOS SDAREA 2 2) " sq.m")
           (STRCAT "\n K = " (RTOS SKAREA 2 2) " sq.m")
           "\n"
           "\n comments: "
         )
         (PRINC
              (STRCAT
                "\n ---------------------\n "
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
                "\n bla bla bla bla."
               )
            )
      )
    )
    (T
      (PRINC
        "\n ---------------------\nNo valid polyline selected..."
      )
    )
  )
  (PRINC
    "\n ========================================================================\n"
  )
  (PRINC)
)
;; Main -----
(IF (AND
      (SETQ ENT (CAR (ENTSEL "\nSelect a close polyline: ")))
      (WCMATCH
        (CDR (ASSOC 0 (SETQ DXF (ENTGET ENT))))
        "*POLYLINE"
      )
      (MEMBER (CDR (ASSOC 70 DXF)) '(1 129))
    )
  (PROGN
    (INITGET 7)
    (TEXTPAGE)
    (PROMPT
      "\nChoose an option:
 
   1. Oprion 1
   2. Option 2
   3. Option 3
   4. Option 4
 
"   )
    (SETQ
      AREA   (VLAX-CURVE-GETAREA ENT)
      OPTION (GETINT "choose 1 -->4:  ")
    )
    (COND
      ((= OPTION 1) (_OPTION1))
      ((= OPTION 2) (_OPTION2))
      ((= OPTION 3) (_OPTION3))
      ((= OPTION 4) (_OPTION4))
      (T (ALERT "Select > 4 --> Auto select 4. ") (_OPTION4))
    )
    (_PRINTCOMMENTS)
  )
  (PRINC "\nError selection of polyline ...")
)
(PRINC)
)
;|«Visual LISP© Format Options»
(72 2 40 2 nil "end of " 60 2 2 2 1 nil nil nil T)
;*** DO NOT add text below the comment! ***|;
 
 

Title: Re: help with a lisp
Post by: Kerry on April 04, 2014, 04:06:18 AM

I don't have time to play.

Break the problem down to about half a page of code so you understand what is happening.

Title: Re: help with a lisp
Post by: Kerry on April 04, 2014, 04:47:02 AM

This is probably the best advice I can offer.

(http://i62.tinypic.com/2mww7ww.png)

Title: Re: help with a lisp
Post by: pedroantonio on April 04, 2014, 09:31:42 AM

show me one example from Option 1 and i will try the others

Title: Re: help with a lisp
Post by: snownut2 on April 04, 2014, 05:30:35 PM

Quote from: Topographer on April 04, 2014, 09:31:42 AM

show me one example from Option 1 and i will try the others

Really Pedro, did you not understand Kerry's GRAPH.

Title: Re: help with a lisp
Post by: Kerry on April 04, 2014, 07:41:42 PM

It seems to me that because of your the changed logic, the (_PRINTCOMMENTS) is no longer required. .. or perhaps you do .. I no longer understand what you want.

Perhaps something like this structure would suit better

Code - Auto/Visual Lisp: [Select]

 
 
(defun c:MyRoutine ( / Routine_Functions Routine_variables)
  
  (defun *error* () (princ))
  (defun _SelectBoundary () (princ))
  (defun _PromptForOption () (princ))
  (defun _PromptForOldArea () (princ))
  (defun _OptionController () (princ))
  (defun _ProcessOption1 () (princ))
  (defun _ProcessOption2 () (princ))
  (defun _ProcessOption3 () (princ))
  (defun _ProcessOption4 () (princ))
  (defun _CalculateAndPrintArea () (princ))
  ;;
  ;;-- Main
  (if
    (not (and (_SelectBoundary)
              (_PromptForOption)
              (_PromptForOldArea)))
     (exit)
  )
  (_OptionController)
  (princ)
)
 
 

Just for giggles: If you renamed these variables to something that had obvious meaning, what would the new names be ?

ANOX
T1
T2
AREA <-- is not a good name because it duplicates an AutoCAD command name.
OLDARE
SDAREA
SKAREA

How does the user know which option to choose.

Title: Re: help with a lisp
Post by: Kerry on April 04, 2014, 08:10:48 PM

Then fill out the logic flow functionality.

Code - Auto/Visual Lisp: [Select]

 
(defun c:MyRoutine ()
  (defun *error* () (princ))
  (defun _SelectBoundary () (princ))
  (defun _PromptForOption () (princ))
  (defun _PromptForOldArea () (princ))
  (defun _OptionController ()
    ;; Calculate BoundaryArea
    (cond ((= OPTION 1) (_ProcessOption1))
          ((= OPTION 2) (_ProcessOption2))
          ((= OPTION 3) (_ProcessOption3))
          ((= OPTION 4) (_ProcessOption4))
          (t (alert "Select > 4 --> Auto select 4. ") (_ProcessOption4))
    )
    (princ)
  )
  (defun _ProcessOption1 ()
    (cond ((< AREA 200)
           ;; Calculate area related values
           ;; Print option comments
          )
          ((< AREA 700)
           ;; Calculate area related values
           ;; Print option comments
          )
          ((>= AREA 700)
           ;; Calculate area related values
           ;; Print option comments
          )
    )
    (princ)
  )
  (defun _ProcessOption2 ()
    (cond ((<= AREA 2000)
           ;; Calculate area related values
           ;; Print option comments
          )
          ((> AREA 2000)
           ;; Calculate area related values
           ;; Print option comments
          )
    )
    (princ)
  )
  (defun _ProcessOption3 ()
    (cond ((and (> AREA 750) (<= AREA 1200))
           ;; Calculate area related values
           ;; Print option comments
          )
          ((and (> AREA 1200) (<= AREA 2000))
           ;; Calculate area related values
           ;; Print option comments
          )
          ((and (> AREA 2000) (< AREA 4000))
           ;; Calculate area related values
           ;; Print option comments
          )
          ((= AREA 4000)
           ;; Calculate area related values
           ;; Print option comments
          )
          ((and (> AREA 4000) (<= AREA 8000))
           ;; Calculate area related values
           ;; Print option comments
          )
          ((> AREA 8000)
           ;; Calculate area related values
           ;; Print option comments
          )
    )
    (princ)
  )
  (defun _ProcessOption4 ()
    ;; Prompt for criteria
    ;; Calculate area related values
    ;; Print option comments
    (princ)
  )
  (defun _CalculateAndPrintComments ()
    ;; Similar to old  (_PrintComments)
    (princ)
  )
  ;;
  ;;-- Main
  ;;
  (if
    (not (and (_SelectBoundary) (_PromptForOption) (_PromptForOldArea)))
     (exit)
  )
  (_OptionController)
  (_CalculateAndPrintComments)
  (princ)
)
 

Print this because it is your roadmap.
If you change the logic, change this first.

Save and rename this then continue filling in functionality.

Title: Re: help with a lisp
Post by: pedroantonio on April 05, 2014, 12:28:24 PM

i fix it thanks

TheSwamp

Code Red => AutoLISP (Vanilla / Visual) => Topic started by: pedroantonio on March 24, 2014, 09:36:50 AM