Topic: Error Handling

[Lupo76]

Hello everyone,

for error handling I use the following code:

Code: [Select]

(defun c:TEST (/ var msgg var_ORTHOMODE  snapcorr var_INSUNITSDEFSOURCE var_INSUNITSDEFTARGET var_INSUNITS var_OSNAPZ OSNAPZ)
  ;*************************************
  (setq var (getvar "CMDECHO"))
  (setvar "CMDECHO" 0)
  (setq old-error *error*)
  (defun *error* (msg)
     (setq msgg (strcat "Error: " msg))
     (princ msgg)
     (setq *error* old-error)
     (command "_.undo" "_end" "_u")
     (exit)
  )
  (command "_.undo" "_be") 
 
  (setq snapcorr (getvar "OSMODE"))
  (setvar "OSMODE" 0)
 
  (setq var_INSUNITSDEFSOURCE (getvar "INSUNITSDEFSOURCE"))
  (setq var_INSUNITSDEFTARGET (getvar "INSUNITSDEFTARGET"))
  (setq var_INSUNITS (getvar "INSUNITS"))
  (setq var_OSNAPZ (getvar "OSNAPZ"))

  (setvar "INSUNITSDEFSOURCE" 0)
  (setvar "INSUNITSDEFTARGET" 0)
  (setvar "INSUNITS" 0)
  (setvar "OSNAPZ" 1)
  ;*************************************


   ....custom code....
   ....custom code....
   ....custom code....
   ....custom code....


  ;*************************************
  (setvar "INSUNITSDEFSOURCE" var_INSUNITSDEFSOURCE)
  (setvar "INSUNITSDEFTARGET" var_INSUNITSDEFTARGET)
  (setvar "INSUNITS" var_INSUNITS)
  (setvar "OSNAPZ" var_OSNAPZ)
 
  (setvar "OSMODE" snapcorr)
 
  (setq *error* old-error)
  (command "_.undo" "_end")
  (setvar "cmdecho" var)
  (princ)
  ;*************************************
)


Unfortunately, if the user presses ESC when running object snaps are not recovered.
What am I doing wrong?

[Lupo76]

I solved it by yourself!

in custom code, I used to call a function that I had one line of code too
I'm glad to have found this bug because this function was used many times in my code

[ur_naz]

you can use something like below to improve your commands

Code - Auto/Visual Lisp: [Select]

1. (defun _start_undo ()
2.  
3.   (_end_undo)
4.   (vla-StartUndoMark (vla-get-ActiveDocument (vlax-get-acad-object)))
5. )
6.  
7. (defun _end_undo ()
8.  
9.   (if (logand 8 (getvar "UNDOCTL"))
10.         (vla-EndUndoMark (vla-get-ActiveDocument (vlax-get-acad-object)))
11.   )
12. )
13.  
14. (defun _save_var (lst)
15.  
16.   (mapcar '(lambda (x) (cons x (getvar x))) lst)
17.  
18. )
19.  
20. (defun _restore_var (lst)
21.  
22.   (foreach item lst
23.     (setvar (car item) (cdr item))
24.   )
25.  
26. )
27.  
28. (defun _err (msg)
29.   (if
30.     (member
31.       (strcase msg T)
32.      '("function cancelled"
33.         "console break"
34.         "quit / exit abort"
35.       )
36.     )
37.     (princ "\nExiting!")
38.     (princ (strcat "\nERROR: " (itoa (getvar 'errno)) " - " msg))
39.   )
40.  
41.   (end_cmd)
42.  
43. )
44.  
45. (defun start_cmd ( / svlist)
46.  
47.   (vl-load-com)
48.  
49.   (_start_undo)
50.  
51.   (setq svlist '( attdia cmddia blipmode clayer cmdecho osmode
52.                   cmddia shortcutmenu insunits peditaccept ))
53.  
54.  
55.  
56.   (setq *sysvarstack* (_save_var svlist)
57.         *olderr* *error*
58.         *error*  _err
59.   )
60. )
61.  
62. (defun end_cmd ()
63.   (_restore_var *sysvarstack*)
64.   (setq *error* *olderr* *olderr* nil)
65.   (_end_undo)
66.   (redraw)
67.   (princ "\nReady!")
68.   (princ)
69. )
70.  
71. (defun _set_ui_mode (osm)
72.   (setvar 'cmdecho 1)
73.   (setvar 'osmode osm)
74.  
75. )
76.  
77. (defun _set_rotate_mode (osm)
78.  (setvar 'cmdecho 0)
79.  (setvar 'osmode osm)
80. )
81.  
82. (defun _set_ins_mode (osm)
83.   (mapcar 'setvar
84.    '(cmdecho     attdia  cmddia  blipmode    shortcutmenu    insunits)
85.    '(0           0       0       0           0               4)
86.   )
87.   (setvar 'osmode osm)
88. )
89.  
90. (defun _set_dw_mode ()
91.   (mapcar 'setvar '(cmdecho osmode blipmode) '(0 0 0))
92. )