If you could e-mail me back at ...
No way, you asked for it in public, now you're getting the comments in public, too
Before suggesting any changes, here are some questions and comments:
- You say that the routine is for changing the linetype, yet I don't see where it changes the current linetype?
- Are you sure that you want to force the user to hit escape in order to exit from the routine without doing changes? INITGET 1 is for very rare cases where input is essential for further processing. It's not for irritating the user.
- You forgot to include the initial oldxxx assignments in a SETQ
- Are you sure you want to force OSMODE and BLIPMODE to 0? If that is the case, why are you saving their current values?? It's not necessary, either, to save the current values of CLAYER and PLINEWID if your intention is that the routine will change them.
- Setting OSMODE and BLIPMODE to 0 within all conditions are unnecessary repetitions.
- If setting OSMODE and BLIPMODE to 0 and leaving them that way is NOT intentional, then you need to include code that restore their values.
- What will happen if the layers are not present in the drawing when using CLAYER to set a layer currently active? (if you include CELTYPE to change the current linetype then the same question applies)