Topic: Check my code?

[StykFacE]

I put this in our AcadDoc.lsp file, and was wondering if I managed to do this correctly. My first attempt at a conditional statement. Read up in the developer help and AfraLisp today to create this simple code.

Code: [Select]

(if
  (= 1 (getvar 'selectionannodisplay))
   (setvar "selectionannodisplay" 0)
)
(princ)

We are migrating to all Annotative Objects for dims, mleaders, text, etc and I wanted this variable always to be at zero. Any thoughts would be much appreciated!! Thanks in advance.

- Tannar

[Matt__W]

Technically it's an "IF" statement.  Or... "if/then" to be more precise.   

[andrew_nao]

I put this in our AcadDoc.lsp file, and was wondering if I managed to do this correctly. My first attempt at a conditional statement. Read up in the developer help and AfraLisp today to create this simple code.

Code: [Select]

(if
  (= 1 (getvar 'selectionannodisplay))
   (setvar "selectionannodisplay" 0)
)
(princ)


We are migrating to all Annotative Objects for dims, mleaders, text, etc and I wanted this variable always to be at zero. Any thoughts would be much appreciated!! Thanks in advance.

- Tannar

look ok to me although i would put it like

Code: [Select]

(if (=  (getvar 'selectionannodisplay) 1)
   (setvar "selectionannodisplay" 0)
)
its really preference, 6 of one and a half dozen of another

[BlackBox]

First, there's nothing wrong with your code as written in the OP.

In cases where you want to 'force' a particular system variable value, there's really no need to check, per-se. I've seen it both ways.


Separately, since you're starting to find things you want to do in LISP, you might find this related snippet useful at some point:

Code - Auto/Visual Lisp: [Select]

1. (vl-load-com)
2.  
3. (foreach x '((selectionannodisplay 0)
4.              ;;<-- other sysvars
5.             )
6.   (vl-catch-all-apply 'setvar x)
7. )
8.  

[StykFacE]

Technically it's an "IF" statement.  Or... "if/then" to be more precise.   

Lol, before I even called it a conditional I checked the AfraLisp site.... I'm so non-LISP-literate it's not even funny. Thanks tho, much appreciated Matt.

In cases where you want to 'force' a particular system variable value, there's really no need to check, per-se. I've seen it both ways.

The reason I was "checking" the variable is so that if it's already set, it doesn't change the file and always get the annoying Save dialog box when you just open/close and no changes were made. Kinda like doing some batch file open/close stuff from time to time - didn't want anything to interfere. Hopefully I'm making sense, and my approach was correct in this? Oh and thanks for the code, read up on it a bit and I can definitely see this as useful.

On a side note, I have some personal commentary. Even tho this is about as simple as you can get I'm proud of it. First, for actually digging up the info and not giving up by coming here screaming "Help me!". I did have about 10 minutes of trial and error, and I found that in the VLIDE I was highlighting just the selection of code and using the "Load Selection" tool to break down functions one at a time to see if there was errors or if it returned a value. RenderMan, I actually had to reference your last little snippet you gave me regarding the custom AcadDoc.lsp file load. The apostrophe before the variable was my biggest set back for a bit, lol.

Anyways, thanks again gents. Hopefully I can build off this. :kewl:

[BlackBox]

The reason I was "checking" the variable is so that if it's already set, it doesn't change the file and always get the annoying Save dialog box when you just open/close and no changes were made. Kinda like doing some batch file open/close stuff from time to time - didn't want anything to interfere. Hopefully I'm making sense, and my approach was correct in this?

First thing, is that the SelectionAnnodisplay System Variable is stored to the Registry, not the Drawing, so you can make the change and still close the Drawing without the notification.

Second, you may find the acad-push-dbmod, and acad-pop-dbmod functions to be of use. 

Oh and thanks for the code, read up on it a bit and I can definitely see this as useful.

... Even tho this is about as simple as you can get I'm proud of it.

You're welcome, and as you should be. :beer:

[StykFacE]

Second, you may find the acad-push-dbmod, and acad-pop-dbmod functions to be of use. 

Ah, so I can temporarily disable the save trigger then re-enable it? If I read all that right, cool stuff!!

[Lee Mac]

Technically it's an "IF" statement.  Or... "if/then" to be more precise.   

Technically an "IF" statement is a conditional statement 

[Matt__W]

Technically it's an "IF" statement.  Or... "if/then" to be more precise.   

Technically an "IF" statement is a conditional statement 

Code: [Select]

If funnyResponse = True then
   epicWin
else
   epicFail
End If

[CAB]

In case this thread might have been missed:
http://www.theswamp.org/index.php?topic=44026.0

[StykFacE]

In case this thread might have been missed:
http://www.theswamp.org/index.php?topic=44026.0

Very good info, thanks CAB. That information is well explained by you and Lee.