Topic: Very specific issue using DCL dialog causes ACAD to freeze every time...

[Ben Clark]

So I'm moving items in a list up and down exactly like Lee Mac's tab sort program. I'm even using functions he wrote called lm:listdown and lm:listup.

http://www.lee-mac.com/tabsort.html
http://www.lee-mac.com/listboxfunctions.html

When I run my code and press a dcl button that moves an item in a list up one row, ACAD completely and irrecoverably freezes every time without fail.

This thread: https://www.theswamp.org/index.php?topic=9281.0 seems to indicate that using set_tile right after end_list would cause this. But I have no idea why and and I have no idea how to fix it.

any help is appreciated.

Code: [Select]


; moveup is called by a button to move an item up in a dcl listbox

(defun moveup (/ setindex nameslist nameslistnew)

(setq
setindex (atoi (get_tile "msnameslist"))
nameslist (vlax-ldata-get "msnames" "msnameslist")
nameslistnew (cadr (lm:listup (list setindex) nameslist))
)

(vlax-ldata-put "msnames" "msnameslist" nameslistnew)

(ms-listbox)

(set_tile "msnameslist" (rtos (- setindex 1)))
)


; This refreshes the dcl listbox

(defun ms-listbox (/ msnameslist)

(setq msnameslist (vlax-ldata-get "msnames" "msnameslist"))

(start_list "msnameslist")
  (mapcar 'add_list msnameslist)
  (end_list)
)




[roy_043]

What stands out is the use of rtos instead of itoa.
And it may be worth checking how AC responds if the index becomes negative.

Your use of ldata is peculiar: why don't you pass the list as an argument to the functions?

[Ben Clark]

Thanks for the reply Roy.

You're absolutely right about the ldata thing. Not sure why I'm calling it in the refresh function when it was already called and could be passed as an argument.

Don't rtos and itoa do the same thing if passed an integer?



EDIT: Thanks, Roy. you just solved my problem. I switched to itoa and it fixed it... I just feel a little dum now.

[Lee Mac]

Don't rtos and itoa do the same thing if passed an integer?

Only if supplied with a units argument of 2 and a precision argument of 0 [e.g. (rtos <number> 2 0)], or with no arguments if LUNITS=2 and LUPREC=0.

[Ben Clark]

Thanks, Lee. That clears that up.

And thanks for making those list functions public . That helped me out a lot.